Skip to content

[NoQA] Report upgrade path + Bulk move expenses#70663

Merged
cristipaval merged 22 commits intoExpensify:mainfrom
callstack-internal:feat/68995-bulk-move-expenses
Sep 19, 2025
Merged

[NoQA] Report upgrade path + Bulk move expenses#70663
cristipaval merged 22 commits intoExpensify:mainfrom
callstack-internal:feat/68995-bulk-move-expenses

Conversation

@koko57
Copy link
Contributor

@koko57 koko57 commented Sep 16, 2025

Explanation of Change

Fixed Issues

$ #68994
$ #68989
$ #68995
PROPOSAL:

Tests

PREREQUISITES: in Permissions.ts change the returned value from canUseUnreportedExpense to true

#68994

  1. Have an account with an active workspace
  2. Go to selfDM and create a new expense
  3. Verify that an actionable whisper from Concierge is created with the options: “Send to someone” and “Do nothing”
  4. Click on the newly created expense
  5. Click on the Report field
  6. Verify that you have the option to create a new report
  7. Click on that option and verify that the expense is now moved to a new report linked to the active workspace

#68989

  1. Create a new account
  2. Open the self-DM chat and create a new expense linked to it
  3. Verify that an actionable whisper from Concierge is created with the options: “Send to someone” and “Do nothing”
  4. Click on the newly created expense
  5. Verify that the new expense has the Report field
  6. Click on Report and verify that you see the screen with the Upgrade button
  7. Click on Upgrade, add workspace name and currency, and confirm
  8. Verify that you get the screen showing that the workspace was successfully created
  9. Click on the Got it button and verify that you land on a screen with the option to create a new Report
  10. Click on the Create new report option and verify that the expense is successfully added to that report

#68995

PREREQUISITES: having an active workspace

  1. Have a few unreported expenses
  2. Go to Reports and select those with the status: unreported
  3. Select all of them and then click on the dropdown with the options for the selected expenses
  4. Click on Move expenses option
  5. Verify you have the option to create a new report
  6. Click on that option and verify that a new report is created on the active workspace and the expenses are successfully moved to that report
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

Can't be QA'd yet, the feature is hidden.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
Screen.Recording.2025-09-16.at.13.26.44.mp4
iOS: mWeb Safari
Screen.Recording.2025-09-16.at.13.29.59.mp4
MacOS: Chrome / Safari Screenshot 2025-09-16 at 12 53 19
Screen.Recording.2025-09-16.at.12.52.11.mp4
MacOS: Desktop Screenshot 2025-09-16 at 13 06 49
Screen.Recording.2025-09-16.at.13.06.26.mp4

@koko57 koko57 changed the title [NoQA] Bulk move expenses [NoQA] Report upgrade path + Bulk move expenses Sep 17, 2025
@koko57
Copy link
Contributor Author

koko57 commented Sep 17, 2025

I closed #70370 because this PR already contains the changes that were made there, so it doesn't make sense to have it separately.

@koko57 koko57 mentioned this pull request Sep 17, 2025
50 tasks
@koko57 koko57 marked this pull request as ready for review September 17, 2025 16:06
@koko57 koko57 requested a review from a team as a code owner September 17, 2025 16:06
@melvin-bot melvin-bot bot requested review from parasharrajat and removed request for a team September 17, 2025 16:06
@melvin-bot
Copy link

melvin-bot bot commented Sep 17, 2025

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@koko57
Copy link
Contributor Author

koko57 commented Sep 19, 2025

@koko57 What about this one #70663 (comment)?

ok, checking this one. The changes blocking Move expense button should be there, maybe something was lost after merging with main

@koko57
Copy link
Contributor Author

koko57 commented Sep 19, 2025

@parasharrajat fixed! I either didn't push the changes or they were lost when resolving conflicts. Now you should not see the button when you don't have any workspace

@parasharrajat
Copy link
Member

parasharrajat commented Sep 19, 2025

Screenshots

🔲 iOS / native

🔲 iOS / Safari

19.09.2025_22.22.38_REC.mp4

🔲 MacOS / Desktop

19.09.2025_22.18.32_REC.mp4
19.09.2025_22.19.15_REC.mp4

🔲 MacOS / Chrome

19.09.2025_21.37.15_REC.mp4

🔲 Android / Chrome

19.09.2025_21.43.53_REC.mp4

🔲 Android / native

19.09.2025_21.39.27_REC.mp4

Copy link
Member

@parasharrajat parasharrajat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

@melvin-bot melvin-bot bot requested a review from cristipaval September 19, 2025 16:57
@cristipaval cristipaval merged commit 903cbf6 into Expensify:main Sep 19, 2025
26 of 27 checks passed
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/cristipaval in version: 9.2.17-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

francoisl added a commit that referenced this pull request Sep 23, 2025
…bulk-move-expenses"

This reverts commit 903cbf6, reversing
changes made to 481b134.
Julesssss added a commit that referenced this pull request Sep 23, 2025
Revert #70663 "Report upgrade path + Bulk move expenses"
OSBotify pushed a commit that referenced this pull request Sep 23, 2025
Revert #70663 "Report upgrade path + Bulk move expenses"

(cherry picked from commit 898ed4a)

(cherry-picked to staging by francoisl)
@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 9.2.17-6 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/cristipaval in version: 9.2.18-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.2.18-7 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants