[NO QA] cleaning tests error logs #70666

elirangoshen · 2025-09-16T15:12:59Z

Explanation of Change

Fixed Issues

$ #70824
Proposal
Initial effort to reduce test console errors and improve development workflow, with a batching approach for future cleanup.

Background
Our test suite currently produces 8,559 console errors across 186 test files, mostly React act() warnings. While all tests pass, the cluttered output makes it hard to identify legitimate issues during development.

Problem
When developers run tests to validate their changes, the overwhelming volume of console errors (8,559 errors) obscures real issues, which prevents us from quickly identifying legitimate bugs and reduces developer confidence in our testing feedback.

Solution
Wrap Onyx operations in act() calls.
Fix navigation initialization warnings.
Improve async handling in tests.
These changes reduce errors from 8,559 → ~3,167 (63% reduction). We intentionally stop here to avoid excessive mocking that could weaken test reliability.

Next Steps
We propose a batch-audit approach where related test files are grouped and fixed together. This keeps PRs small enough to review, but avoids overwhelming maintainers with too many submissions.
We can provide a list of affected files, and contributors can pick up batches to continue the cleanup. This way, the community can collaborate on reducing noise without creating unnecessary review overhead.

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-09-22T08:18:10Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shubham1206agra · 2025-09-22T09:28:27Z

@elirangoshen Can you please update README of tests for future reference?

shubham1206agra · 2025-09-29T11:21:53Z

@elirangoshen Bump here

elirangoshen · 2025-10-01T14:50:01Z

Hi, I working on other task which have higher priority.

Im also on leave until next week so I will keep you posted early about it.
@shubham1206agra

shubham1206agra · 2025-10-01T15:28:33Z

Hi, I working on other task which have higher priority.

Im also on leave until next week so I will keep you posted early about it. @shubham1206agra

I am also on leave for the remaining week from tomorrow. So no worries.

codecov · 2025-10-08T15:07:56Z

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
.../pages/settings/Wallet/ExpensifyCardPage/index.tsx	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #70666      +/-   ##
==========================================
- Coverage   35.17%   35.10%   -0.07%     
==========================================
  Files        3297     3307      +10     
  Lines      108097   108351     +254     
  Branches    34535    34619      +84     
==========================================
+ Hits        38020    38035      +15     
- Misses      69889    70132     +243     
+ Partials      188      184       -4

Files with missing lines	Coverage Δ
.../pages/settings/Wallet/ExpensifyCardPage/index.tsx	`56.80% <50.00%> (ø)`

... and 119 files with indirect coverage changes

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

elirangoshen · 2025-10-08T15:09:24Z

@elirangoshen Can you please update README of tests for future reference?

done :)

shubham1206agra · 2025-10-08T15:26:52Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
xIf a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

melvin-bot · 2025-10-08T15:29:23Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #70824 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

shubham1206agra · 2025-10-08T15:29:42Z

@elirangoshen Can you fix the failing checks?

elirangoshen · 2025-10-09T08:17:15Z

@elirangoshen Can you fix the failing checks?

Done

danieldoglas · 2025-10-09T15:11:51Z

src/pages/settings/Wallet/ExpensifyCardPage/index.tsx

                                        />
                                    )}
-                                </>
+                                </React.Fragment>


I'm confused about these changes since they're not related to tests. Why did we do them?

Kind of agree but it seems fine so NAB

danieldoglas

Changes LGTM, just one pending question. @roryabraham do you wanna check this one out too?

OSBotify · 2025-10-09T18:48:42Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-10-10T11:11:55Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.2.29-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-13T20:58:53Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.29-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot bot assigned elirangoshen Sep 16, 2025

elirangoshen force-pushed the eliran/fix-tests-errors branch from b591945 to 87b8258 Compare September 19, 2025 11:56

elirangoshen changed the title ~~Eliran/fix tests errors~~ [NO QA] cleaning tests error logs Sep 22, 2025

elirangoshen marked this pull request as ready for review September 22, 2025 08:18

elirangoshen requested a review from a team as a code owner September 22, 2025 08:18

melvin-bot bot requested review from shubham1206agra and removed request for a team September 22, 2025 08:18

shubham1206agra mentioned this pull request Sep 22, 2025

Remove Onyx.connect() for the key: ONYXKEYS.NVP_INTRO_SELECTED in src/libs/SubscriptionUtils.ts #70871

Merged

54 tasks

elirangoshen added 7 commits October 8, 2025 16:36

start fixing tests

312f297

fix errors

743ef3d

revert reportutilstest

eec275b

prettier fixes

be35140

lint errors

e5edf63

eslint fix

f569eeb

error fixes

39bd7e9

elirangoshen force-pushed the eliran/fix-tests-errors branch from 4166ce8 to 39bd7e9 Compare October 8, 2025 14:56

improve readme

202974b

shubham1206agra approved these changes Oct 8, 2025

View reviewed changes

melvin-bot bot requested a review from danieldoglas October 8, 2025 15:29

lint fix

14d9ef8

elirangoshen requested a review from shubham1206agra October 9, 2025 13:51

shubham1206agra approved these changes Oct 9, 2025

View reviewed changes

danieldoglas reviewed Oct 9, 2025

View reviewed changes

roryabraham approved these changes Oct 9, 2025

View reviewed changes

roryabraham merged commit 785a0ac into Expensify:main Oct 9, 2025
27 of 81 checks passed

OSBotify mentioned this pull request Oct 10, 2025

Deploy Checklist: New Expensify 2025-10-10 #72300

Closed

81 tasks

situchan mentioned this pull request Oct 29, 2025

[Due for payment 2025-10-28] Investigate account performance with many expenses to submit and approve #72025

Closed

[NO QA] cleaning tests error logs #70666

[NO QA] cleaning tests error logs #70666

Uh oh!

Conversation

elirangoshen commented Sep 16, 2025 • edited by danieldoglas Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Sep 22, 2025

Uh oh!

shubham1206agra commented Sep 22, 2025

Uh oh!

shubham1206agra commented Sep 29, 2025

Uh oh!

elirangoshen commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shubham1206agra commented Oct 1, 2025

Uh oh!

codecov bot commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

elirangoshen commented Oct 8, 2025

Uh oh!

shubham1206agra commented Oct 8, 2025

Reviewer Checklist

Uh oh!

melvin-bot bot commented Oct 8, 2025

Uh oh!

shubham1206agra commented Oct 8, 2025

Uh oh!

elirangoshen commented Oct 9, 2025

Uh oh!

danieldoglas Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

roryabraham Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

danieldoglas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Oct 9, 2025

Uh oh!

OSBotify commented Oct 10, 2025

Uh oh!

OSBotify commented Oct 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

elirangoshen commented Sep 16, 2025 •

edited by danieldoglas

Loading

elirangoshen commented Oct 1, 2025 •

edited

Loading

codecov bot commented Oct 8, 2025 •

edited

Loading