Missing company card error handling for not success bank connection #70668

narefyev91 · 2025-09-16T15:16:43Z

Explanation of Change

We bring the user back to NewDot/close the connection popup window and show an error page explaining that there was an issue connecting cards and to try again. We should make sure it works this way for all card feed connection types.

Fixed Issues

$ #70144
PROPOSAL:

For C+ test - it's not possible to emulate locally failed connection. You could ask @nkuoch to help with that - or add mock logic like this

const newFeed = feed_123;
const workspaceAccountID = 18441278

useEffect(() => {

    setTimeout(
        () =>
            Onyx.merge('sharedNVP_private_domain_member_${workspaceAccountID}', {
                settings: {
                    oAuthAccountDetails: {
                        [newFeed]: {
                            errors: 'error',
                        },
                    },
                },
            }),
        4000,
    );
}, [newFeed]);

Tests

Go to company cards
Start to setup new feed
On Bank account waiting page - wait for failed connection
Verify that user sees new failed screen with 3 options - Plaid, expensify card and Got it button
Verify that Got it closed flow and redirect back to company cards page
Verify that use expensify card option opens expensify card page
Verify that use plaid - run plaids flow

Verify that no errors appear in the JS console

Offline tests

No changes

QA Steps

Go to company cards
Start to setup new feed
On Bank account waiting page - wait for failed connection
Verify that user sees new failed screen with 3 options - Plaid, expensify card and Got it button
Verify that Got it closed flow and redirect back to company cards page
Verify that use expensify card option opens expensify card page
Verify that use plaid - run plaids flow

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

android-web.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

narefyev91 · 2025-09-16T15:25:23Z

@Expensify/design could i get a review for this page:

shawnborton · 2025-09-16T15:31:42Z

Seems a bit off. Illustration should be 20px away from the text:

It should be 254x165:

8px of margin between headline and text:

narefyev91 · 2025-09-17T13:40:08Z

@shawnborton updated:

shawnborton · 2025-09-17T13:48:20Z

That feels better, thoughts @Expensify/design ?

dubielzyk-expensify · 2025-09-18T23:11:00Z

LGTM 👍

narefyev91 · 2025-09-19T07:14:47Z

Waiting on @nkuoch to make some changes on BE side to test end-2-end

nkuoch · 2025-09-23T14:15:25Z

Backend PR in review.

narefyev91 · 2025-09-24T14:32:57Z

Backend PR in review.

@nkuoch could you please specify how the error will be set inside Onyx - will be cool to get an example. thansk!

# Conflicts: # src/pages/workspace/companyCards/BankConnection/index.tsx

nkuoch · 2025-09-25T14:09:55Z

https://github.com/Expensify/Web-Expensify/pull/48782 will change the error key from errorFields to errors.

codecov · 2025-09-29T08:43:48Z

Codecov Report

❌ Patch coverage is 0% with 38 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...nyCards/WorkspaceCompanyCardsErrorConfirmation.tsx	0.00%	23 Missing ⚠️
...es/workspace/companyCards/BankConnection/index.tsx	0.00%	8 Missing ⚠️
...space/companyCards/BankConnection/index.native.tsx	0.00%	7 Missing ⚠️

📢 Thoughts on this report? Let us know!

melvin-bot · 2025-09-29T10:11:27Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2025-09-30T12:02:36Z

src/pages/workspace/companyCards/BankConnection/index.tsx

        if (!url) {
            return;
        }
+        // eslint-disable-next-line react-compiler/react-compiler


Do we need these changes?

Yeah it was old code - but some eslint rules start to fire error: - in case we do not plan to change the whole flow - i think we are fine to leave it here.

83:9 error Unexpected reassignment of a variable which was defined outside of the component. Components and hooks should be pure and side-effect free, but variable reassignment is a form of side-effect. If this variable is used in rendering, use useState instead. (https://react.dev/reference/rules/components-and-hooks-must-be-pure#side-effects-must-run-outside-of-render) react-compiler/react-compiler

Oh
Okay then
Thanks for the explanation!

ZhenjaHorbach · 2025-09-30T12:04:46Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

2025-10-03.11.32.28.mov

Android: mWeb Chrome

2025-10-03.11.32.28.mov

iOS: HybridApp

2025-10-03.11.03.33.mov

iOS: mWeb Safari

2025-10-02.14.39.20.mov

MacOS: Chrome / Safari

2025-10-02.14.23.21.mov

MacOS: Desktop

2025-10-02.14.23.21.mov

ZhenjaHorbach · 2025-10-03T09:13:55Z

I don't think it's related to this PR
But when we select a bank => show the error screen => try to connect via Plaid => close Plaid flow
We reset the bank that was selected before

2025-10-03.11.05.46.mov

ZhenjaHorbach · 2025-10-03T09:34:04Z

But overall, the changes look good!

narefyev91 · 2025-10-03T11:40:45Z

But overall, the changes look good!

I think that's correct - when you choose plaid - we set bank to Others option - and when you cancel flow - you landed on correct screen with other selected - which mean that after error - you already started a new flow (Plaid)

ZhenjaHorbach · 2025-10-03T12:10:46Z

I think that's correct - when you choose plaid - we set bank to Others option - and when you cancel flow - you landed on correct screen with other selected - which mean that after error - you already started a new flow (Plaid)

Oh
Yeah
Fair enough!

ZhenjaHorbach · 2025-10-03T12:11:17Z

LGTM!

robertjchen · 2025-10-06T19:48:28Z

Looks great, merging! Design reviewed here: #70668 (comment)

OSBotify · 2025-10-06T20:00:07Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-10-08T05:10:15Z

🚀 Deployed to staging by https://github.com/robertjchen in version: 9.2.27-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

vincdargento · 2025-10-08T17:42:34Z

@narefyev91 @nkuoch Is there a way for testers to emulate the failed connection on step 3?
Already tried by enabling Simulate poor internet connection and Simulate failing network requests in troubleshoot menu, but it's not working

IuliiaHerets · 2025-10-08T18:28:01Z

@narefyev91 @robertjchen Can you please test it internally? QA team is not able to get the new modal.
Tried with both options:
-Simulate a poor internet connection
-Simulate failing network requests
And turning WiFi connection off as well

explorer_26hLTi1jI8.mp4

OSBotify · 2025-10-08T21:34:46Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.2.27-6 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

New company card error handling

e9ac83d

melvin-bot bot assigned narefyev91 Sep 16, 2025

Merge branch 'refs/heads/main' into add-company-card-error-handling

663c4e7

narefyev91 added 4 commits September 17, 2025 17:16

design clean up, remove feed on dismiss error

4addf96

eslint

109c4d5

Merge branch 'refs/heads/main' into add-company-card-error-handling

0cb9e06

eslint

a0d994a

Merge branch 'refs/heads/main' into add-company-card-error-handling

6bcc1e2

# Conflicts: # src/pages/workspace/companyCards/BankConnection/index.tsx

narefyev91 added 2 commits September 25, 2025 17:45

change field to check for errors

02376ef

Merge branch 'main' into add-company-card-error-handling

e18fc50

changes after video records

c0b6ea8

narefyev91 marked this pull request as ready for review September 29, 2025 10:11

narefyev91 requested review from a team as code owners September 29, 2025 10:11

melvin-bot bot requested review from ZhenjaHorbach and removed request for a team September 29, 2025 10:11

ZhenjaHorbach reviewed Sep 30, 2025

View reviewed changes

ZhenjaHorbach approved these changes Oct 3, 2025

View reviewed changes

melvin-bot bot requested a review from robertjchen October 3, 2025 12:11

joekaufmanexpensify mentioned this pull request Oct 6, 2025

[Due for payment 2025-10-15] [$250] Redirecting to Expensify Classic if attempt to connect Wells Fargo card feed fails #70144

Closed

16 tasks

robertjchen approved these changes Oct 6, 2025

View reviewed changes

robertjchen closed this Oct 6, 2025

robertjchen reopened this Oct 6, 2025

robertjchen merged commit f3c0973 into Expensify:main Oct 6, 2025
26 of 33 checks passed

OSBotify mentioned this pull request Oct 8, 2025

Deploy Checklist: New Expensify 2025-10-08 #72057

Closed

62 tasks

Missing company card error handling for not success bank connection #70668

Missing company card error handling for not success bank connection #70668

Uh oh!

Conversation

narefyev91 commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

narefyev91 commented Sep 16, 2025

Uh oh!

shawnborton commented Sep 16, 2025

Uh oh!

narefyev91 commented Sep 17, 2025

Uh oh!

shawnborton commented Sep 17, 2025

Uh oh!

dubielzyk-expensify commented Sep 18, 2025

Uh oh!

narefyev91 commented Sep 19, 2025

Uh oh!

nkuoch commented Sep 23, 2025

Uh oh!

narefyev91 commented Sep 24, 2025

Uh oh!

nkuoch commented Sep 25, 2025

Uh oh!

codecov bot commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Sep 29, 2025

Uh oh!

ZhenjaHorbach Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

narefyev91 Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Oct 3, 2025

Uh oh!

ZhenjaHorbach commented Oct 3, 2025

Uh oh!

narefyev91 commented Oct 3, 2025

Uh oh!

ZhenjaHorbach commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Oct 3, 2025

Uh oh!

robertjchen commented Oct 6, 2025

Uh oh!

Uh oh!

OSBotify commented Oct 6, 2025

Uh oh!

OSBotify commented Oct 8, 2025

Uh oh!

vincdargento commented Oct 8, 2025

Uh oh!

IuliiaHerets commented Oct 8, 2025

Uh oh!

OSBotify commented Oct 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

narefyev91 commented Sep 16, 2025 •

edited

Loading

codecov bot commented Sep 29, 2025 •

edited

Loading

ZhenjaHorbach commented Sep 30, 2025 •

edited

Loading

ZhenjaHorbach commented Oct 3, 2025 •

edited

Loading