Expensify card page uses navigation for magic code #70736

jmusial · 2025-09-17T09:48:45Z

Explanation of Change

This PR rewrites Expensify card details preview verification to use navigation instead of modals.

Fixed Issues

$ #69171

PROPOSAL:
n/a

Tests

Assumption: The account has a workspace with at least one Expensify virtual card created

Go to Settings -> Wallet
Press on one of the assigned cards
Press on Reveal details
Type in the code
See the card details
Refresh hides the details
Urls do not have backTo & forwardTo at any point of the flow

Offline tests

n/a

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

0046.android.native.mov

Android: mWeb Chrome

0046.android.chrome.mov

iOS: Native

0046.ios.native.mp4

iOS: mWeb Safari

0046.ios.safari.mp4

MacOS: Chrome / Safari

0046.desktop.chrome.mov

MacOS: Desktop

0046.desktop.native.mov

melvin-bot · 2025-09-17T13:03:19Z

@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2025-09-17T22:38:15Z

Assumption: The account has a workspace with at least one Expensify virtual card created

hey @jmusial do you know how can i add a EXFY card in test account? if i try to enable wallet with fake plaid credentials it still asks me identity verfiication

Screen.Recording.2025-09-18.at.4.05.32.AM.mov

jmusial · 2025-09-18T07:11:32Z

@ishpaul777 are you using a staging server for backend ?

ishpaul777 · 2025-09-18T08:27:07Z

yes i am using staging server @jmusial 🤔

jmusial · 2025-09-18T08:39:46Z

yes i am using staging server @jmusial 🤔

And I see your data seems ok for the test flow. Not sure I can help here, sorry :(

For me when it was asking me for verification it was either I put one of the Alberta's data wrong or not using staging server from the very beginning of the flow

ishpaul777 · 2025-09-18T08:45:56Z

i am adding data from these steps https://expensify.slack.com/archives/C01GTK53T8Q/p1711049892429129?thread_ts=1711049879.962529&cid=C01GTK53T8Q, can you check if its correct?

jmusial · 2025-09-18T14:59:49Z

i am adding data from these steps https://expensify.slack.com/archives/C01GTK53T8Q/p1711049892429129?thread_ts=1711049879.962529&cid=C01GTK53T8Q, can you check if its correct?

I'm using same ones :(

ishpaul777 · 2025-09-18T20:36:28Z

src/pages/settings/Wallet/ExpensifyCardPage/ExpensifyCardContextProvider.tsx

+import React, {createContext, useMemo, useState} from 'react';
+import type {ExpensifyCardDetails} from '@src/types/onyx/Card';
+
+type ExpensifyCardContextProviderPropsProps = {


Suggested change

type ExpensifyCardContextProviderPropsProps = {

type ExpensifyCardContextValue = {

ishpaul777 · 2025-09-18T20:42:10Z

src/App.tsx

                                        FullScreenLoaderContextProvider,
                                        ModalProvider,
                                        SidePanelContextProvider,
+                                        ExpensifyCardContextProvider,


Previously, the card details were stored in the component state, so when the RHP was closed the user had to re-enter the magic code. Now, the details are stored in the app context, meaning they persist until a hard refresh. Are we okay with this change in behavior?

Would love your input here, @mountiny.

Screen.Recording.2025-09-19.at.2.07.29.AM.mov

gentle bump @mountiny

When the RHP is closed and reopened, is new code always sent?

If yes we should reset it

if no, if you start a different flow that will need the magic code, that reset the form, right?

Common

Go to Settings -> Wallet

Press on one of the assigned cards

Press on Reveal details

Type in the code

See the card A details

Close the Card details RHP

Click on the card A details

Old behaviour:
8. You need to go through 3 - 5 to see the card details (card details stored in state)

New behaviour:
8. You can see the card details (stored in context)

Common:
9. Close the Card details RHP
10. Click on card Bdetails
11. You need to go through 3 - 5 to see the card details

I'll reset it on closing to align with old behaviour

Ooooh you mean card details like PAN and pic, ok I do think that was in state only on purpose. Why do you need to add it to the context to share it across screens? I believe we want this data to be as safe and secure as possible so the previous approach was safer imho

…-magic-code

codecov · 2025-09-26T14:54:44Z

Codecov Report

❌ Patch coverage is 32.25806% with 21 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...pensifyCardPage/ExpensifyCardVerifyAccountPage.tsx	0.00%	11 Missing ⚠️
...gation/AppNavigator/ModalStackNavigators/index.tsx	0.00%	3 Missing ⚠️
...ExpensifyCardPage/ExpensifyCardContextProvider.tsx	66.66%	3 Missing ⚠️
.../pages/settings/Wallet/ExpensifyCardPage/index.tsx	50.00%	3 Missing ⚠️
src/ROUTES.ts	0.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

jmusial · 2025-09-26T15:40:11Z

@ishpaul777 resetting the state of Card details (just web video bc I maxed out on magic codes for today :( )

Screen.Recording.2025-09-26.at.17.37.16.mov

ishpaul777 · 2025-09-29T16:07:40Z

will rereview today!

mountiny · 2025-09-29T21:23:47Z

@ishpaul777 Let me know when done!

ishpaul777 · 2025-09-30T16:34:29Z

~~sorry for delay here i'll finish this in 1 hour~~

edit: have to leave early for the day this but this is on top on list when i start tomorrow

mountiny · 2025-10-01T12:07:12Z

src/pages/settings/Wallet/ExpensifyCardPage/index.tsx

+    // This resets card details when we exit the page.
+    useBeforeRemove(() => {
+        setCardsDetails((oldCardDetails) => ({...oldCardDetails, [cardID]: null}));
+    });


I just want to confirm, are you confident that sensitive card data would not persist in the app even after the pages are exited? Basically, that was the benefit of using the state here, when the component unmounted, this data was cleared. I think we want to ensure the same level of security here

In my testing it seems to work fine for all the cases, going back using on screen <, device back button and dismissing rhp on click out side RHP, user has to reenter the code to reveal the details

ishpaul777 · 2025-10-01T12:11:29Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-10-01.at.4.34.22.AM.mov

Android: mWeb Chrome

Screen.Recording.2025-10-01.at.5.30.29.PM.mov

iOS: HybridApp

Screen.Recording.2025-10-01.at.3.15.34.AM.mov

iOS: mWeb Safari

Screen.Recording.2025-10-01.at.3.28.19.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-10-01.at.2.58.44.AM.mov

MacOS: Desktop

Screen.Recording.2025-10-01.at.5.37.22.PM.mov

ishpaul777 · 2025-10-01T12:16:53Z

@jmusial please fix conflicts

…-magic-code

mountiny · 2025-10-02T17:02:43Z

@ishpaul777 bump

ishpaul777 · 2025-10-02T17:09:25Z

oh sorry actually i was waiting till your this comment is resolved by @jmusial

ishpaul777 · 2025-10-02T17:10:43Z

I'll still retest since main is merged and approve this in few mins

mountiny · 2025-10-02T20:53:20Z

src/pages/settings/Wallet/ExpensifyCardPage/useExpensifyCardContext.tsx

+
+/**
+ * Hook to display revealed expensify card data and pass it between screens.
+


Suggested change

OSBotify · 2025-10-02T21:04:47Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-10-03T17:56:23Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.23-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

izarutskaya · 2025-10-06T09:29:38Z

Hi @jmusial Card details get hidden after going back & selecting same virtual card
Repro in prod

Bug6964207_1759527731164.03.10.2025_17.20.11_REC6.mp4

Do we need create new GH ticket for this?

jmusial · 2025-10-06T09:55:08Z

@izarutskaya not sure I understand. You pasted a video from staging ? Also I checked and staging & prod behave the same rn

izarutskaya · 2025-10-06T09:57:00Z

@jmusial Yes, it's staging
So it's not a bug, right?

jmusial · 2025-10-06T10:25:38Z

yeah, 100% expected & consistent with current behaviour
#70736 (comment)

OSBotify · 2025-10-06T19:49:12Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.2.23-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Expensify card page uses navigation for magic code

471e326

melvin-bot bot assigned jmusial Sep 17, 2025

jmusial added 3 commits September 17, 2025 11:51

prettier

f4c792b

fix typo

aeaa6cd

move cotext hook to be closer to usage, fix comment

a09a27d

jmusial marked this pull request as ready for review September 17, 2025 13:03

jmusial requested a review from a team as a code owner September 17, 2025 13:03

melvin-bot bot requested review from ishpaul777 and removed request for a team September 17, 2025 13:03

add a display name

6d4ccc3

mhawryluk mentioned this pull request Sep 18, 2025

[Tracking] [$1000] Update the ValidateCodeActionModal to be its own screen in the stack #69171

Open

This comment was marked as resolved.

Sign in to view

ishpaul777 reviewed Sep 18, 2025

View reviewed changes

jmusial added 4 commits September 19, 2025 11:43

Merge branch 'main' into feat/expensify-card-page-uses-navigation-for…

86d9bc5

…-magic-code

fix var naming & remove unused code

92a8e2c

update file name

9d2fc00

Merge branch 'main' into feat/expensify-card-page-uses-navigation-for…

7c6ba66

…-magic-code

reset card details on page exit

4672a5c

mountiny reviewed Oct 1, 2025

View reviewed changes

Merge branch 'main' into feat/expensify-card-page-uses-navigation-for…

0495109

…-magic-code

ishpaul777 approved these changes Oct 2, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny October 2, 2025 19:08

mountiny approved these changes Oct 2, 2025

View reviewed changes

mountiny merged commit 9b7fa25 into Expensify:main Oct 2, 2025
21 of 22 checks passed

OSBotify mentioned this pull request Oct 3, 2025

Deploy Checklist: New Expensify 2025-10-03 #71822

Closed

58 tasks

jmusial mentioned this pull request Oct 7, 2025

Revert "Expensify card page uses navigation for magic code" #71986

Closed

aimane-chnaif mentioned this pull request Dec 1, 2025

Migrate ExpensifyCardMissingDetailsPage to Navigation-Based Validation #76141

Merged

51 tasks

	type ExpensifyCardContextProviderPropsProps = {
	type ExpensifyCardContextValue = {


		/**
		* Hook to display revealed expensify card data and pass it between screens.

Expensify card page uses navigation for magic code #70736

Expensify card page uses navigation for magic code #70736

Uh oh!

Conversation

jmusial commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Sep 17, 2025

Uh oh!

ishpaul777 commented Sep 17, 2025

Uh oh!

jmusial commented Sep 18, 2025

Uh oh!

ishpaul777 commented Sep 18, 2025

Uh oh!

jmusial commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ishpaul777 commented Sep 18, 2025

Uh oh!

jmusial commented Sep 18, 2025

Uh oh!

This comment was marked as resolved.

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jmusial commented Sep 26, 2025

Uh oh!

ishpaul777 commented Sep 29, 2025

Uh oh!

mountiny commented Sep 29, 2025

Uh oh!

ishpaul777 commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ishpaul777 Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ishpaul777 commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ishpaul777 commented Oct 1, 2025

Uh oh!

mountiny commented Oct 2, 2025

Uh oh!

ishpaul777 commented Oct 2, 2025

Uh oh!

ishpaul777 commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Oct 2, 2025

Uh oh!

jmusial commented Sep 17, 2025 •

edited

Loading

jmusial commented Sep 18, 2025 •

edited

Loading

codecov bot commented Sep 26, 2025 •

edited

Loading

ishpaul777 commented Sep 30, 2025 •

edited

Loading

ishpaul777 Oct 1, 2025 •

edited

Loading

ishpaul777 commented Oct 1, 2025 •

edited

Loading

ishpaul777 commented Oct 2, 2025 •

edited

Loading