-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[Pre RN 0.81] Bump expo-image
#70751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pre RN 0.81] Bump expo-image
#70751
Conversation
|
|
|
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🚧 @AndrewGable has triggered a test Expensify/App build. You can view the workflow run here. |
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-09-17.at.23.20.08.movAndroid: mWeb ChromeScreen.Recording.2025-09-17.at.23.24.48.moviOS: HybridAppScreen.Recording.2025-09-17.at.23.36.55.moviOS: mWeb SafariScreen.Recording.2025-09-17.at.23.20.57.movMacOS: Chrome / SafariScreen.Recording.2025-09-17.at.23.15.31.movMacOS: DesktopScreen.Recording.2025-09-17.at.23.25.58.mov |
mountiny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a major bump, should we do more testing on this one?
|
Oh also can you check why it failed to build for android? |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
|
🚧 @roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
roryabraham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but let's retry that test build and get it working. Do we need to merge main in this PR and/or the Mobile-Expensify PR?
|
Weird, I built the Android app successfully before, but now, after cleaning all data, it fails |
|
that looks like a potential outage on |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
|
🚧 @roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
|
@war-in conflicts |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
|
@war-in Can you please merge main and try to run the hybrid app locally? |
|
Ok it looks like expo-image 3.0.8 won't work without React Native 0.81 (it worked for me last time but maybe due to some cache, sorry :( ) We'll have to include this in the main PR so sorry again! |

Explanation of Change
Our current
expo-imageversion doesn't support RN 0.81 and causes build issues. Let's bump it to the latest versionFixed Issues
$ #65991
PROPOSAL:
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13702
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop