-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Fix: Resolve MISSING TRANSLATION error in country picker for legacy data #70844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Resolve MISSING TRANSLATION error in country picker for legacy data #70844
Conversation
|
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@DylanDylann I added the I tested it to confirm that the existing behavior remains unchanged. However, to verify that it resolves the main issue, we’ll need to create a build for Shawn so he can test it on his account where the issue occurred. |
|
I just got back from OOO, sorry for the delay |
…ssing-translation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
@abzokhattab Kindly bump |
…personal address page
|
@abzokhattab Let me know when you address my suggestions above |
|
@DylanDylann done |
…ssing-translation
|
And please update the author checklist |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-10-06.at.11.56.56.movAndroid: mWeb ChromeScreen.Recording.2025-10-06.at.11.50.34.moviOS: HybridAppiOS: mWeb SafariScreen.Recording.2025-10-06.at.11.50.06.movMacOS: Chrome / SafariScreen.Recording.2025-10-06.at.11.47.29.movMacOS: DesktopScreen.Recording.2025-10-06.at.11.55.28.mov |
|
@abzokhattab failed GH actions |
|
check spell was failing ... changed the street names that was used to use already allowed names. |
dangrous
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! LGTM.
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/dangrous in version: 9.2.27-0 🚀
|
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.2.27-6 🚀
|

Explanation of Change
Fixed Issues
$ #70063
PROPOSAL: #70063 (comment)
Tests
MISSING TRANSLATIONis not shownOffline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2025-09-19.at.02.01.50.mov
MacOS: Desktop