perf: Improve performance of selecting participants #70860

TMisiukiewicz · 2025-09-19T08:25:41Z

Explanation of Change

Fixed Issues

$ #71324
PROPOSAL:

Tests

Log into account that does not have activePolicyID set as default policy
Go to FAB -> Create expense -> Manual
Enter the amount and press next
Verify that you were navigated to participant selector
Select a participant
Verify that you were navigated to confirmation screen
Create expense
Verify you were navigated to report

Verify that no errors appear in the JS console

Offline tests

n/a

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

iOS: Native

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

adhorodyski · 2025-09-19T08:46:07Z

src/pages/iou/request/step/IOURequestStepParticipants.tsx

-                />
-            )}
+            <MoneyRequestParticipantsSelector
+                participants={isSplitRequest ? participants : []}


let's default to a stable reference empty array instead

adhorodyski · 2025-09-19T08:46:19Z

src/pages/iou/request/step/IOURequestStepParticipants.tsx

+                onFinish={goToNextStep}
+                iouType={iouType}
+                action={action}
+                isPerDiemRequest={isPerDiemRequest(initialTransaction)}


this can be stabilized as well

codecov · 2025-09-26T06:33:18Z

Codecov Report

❌ Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...es/iou/request/step/IOURequestStepParticipants.tsx	0.00%	13 Missing ⚠️
...s/iou/request/MoneyRequestParticipantsSelector.tsx	0.00%	4 Missing ⚠️

📢 Thoughts on this report? Let us know!

melvin-bot · 2025-09-26T07:01:00Z

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

truph01 · 2025-09-28T08:20:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-10-06.at.15.20.35.mov

Android: mWeb Chrome

Screen.Recording.2025-10-01.at.23.09.07.mov

iOS: HybridApp

Screen.Recording.2025-10-01.at.23.06.02.mov

iOS: mWeb Safari

Screen.Recording.2025-10-01.at.23.07.31.mov

MacOS: Chrome / Safari

Screen.Recording.2025-10-01.at.22.34.11.mov

MacOS: Desktop

Screen.Recording.2025-10-01.at.23.04.55.mov

truph01 · 2025-09-28T11:26:05Z

I noticed that we introduced conditional rendering here:

App/src/pages/iou/request/step/IOURequestStepParticipants.tsx

Line 348 in 3a10c20

{transactions.length > 0 && (

via this commit, to address the issue: "can't create expense on native platform".

RCA of the issue: "Can't create expense on native platform"

We use memo here:

App/src/pages/iou/request/MoneyRequestParticipantsSelector.tsx

Line 635 in 3a10c20

    
           export default memo(MoneyRequestParticipantsSelector, (prevProps, nextProps) => deepEqual(prevProps.participants, nextProps.participants) && prevProps.iouType === nextProps.iouType);

Because MoneyRequestParticipantsSelector is memoized, it doesn’t re-render when the addParticipant or goToNextStep functions are updated.
Initially, these functions are created when transactions is still an empty array ([])—since initialTransaction is not yet available due to pending Onyx data.
Once initialTransaction is loaded, the addParticipant and goToNextStep functions in IOURequestStepParticipants are updated with the correct data. However, since MoneyRequestParticipantsSelector is memoized and doesn't re-render, it continues using the outdated versions of those functions.
To address this, the original author added conditional rendering to re-render when transactions.length > 0 is changed, ensuring that the latest addParticipant and goToNextStep functions are passed down.

Problem with the current code change in this PR

The current PR reintroduces the issue "Can't create expense on native platform." You can follow the test steps provided here to reproduce it.

My suggested solution to address both "Can't create expense on native platform." issue and "Remove conditional rendering of MoneyRequestParticipantsSelector" issues

First, we need to remove:

App/src/pages/iou/request/step/IOURequestStepParticipants.tsx

Line 348 in 3a10c20

{transactions.length > 0 && (

Then, we can address the root cause more directly by ensuring MoneyRequestParticipantsSelector re-renders when the relevant dependencies update:

Option 1: Add addParticipant and goToNextStep to the dependency list here:

App/src/pages/iou/request/MoneyRequestParticipantsSelector.tsx

Line 635 in 3a10c20

    
           export default memo(MoneyRequestParticipantsSelector, (prevProps, nextProps) => deepEqual(prevProps.participants, nextProps.participants) && prevProps.iouType === nextProps.iouType);

This ensures the selector uses the latest versions of these functions.

Option 2: Add isLoadingTransaction to the dependency list at the same location, so the selector re-renders when loading state changes.

OlimpiaZurek · 2025-09-29T14:33:08Z

@truph01 I tried to check if this change could cause the regression you mentioned, but I couldn’t reproduce the exact steps based on the issue description — I don’t see “Share with my accountant” after creating an expense:

Do you know if there’s another flow I should follow to check this potential issue?

truph01 · 2025-09-30T01:59:08Z

@OlimpiaZurek You should early return in our canUseAllBetas function

This reverts commit 4a14ed7.

OlimpiaZurek · 2025-09-30T12:41:47Z

Thanks @truph01
I fixed this potential regression by adding onParticipantsAdded and onFinish to the memo comparison. Now the component re-renders when these functions change.

truph01 · 2025-09-30T12:47:24Z

I fixed this potential regression by adding onParticipantsAdded and onFinish to the memo comparison. Now the component re-renders when these functions change.

@OlimpiaZurek I think we can remove all the changes we made in IOURequestStepParticipants.tsx, except the removal:

App/src/pages/iou/request/step/IOURequestStepParticipants.tsx

Line 348 in 3a10c20

{transactions.length > 0 && (

OlimpiaZurek · 2025-09-30T13:33:04Z

@truph01 Let me check the measurements and performance impact again, since improving that was the initial goal of this PR. I’ll do some profiling to see the results and confirm whether the fallback changes are still needed here.

OlimpiaZurek · 2025-10-01T11:14:56Z

Measured results:

~9% overall improvement vs. only memo deps (not huge, previous result was 1.2 ms).
addParticipant execution time dropped from ~18 ms → ~4 ms (tested with large state ~24k options).

Given these results, the fallback provides extra performance benefits, so it makes sense to keep it.

truph01 · 2025-10-01T11:19:52Z

Thanks @OlimpiaZurek!

Could you address the:

PR Author Checklist / checklist (pull_request_target)
PR Author Checklist / checklist (pull_request_target)Failing after 8s

and

React Compiler Compliance Check / React Compiler Compliance (pull_request)
React Compiler Compliance Check / React Compiler Compliance (pull_request)Failing after 1m

Meanwhile, I'll complete the checklist

truph01 · 2025-10-01T11:20:40Z

@OlimpiaZurek Also, could you help merge main here?

OlimpiaZurek · 2025-10-01T14:32:03Z

@truph01 I’ve fixed all React Compiler errors. Regarding the PR author checklist, I see that all checkboxes are marked, and I’m not able to edit the PR description since I’m not the author of this PR .

truph01 · 2025-10-01T16:13:52Z

src/pages/iou/request/MoneyRequestParticipantsSelector.tsx

    const [textInputAutoFocus, setTextInputAutoFocus] = useState<boolean>(!isNative);
    const selectionListRef = useRef<SelectionListHandle | null>(null);
-    const cleanSearchTerm = useMemo(() => debouncedSearchTerm.trim().toLowerCase(), [debouncedSearchTerm]);
+    const cleanSearchTerm = debouncedSearchTerm.trim().toLowerCase();


@OlimpiaZurek Why do we need to remove useMemo here? Doesn't using useMemo help us avoid recalculating on every re-render?

Same question regarding the other useMemo removal—doesn't it help prevent unnecessary recalculations on each re-render?

@truph01 I removed the useMemocalls because React Compiler was failing with: “React Compiler has skipped optimizing this component because the existing manual memoization could not be preserved.” I wasn’t fully convinced we needed to remove all of them , but I did it to get the compiler workflow to pass.

Since that workflow is currently disabled due to instability, I’ve reverted those removals for now.

This reverts commit f4b1fd4.

mountiny

I will move this ahead, the checklist would be filled fully when updated

OSBotify · 2025-10-06T21:38:44Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-10-08T05:10:21Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.27-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

IuliiaHerets · 2025-10-08T05:20:04Z

Hi @TMisiukiewicz @mountiny . Which account should we use that does not have activePolicyID?

mountiny · 2025-10-08T19:08:32Z

@IuliiaHerets I think it would need to be user without any group policy no? I think it is safe to check this one off from the checklist as normal regression testing should catch any issues

OSBotify · 2025-10-08T21:34:52Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.2.27-6 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot bot assigned TMisiukiewicz Sep 19, 2025

adhorodyski reviewed Sep 19, 2025

View reviewed changes

TMisiukiewicz marked this pull request as ready for review September 26, 2025 07:00

TMisiukiewicz requested a review from a team as a code owner September 26, 2025 07:00

melvin-bot bot requested review from truph01 and removed request for a team September 26, 2025 07:00

TMisiukiewicz and others added 6 commits September 30, 2025 11:19

remove conditional rendering of participants selector

64f26aa

remove navigation side effect

9d98a43

set initial transaction when creating expense

1b3c470

Revert "remove navigation side effect"

e262e8f

This reverts commit 4a14ed7.

stabilize props

121c624

fix conflicts

56680b1

OlimpiaZurek force-pushed the perf/improve-selecting-participants branch from 25764c5 to 3e4193a Compare September 30, 2025 10:12

OlimpiaZurek added 2 commits September 30, 2025 12:38

revert submodule change

2c2c991

fix memo comparison

de5acbd

fix prettier

472e954

OlimpiaZurek added 2 commits October 1, 2025 13:00

fix conflicts

c5f41d6

revert submodule change

56b6a45

OlimpiaZurek added 2 commits October 1, 2025 14:54

fix conflicts

203aa93

fix react compiler errors

f4b1fd4

truph01 reviewed Oct 1, 2025

View reviewed changes

Revert "fix react compiler errors"

3faf962

This reverts commit f4b1fd4.

truph01 approved these changes Oct 2, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny October 2, 2025 08:50

mountiny approved these changes Oct 6, 2025

View reviewed changes

mountiny merged commit 6e56455 into Expensify:main Oct 6, 2025
21 of 22 checks passed

adhorodyski deleted the perf/improve-selecting-participants branch October 7, 2025 07:45

OSBotify mentioned this pull request Oct 8, 2025

Deploy Checklist: New Expensify 2025-10-08 #72057

Closed

62 tasks

melvin-bot bot mentioned this pull request Oct 8, 2025

[Due for payment 2025-10-15] [$250] Remove conditional rendering of MoneyRequestParticipantsSelector #71324

Closed

perf: Improve performance of selecting participants #70860

perf: Improve performance of selecting participants #70860

Uh oh!

Conversation

TMisiukiewicz commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

adhorodyski Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

adhorodyski Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Sep 26, 2025

Uh oh!

truph01 commented Sep 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

truph01 commented Sep 28, 2025

RCA of the issue: "Can't create expense on native platform"

Problem with the current code change in this PR

My suggested solution to address both "Can't create expense on native platform." issue and "Remove conditional rendering of MoneyRequestParticipantsSelector" issues

Uh oh!

OlimpiaZurek commented Sep 29, 2025

Uh oh!

truph01 commented Sep 30, 2025

Uh oh!

OlimpiaZurek commented Sep 30, 2025

Uh oh!

truph01 commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OlimpiaZurek commented Sep 30, 2025

Uh oh!

OlimpiaZurek commented Oct 1, 2025

Uh oh!

truph01 commented Oct 1, 2025

Uh oh!

truph01 commented Oct 1, 2025

Uh oh!

OlimpiaZurek commented Oct 1, 2025

Uh oh!

truph01 Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

truph01 Oct 1, 2025

Choose a reason for hiding this comment

Uh oh!

OlimpiaZurek Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Oct 6, 2025

Uh oh!

OSBotify commented Oct 8, 2025

Uh oh!

IuliiaHerets commented Oct 8, 2025

Uh oh!

mountiny commented Oct 8, 2025

Uh oh!

OSBotify commented Oct 8, 2025

Uh oh!

Reviewers

TMisiukiewicz commented Sep 19, 2025 •

edited

Loading

codecov bot commented Sep 26, 2025 •

edited

Loading

truph01 commented Sep 28, 2025 •

edited

Loading

truph01 commented Sep 30, 2025 •

edited

Loading

truph01 Oct 1, 2025 •

edited

Loading