Embed react-native-bootsplash lite module#7096
Embed react-native-bootsplash lite module#7096NikkiWines merged 17 commits intoExpensify:mainfrom zoontek:embed-bootsplash-lite
Conversation
|
Hi @zoontek, feel free to merge |
|
@roryabraham Done ✅ |
|
Sorry for the delay @zoontek - I've been traveling this week and will try to get to this early next week! |
|
Took a quick look at @NikkiWines request. Seeing as we are updating |
android/app/src/main/java/com/expensify/chat/bootsplash/BootSplashActivity.java
Outdated
Show resolved
Hide resolved
android/app/src/main/java/com/expensify/chat/bootsplash/BootSplashActivity.java
Outdated
Show resolved
Hide resolved
android/app/src/main/java/com/expensify/chat/bootsplash/BootSplashActivity.java
Outdated
Show resolved
Hide resolved
android/app/src/main/java/com/expensify/chat/bootsplash/BootSplashModule.java
Show resolved
Hide resolved
|
@Julesssss Done ✅ |
NikkiWines
left a comment
There was a problem hiding this comment.
minor style suggestions but overall looks good.
cc: @marcaaron or @roryabraham not sure if either of you wanted to give this one more once over before we ![]()
android/app/src/main/java/com/expensify/chat/bootsplash/BootSplashModule.java
Outdated
Show resolved
Hide resolved
|
@NikkiWines I pushed the changes. |
|
@zoontek, I've been holding off on merging this because of the increase of discussion in the main issue but was wondering if you think we should just go ahead and see if this resolves the issue. I'm also happy to hold off for now and see if any of the new voices in that conversation have any suggestions. |
|
@NikkiWines As there is still no reproduction steps, I would recommend merging it and internal testing, yes 🙂 |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by @NikkiWines in version: 1.1.31-2 🚀
|
|
🚀 Deployed to production by @AndrewGable in version: 1.1.32-0 🚀
|
Details
Following #5620
Has the issue still seems present, this PR embed a minimalistic version of the library, hybrid between v3 / v4.
iOS module is based on
react-native-bootsplashv4 (meaning it usesRCTRootView.loadingViewinstead of aUIViewController), Android module is based on v3 (meaning it doesn't use the new SplashScreen API).But, as opposed to the "full" module, this one is tailored to be as minimal as possible (for your needs):
showmethod does not existstransitioningstatus ongetVisibilityStatusRCTContentDidAppearNotificationnative event,hideis called no matter what, as a safety measure (👉 this value could be adjusted)I also updated
react-navigation+react-native-screensto the latest versions to prevent some issues (asreact-native-screensis enabled by default since3.0.0and use native stacks, it's not safe to stay on a version that old, see the changelogs), and fixed the initial loading screens background colors.Fixed Issues
#5620 (maybe? reproduction steps are not known)
Tests
Tested On
Screenshots
iOS
Android