fix: Reject offline new report by mananjadhav · Pull Request #70960 · Expensify/App

mananjadhav · 2025-09-21T20:21:22Z

Explanation of Change

Fixed Issues

$ #70569
PROPOSAL:

Tests

Go to app
Go to workspace chat.
Submit two expenses to worksace chat.
Open expense report.
Click Submit.
Go offline.
Open one of the expenses.
Click More > Reject.
Enter reason and save it.
Go back to main workspace chat.
Verify: The rejected expense will be created in a new draft report.

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-10-23.at.00.22.27.mov

Android: mWeb Chrome

Screen.Recording.2025-10-23.at.00.18.36.mov

iOS: Native

I encountered an error when building IOS. I will add the video later once it is fixed.

iOS: mWeb Safari

Screen.Recording.2025-10-23.at.00.17.25.mov

MacOS: Chrome / Safari

Screen.Recording.2025-10-22.at.23.48.22.mov

MacOS: Desktop

Screen.Recording.2025-10-23.at.00.14.37.mov

…ct-offline-new-report

truph01 · 2025-09-22T19:25:43Z

src/libs/actions/IOU.ts

+            // Add all report actions to the new report
+            optimisticData.push({
+                onyxMethod: Onyx.METHOD.SET,
+                key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${rejectedToReportID}`,
+                value: newReportActions,
+            });


I think the newReportActions should be added to the transaction thread rather than the expense report.
With the expense report, we only add CREATED action and IOU action, which corresponds with the rejected transaction.

For reference, you check check what BE returns in online, so we can handle the optimistical data properly in offline.

…ct-offline-new-report

truph01 · 2025-09-30T02:20:20Z

src/libs/actions/IOU.ts

+                key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${rejectedToReportID}`,
+                value: newReportActions,


I saw that you pushes the: rejected this expense action, rejection reason comment, moved this expense action to the new expense report. Does it match the data returned by BE?

codecov · 2025-09-30T14:51:41Z

Codecov Report

❌ Patch coverage is 13.63636% with 19 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/libs/actions/IOU.ts	13.63%	19 Missing ⚠️

Files with missing lines	Coverage Δ
src/libs/actions/IOU.ts	`63.38% <13.63%> (+<0.01%)`	⬆️

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

truph01 · 2025-10-22T17:24:04Z

<!-- If necessary, assign reviewers that know the area or changes well. Feel free to tag any additional reviewers you see fit. -->

### Explanation of Change
<!-- Explain what your change does and how it addresses the linked issue -->

### Fixed Issues
<!---
1. Please postfix `$` with a URL link to the GitHub issue this Pull Request is fixing. For example, `$ https://github.com/Expensify/App/issues/<issueID>`.
2. Please postfix  `PROPOSAL:` with a URL link to your GitHub comment, which contains the approved proposal (i.e. the proposal that was approved by Expensify).  For example, `PROPOSAL: https://github.com/Expensify/App/issues/<issueID>#issuecomment-1369752925`

Do NOT add the special GH keywords like `fixed` etc, we have our own process of managing the flow.
It MUST be an entire link to the github issue and your comment proposal ; otherwise, the linking and its automation will not work as expected.

Make sure this section looks similar to this (you can link multiple issues using the same formatting, just add a new line):

$ https://github.com/Expensify/App/issues/<issueID>
$ https://github.com/Expensify/App/issues/<issueID(comment)>

Do NOT only link the issue number like this: $ #<issueID>
--->
$ https://github.com/Expensify/App/issues/70569
PROPOSAL: 


<!--- 
If you want to trigger adhoc build of hybrid app from specific Mobile-Expensify PR please link it like this:

MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/<PR-number>

--->

### Tests
<!---
Add a numbered list of manual tests you performed that validates your changes work on all platforms, and that there are no regressions present.
Add any additional test steps if test steps are unique to a particular platform.
Manual test steps should be written so that your reviewer can repeat and verify one or more expected outcomes in the development environment.

For example:
1. Click on the text input to bring it into focus
2. Upload an image via copy paste
3. Verify a modal appears displaying a preview of that image
--->
1. Go to app
2. Go to workspace chat.
3. Submit two expenses to worksace chat.
4. Open expense report.
5. Click Submit.
6. Go offline.
7. Open one of the expenses.
8. Click More > Reject.
9. Enter reason and save it.
10. Go back to main workspace chat.
11. Verify: The rejected expense will be created in a new draft report.
- [x] Verify that no errors appear in the JS console

### Offline tests
<!---
Add any relevant steps that validate your changes work as expected in a variety of network states e.g. "offline", "spotty connection", "slow internet", etc. Manual test steps should be written so that your reviewer and QA testers can repeat and verify one or more expected outcomes. If you are unsure how the behavior should work ask for advice in the `#expensify-open-source` Slack channel.
--->

### QA Steps
<!---
Add a numbered list of manual tests that can be performed by our QA engineers on the staging environment to validate that your changes work on all platforms, and that there are no regressions present.
Add any additional QA steps if test steps are unique to a particular platform.
Manual test steps should be written so that the QA engineer can repeat and verify one or more expected outcomes in the staging environment.

For example:
1. Click on the text input to bring it into focus
2. Upload an image via copy paste
3. Verify a modal appears displaying a preview of that image

It's acceptable to write "Same as tests" if the QA team is able to run the tests in the above "Tests" section.
--->
// TODO: These must be filled out, or the issue title must include "[No QA]."

- [x] Verify that no errors appear in the JS console

### PR Author Checklist
<!--
This is a checklist for PR authors. Please make sure to complete all tasks and check them off once you do, or else your PR will not be merged!
-->

- [x] I linked the correct issue in the `### Fixed Issues` section above
- [x] I wrote clear testing steps that cover the changes made in this PR
    - [x] I added steps for local testing in the `Tests` section
    - [x] I added steps for the expected offline behavior in the `Offline steps` section
    - [x] I added steps for Staging and/or Production testing in the `QA steps` section
    - [x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    - [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    - [x] I tested this PR with a [High Traffic account](https://github.com/Expensify/App/blob/main/contributingGuides/CONTRIBUTING.md#high-traffic-accounts) against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
- [x] I included screenshots or videos for tests on [all platforms](https://github.com/Expensify/App/blob/main/contributingGuides/CONTRIBUTING.md#make-sure-you-can-test-on-all-platforms)
- [x] I ran the tests on **all platforms** & verified they passed on:
    - [x] Android: Native
    - [x] Android: mWeb Chrome
    - [x] iOS: Native
    - [x] iOS: mWeb Safari
    - [x] MacOS: Chrome / Safari
    - [x] MacOS: Desktop
- [x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
- [x] I verified there are no new alerts related to the `canBeMissing` param for `useOnyx`
- [x] I followed proper code patterns (see [Reviewing the code](https://github.com/Expensify/App/blob/main/contributingGuides/PR_REVIEW_GUIDELINES.md#reviewing-the-code))
    - [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. `toggleReport` and not `onIconClick`)
    - [x] I verified that comments were added to code that is not self explanatory
    - [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    - [x] I verified any copy / text shown in the product is localized by adding it to `src/languages/*` files and using the [translation method](https://github.com/Expensify/App/blob/4510fc76bbf5df699a2575bfb49a276af90f3ed7/src/components/LocaleContextProvider.tsx#L80)
      - [x] If any non-english text was added/modified, I used [JaimeGPT](https://chatgpt.com/g/g-2dgOQl5VM-english-to-spanish-translator-aka-jaimegpt) to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    - [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the [localization methods](https://github.com/Expensify/App/blob/4510fc76bbf5df699a2575bfb49a276af90f3ed7/src/components/LocaleContextProvider.tsx#L116-L123)
    - [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    - [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    - [x] I verified the JSDocs style guidelines (in [`STYLE.md`](https://github.com/Expensify/App/blob/main/contributingGuides/STYLE.md#jsdocs)) were followed
- [x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- [x] I followed the guidelines as stated in the [Review Guidelines](https://github.com/Expensify/App/blob/main/contributingGuides/PR_REVIEW_GUIDELINES.md)
- [x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like `Avatar`, I verified the components using `Avatar` are working as expected)
- [x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- [x] I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
- [x] I verified that if a function's arguments changed that all usages have also been updated correctly
- [x] If any new file was added I verified that:
    - [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- [x] If a new CSS style is added I verified that:
    - [x] A similar style doesn't already exist
    - [x] The style can't be created with an existing [StyleUtils](https://github.com/Expensify/App/blob/main/src/styles/utils/index.ts) function (i.e. `StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)`)
- [x] If new assets were added or existing ones were modified, I verified that:
    - [x] The assets are optimized and compressed (for SVG files, run `npm run compress-svg`)
    - [x] The assets load correctly across all supported platforms.
- [x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- [x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like `Avatar` is modified, I verified that `Avatar` is working as expected in all cases)
- [x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- [x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- [x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    - [x] I verified that all the inputs inside a form are aligned with each other.
    - [x] I added `Design` label and/or tagged `@Expensify/design` so the design team can review the changes.
- [x] If a new page is added, I verified it's using the `ScrollView` component to make it scrollable when more elements are added to the page.
- [x] I added [unit tests](https://github.com/Expensify/App/blob/main/tests/README.md) for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
- [x] If the `main` branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the `Test` steps.

### Screenshots/Videos
<details>
<summary>Android: Native</summary>

<!-- add screenshots or videos here -->

https://github.com/user-attachments/assets/58f9ab6b-4593-4095-9e23-ecb439811951


</details>

<details>
<summary>Android: mWeb Chrome</summary>

<!-- add screenshots or videos here -->

https://github.com/user-attachments/assets/2390c52c-0bbc-4883-a26e-79a98862a717


</details>

<details>
<summary>iOS: Native</summary>

<!-- add screenshots or videos here -->
I encountered an error when building IOS. I will add the video later once it is fixed.
</details>

<details>
<summary>iOS: mWeb Safari</summary>

<!-- add screenshots or videos here -->

https://github.com/user-attachments/assets/79b312c4-ea8a-489c-a44e-ce2e4bb6e60c


</details>

<details>
<summary>MacOS: Chrome / Safari</summary>

<!-- add screenshots or videos here -->

https://github.com/user-attachments/assets/07bb7bb0-fb96-4056-a171-3f78c54e1230


</details>

<details>
<summary>MacOS: Desktop</summary>

<!-- add screenshots or videos here -->

https://github.com/user-attachments/assets/e6283d0e-2622-437d-820a-6a4c3ee1fbde


</details>

melvin-bot · 2025-10-23T17:46:53Z

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

trjExpensify · 2025-10-24T15:55:12Z

What's the deal here now. Is @truph01 reviewing?

mananjadhav · 2025-10-24T16:13:20Z

@truph01 took over the PR as implementer in my absence as I was out.

I am partially back and hence reviewing this PR. I reviewed this PR yesterday. Now going to test it.

mananjadhav · 2025-10-24T17:16:54Z

I tested a few scenarios and it works fine. Here's a happy path.

web-offline-reject-2.mov

One question if we keep rejecting the expenses offline, instead of adding it to the new offline report we are creating two new offline reports. I can see BE also returns 2 offline reports. So I think this behavior is fine?

web-offline-reject-1.mov

mananjadhav · 2025-10-24T17:42:55Z

@truph01 I was testing the actions for the new offline report. May be some of these are not related to the PR. But following actions didn't work.

Add expense: Clicking on Add expense for the new offline reported showed error page.
Hold: Selecting hold throws an error.
Change Workspace: Temporarily shows the expense in the Approver's expenses workspace. After the refresh it then moves to the correct workspace.

web-offline-reject-menu-actions.mov

One more question (even I had this when I was working on it), the offline report title format is: Expense Report {YYYY-MM-DD}, and then from BE we send the Expense Report {reportID}. Are we fine with that behavior? Because when we use existing formula, it uses Base64 of the reportID.

trjExpensify · 2025-10-27T14:31:35Z

One question if we keep rejecting the expenses offline, instead of adding it to the new offline report we are creating two new offline reports. I can see BE also returns 2 offline reports. So I think this behavior is fine?

@garrettmknight is this to do with the ASAP submit rollout perhaps? 🤔 If an open report exists with delayed submit, I thought a rejected expense was added to that.

May be some of these are not related to the PR

Can you confirm which ones are related, so we focus on them if they're blocking the PR?

One more question (even I had this when I was working on it), the offline report title format is: Expense Report {YYYY-MM-DD}, and then from BE we send the Expense Report {reportID}. Are we fine with that behavior? Because when we use existing formula, it uses Base64 of the reportID.

I think this is a different project, coming with moving custom report title formulas to Auth.

mananjadhav · 2025-10-28T18:24:10Z

I can consistently reproduce it. Steps are straight here, from the newly created offline report, click on More.

@mananjadhav Could you please point out if there's any step I missed or got wrong in the video I provided?

The steps look fine. Let me create a new workspace and then try.

truph01 · 2025-10-28T18:45:28Z

Change Workspace: Temporarily shows the expense in the Approver's expenses workspace. After the refresh it then moves to the correct workspace.

@mananjadhav I just tested, and it looks like this behavior has also appeared in prod. So I think we can skip it in this PR

truph01 · 2025-10-28T19:07:10Z

@mananjadhav

One question if we keep rejecting the expenses offline, instead of adding it to the new offline report we are creating two new offline reports. I can see BE also returns 2 offline reports. So I think this behavior is fine?

I fixed this bug via this commit.

truph01 · 2025-10-29T17:15:49Z

@mananjadhav Have you had a chance to review this one?

trjExpensify · 2025-10-29T19:48:58Z

+1, can we please keep this moving? Thanks!

P.S @truph01 conflict now!

mananjadhav · 2025-10-29T20:07:26Z

I tested the flow again for web all the scenarios. All the scenarios are fixed except for the 2 offline rejects. I think once this is fixed, we're good with the PR. Rest all the I tested and seem to be fixed.

@truph01 Now the preview shows correctly with 2 offline expenses, but when I open the report, it shows only the first rejected expense.

web-rejected-multiple-offline-expense.mov

truph01 · 2025-10-30T09:07:46Z

@truph01 Now the preview shows correctly with 2 offline expenses, but when I open the report, it shows only the first rejected expense.

@mananjadhav I just posted a commit to fix it. Result:

Screen.Recording.2025-10-30.at.16.04.02.mov

mananjadhav · 2025-10-30T09:38:36Z

I can be online in 2 hours to test this.

mananjadhav · 2025-10-30T18:45:23Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android-offline-reject.mov

Android: mWeb Chrome

mweb-chrome-offline-reject.mov

iOS: HybridApp

iOS: mWeb Safari

mweb-safari-offline-reject.mov

MacOS: Chrome / Safari

web-offline-reject.mov

MacOS: Desktop

desktop-offline-reject.mov

mananjadhav · 2025-11-02T17:36:37Z

@truph01 The recent changes has caused some issues. The new optimistic report is empty. I also DMed you over the weekend.

desktop-reject-offline.mov

mweb-safari-reject-offline.mov

web-offline-reject.mov

mananjadhav · 2025-11-03T12:29:41Z

The recent fixes worked. Testing again all platforms.

mananjadhav

I have issues with my iOS build. But I retested on all the other platforms. I think it's good to merge.

@truph01

lakchote · 2025-11-03T15:14:45Z

Great work on this one, thank you both @truph01 @mananjadhav!

OSBotify · 2025-11-03T15:28:50Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-11-03T23:01:30Z

🚀 Deployed to staging by https://github.com/lakchote in version: 9.2.43-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-11-04T20:49:03Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.43-2 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

hoangzinh · 2026-01-20T12:03:08Z

src/libs/actions/IOU.ts

-                    total: (movedToReport?.total ?? 0) - transactionAmount,
-                },
+
+            const [, , iouAction, ,] = buildOptimisticMoneyRequestEntities({


We need to set createdIOUReportActionID with reportActionID of the iouAction here as well, otherwise it will cause FE sends empty value for createdIOUReportActionID, hence BE re-generate another createdIOUReportActionID, then cause duplicate report preview. More details here #76982 (comment)

suneox · 2026-01-28T16:09:45Z

src/libs/actions/IOU.ts

+                {
+                    onyxMethod: Onyx.METHOD.SET,
+                    key: `${ONYXKEYS.COLLECTION.REPORT}${rejectedToReportID}`,
+                    value: {
+                        pendingFields: null,
+                    },
+                },


Coming from #78577 checklist: we should update pendingFields using the MERGE method instead of SET the entire object.

mananjadhav added 2 commits September 21, 2025 18:55

feat: added optimistic report

00ca266

refactor: remove type cast

6348dfc

melvin-bot bot assigned mananjadhav Sep 21, 2025

Merge branch 'main' of github.com:mananjadhav/App into fix/70569-reje…

ec44b76

…ct-offline-new-report

truph01 reviewed Sep 22, 2025

View reviewed changes

mananjadhav added 4 commits September 25, 2025 00:53

Merge branch 'main' of github.com:mananjadhav/App into fix/70569-reje…

ccd0f5f

…ct-offline-new-report

fix: offline transaction mapping

9d21088

Merge branch 'main' of github.com:mananjadhav/App into fix/70569-reje…

e87d772

…ct-offline-new-report

Merge branch 'main' of github.com:mananjadhav/App into fix/70569-reje…

385a5ba

…ct-offline-new-report

truph01 reviewed Sep 30, 2025

View reviewed changes

fix:add reportPreviewReportActionID

e7565e5

truph01 added 7 commits October 15, 2025 00:03

Merge branch 'Expensify:main' into fix/70569-reject-offline-new-report

00fe9b8

fix: update missing optimistic data

a83dc24

Merge branch 'Expensify:main' into fix/70569-reject-offline-new-report

e25430a

fix: lint

c1c4b62

Merge branch 'Expensify:main' into fix/70569-reject-offline-new-report

41dc2cd

fix: update success and failure data

6081827

fix: lint

180d7cc

mananjadhav marked this pull request as ready for review October 23, 2025 17:46

mananjadhav requested a review from a team as a code owner October 23, 2025 17:46

melvin-bot bot requested review from truph01 and removed request for a team October 23, 2025 17:46

fix: incorrect owner account ID

bf9359d

truph01 added 2 commits October 30, 2025 15:14

fix: conflicts

cdc5087

fix: add iouAction to rejected report optimistically

2c98839

fix: conflicts

6667e9d

truph01 added 2 commits November 3, 2025 16:04

Merge branch 'Expensify:main' into fix/70569-reject-offline-new-report

7705a44

fix: empty report is shown after reject

8a6bb85

mananjadhav commented Nov 3, 2025

View reviewed changes

truph01 approved these changes Nov 3, 2025

View reviewed changes

melvin-bot bot requested a review from lakchote November 3, 2025 15:10

lakchote approved these changes Nov 3, 2025

View reviewed changes

lakchote merged commit 7382906 into Expensify:main Nov 3, 2025
27 checks passed

OSBotify mentioned this pull request Nov 3, 2025

Deploy Checklist: New Expensify 2025-11-03 #74140

Closed

54 tasks

melvin-bot bot mentioned this pull request Nov 4, 2025

[Due for payment 2025-11-11] [Reject] Expense - Rejected expense is not seen in a new report when rejected offline #70569

Closed

8 tasks

hoangzinh reviewed Jan 20, 2026

View reviewed changes

suneox reviewed Jan 28, 2026

View reviewed changes

		key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${rejectedToReportID}`,
		value: newReportActions,

Conversation

mananjadhav commented Sep 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

truph01 Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

truph01 Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

truph01 commented Oct 22, 2025

Uh oh!

melvin-bot bot commented Oct 23, 2025

Uh oh!

trjExpensify commented Oct 24, 2025

Uh oh!

mananjadhav commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mananjadhav commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mananjadhav commented Oct 24, 2025

Uh oh!

trjExpensify commented Oct 27, 2025

Uh oh!

mananjadhav commented Oct 28, 2025

Uh oh!

truph01 commented Oct 28, 2025

Uh oh!

truph01 commented Oct 28, 2025

Uh oh!

truph01 commented Oct 29, 2025

Uh oh!

trjExpensify commented Oct 29, 2025

Uh oh!

mananjadhav commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

truph01 commented Oct 30, 2025

Uh oh!

mananjadhav commented Oct 30, 2025

Uh oh!

mananjadhav commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mananjadhav commented Nov 2, 2025

Uh oh!

mananjadhav commented Nov 3, 2025

Uh oh!

mananjadhav left a comment

Choose a reason for hiding this comment

Uh oh!

lakchote commented Nov 3, 2025

Uh oh!

Uh oh!

OSBotify commented Nov 3, 2025

Uh oh!

OSBotify commented Nov 3, 2025

Uh oh!

OSBotify commented Nov 4, 2025

Uh oh!

hoangzinh Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

suneox Jan 28, 2026

mananjadhav commented Sep 21, 2025 •

edited

Loading

codecov bot commented Sep 30, 2025 •

edited

Loading

mananjadhav commented Oct 24, 2025 •

edited

Loading

mananjadhav commented Oct 24, 2025 •

edited

Loading

mananjadhav commented Oct 29, 2025 •

edited

Loading

mananjadhav commented Oct 30, 2025 •

edited

Loading

hoangzinh Jan 20, 2026 •

edited

Loading