Support XCode 26 & add Liquid Glass icons for iOS and Mac Desktop builds#70984
Support XCode 26 & add Liquid Glass icons for iOS and Mac Desktop builds#70984
Conversation
|
🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
Julesssss
left a comment
There was a problem hiding this comment.
I would expect we may need updates to Mobile-Expensify too?
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
The desktop build has correct icons, still need to check the ios build. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
@Julesssss all right, after a heroic battle with Podfiles and GH actions this is finally ready to merge |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
mountiny
left a comment
There was a problem hiding this comment.
Thanks! jumping in for Jules who is ooo
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
discussed with Michal that he tested this enough and C+ review should not be needed so moving it ahead |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.29-0 🚀
|
|
@mjasikowski PR is still failing for QA team, we used original issue for it. If you want us to log a new one, let me know 70984.mp4 |
|
Hi @mjasikowski. The gradient issue is fixed, but in “Clear” and “Tinted” modes on macOS/Tahoe 26.0.1, the icon doesn’t look quite right. We can see a square inside the rounded icon. Do we need to log it? 1760125120449.pr-70984.mp4 |
|
@mjasikowski Also, the desktop app icon in MacOS (MacOS 15.7.1, MacOS 14.7.4/Desktop App 9.2.29-1) doesn't have rounded corners. Should this be reported as an issue? |
|
@IuliiaHerets please create issues for all of those and assign them to me |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.2.29-5 🚀
|
|
This PR added a fix for iOS builds in Xcode 26 that was already merged to This PR is removing this duplicate fix: |





Explanation of Change
Fixed Issues
$ #70711
PROPOSAL:
Tests
Offline tests
QA Steps
On iOS 26 and MacOS 26 Tahoe
On iOS <26 and MacOS <26:
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Mac OS desktop (Ad hoc build):
iOS:
Old icon on iOS 26 for comparison: