-
Notifications
You must be signed in to change notification settings - Fork 3.5k
fix: One member updated message is shown on reimporting spreadsheet #71082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp2025-09-25.12.18.33.movAndroid: mWeb Chrome2025-09-25.12.18.33.moviOS: HybridApp2025-09-25.12.03.11.moviOS: mWeb Safari2025-09-25.12.03.11.movMacOS: Chrome / Safariweb.movMacOS: Desktopweb.mov |
|
Interesting 2025-09-25.12.07.45.mov |
|
@ZhenjaHorbach Is this issue native-only? |
|
I also can't reproduce on IOS Native. |
No Updates: no longer reproducible |
|
LGTM! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/marcochavezf in version: 9.2.23-0 🚀
|
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.2.23-3 🚀
|
Explanation of Change
Fixed Issues
$ #69153
PROPOSAL: #69153 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-09-24.at.23.28.56.mp4
Android: mWeb Chrome
Screen.Recording.2025-09-24.at.23.31.47.mov
iOS: Native
Screen.Recording.2025-09-24.at.23.33.56.mov
iOS: mWeb Safari
Screen.Recording.2025-09-24.at.23.35.23.mov
MacOS: Chrome / Safari
Screen.Recording.2025-09-24.at.23.37.06.mov
MacOS: Desktop
Screen.Recording.2025-09-24.at.23.40.44.mov