Display new UI for alternate methods of scanning receipts by ShridharGoel · Pull Request #71340 · Expensify/App

ShridharGoel · 2025-09-25T19:33:21Z

Explanation of Change

Display new UI for alternate methods of scanning receipts.

Fixed Issues

Tests

Update Onyx data via console to simulate the different scenarios (else you can use different accounts which have the scenarios):

1. No Mobile App • No Phone Number

['nvp_lastAndroidLogin','nvp_lastiPhoneLogin','nvp_lastECashAndroidLogin','nvp_lastECashIOSLogin'].forEach((key) => Onyx.merge(key, null));
Onyx.set('loginList', {});
Onyx.merge('session', {email: 'user@example.com'});

Expectation:

Download the app to scan from your phone
Forward receipts to receipts@expensify.com
Add your number to text receipts to 47777

2. Mobile App Logged In • No Phone Number

['nvp_lastAndroidLogin','nvp_lastiPhoneLogin','nvp_lastECashAndroidLogin','nvp_lastECashIOSLogin'].forEach((key) => Onyx.merge(key, null));
Onyx.set('loginList', {});
Onyx.merge('session', {email: 'user@example.com'});
Onyx.merge('nvp_lastAndroidLogin', {lastVisited: new Date().toISOString()});

Expectation:

Forward receipts to receipts@expensify.com
Add your number to text receipts to 47777

3. No Mobile App • Phone Number Present

['nvp_lastAndroidLogin','nvp_lastiPhoneLogin','nvp_lastECashAndroidLogin','nvp_lastECashIOSLogin'].forEach((key) => Onyx.merge(key, null));
Onyx.set('loginList', {'+12223334444@expensify.sms': {partnerUserID: '+12223334444@expensify.sms'}});
Onyx.merge('session', {email: 'user@example.com'});

Expectation:

Download the app to scan from your phone
Forward receipts to receipts@expensify.com
Text receipts to 47777 (US numbers only)

4. Mobile App Logged In • Phone Number Present

['nvp_lastAndroidLogin','nvp_lastiPhoneLogin','nvp_lastECashAndroidLogin','nvp_lastECashIOSLogin'].forEach((key) => Onyx.merge(key, null));
Onyx.set('loginList', {'+12223334444@expensify.sms': {partnerUserID: '+12223334444@expensify.sms'}});
Onyx.merge('session', {email: 'user@example.com'});
Onyx.merge('nvp_lastAndroidLogin', {lastVisited: new Date().toISOString()});

Expectation:

Forward receipts to receipts@expensify.com
Text receipts to 47777 (US numbers only)

Download the app should link to: https://new.expensify.com/settings/about/app-download-links
Add your number should link to: https://new.expensify.com/settings/profile/contact-methods
Verify that no errors appear in the JS console

Offline tests

QA Steps

Scenario A – No mobile app • No phone number

Sign in with an account that has only an email login and has never opened the mobile app.
- New test accounts created on web fit this state by default.
Navigate to Create expense → Scan.
Verify the panel shows:
- “Download the app to scan from your phone” link.
- “Forward receipts to receipts@expensify.com”.
- “Add your number to text receipts to 47777”.

Scenario B – Mobile app used • No phone number

Install the Expensify mobile app on a device.
Log in with the same email account from Scenario A.
Return to the web/desktop app, refresh, open Create expense → Scan.
Confirm the panel now shows exactly:
- “Forward receipts to receipts@expensify.com”.
- “Add your number to text receipts to 47777”.

Scenario C – No mobile app • Phone number added

Use an account that has not opened the mobile app.
Go to Settings → Profile → Contact methods and add a phone number. Verify it’s confirmed (SMS code).
Refresh the Scan tab.
Confirm the panel shows:
- “Download the app to scan from your phone”.
- “Forward receipts to receipts@expensify.com”.
- “Text receipts to 47777 (US numbers only)”.

Scenario D – Mobile app used • Phone number added

Start from Scenario C’s account or any account with a verified phone number.
Open the mobile app and sign in to mark the mobile login as active.
Refresh the Scan tab on the desktop/web app.
Confirm the panel shows exactly:
- “Forward receipts to receipts@expensify.com”.
- “Text receipts to 47777 (US numbers only)”.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2025-10-07.at.1.10.06.PM.mov

iOS: Native

Simulator.Screen.Recording.-.iPhone.16.Plus.-.2025-10-07.at.13.13.01.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.16.Plus.-.2025-10-07.at.13.11.56.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-10-07.at.1.10.41.PM.mov

MacOS: Desktop

Screen.Recording.2025-10-07.at.1.15.23.PM.mov

codecov · 2025-09-25T19:50:08Z

Codecov Report

❌ Patch coverage is 84.31373% with 8 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...ages/iou/request/step/IOURequestStepScan/index.tsx	0.00%	7 Missing ⚠️
...TMLEngineProvider/HTMLRenderers/AnchorRenderer.tsx	0.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

melvin-bot · 2025-09-26T20:00:43Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

parasharrajat · 2025-09-26T20:03:39Z

src/components/ReceiptAlternativeMethods.tsx

+    const shouldShowDownloadApp = !hasLoggedIntoMobileApp;
+    const shouldShowAddPhoneNumber = !hasPhoneNumber;
+    const shouldShowTextReceipts = hasPhoneNumber;


Remove extra variables and directly use the conditions.

parasharrajat · 2025-09-26T20:04:05Z

src/hooks/useHasPhoneNumber.ts

+import ONYXKEYS from '@src/ONYXKEYS';
+import useOnyx from './useOnyx';
+
+const useHasPhoneNumber = () => {


Suggested change

const useHasPhoneNumber = () => {

const useHasPhoneNumberLogin = () => {

parasharrajat · 2025-09-26T20:11:44Z

src/hooks/useHasPhoneNumber.ts

+        .map((login) => Str.removeSMSDomain(login))
+        .find((login) => Str.isValidE164Phone(login));


Can be done in one loop. Use .some

parasharrajat · 2025-09-26T20:13:17Z

src/hooks/useHasPhoneNumberLogin.ts

+        .map((login) => Str.removeSMSDomain(login))
+        .find((login) => Str.isValidE164Phone(login));
+
+    const smsLoginExists = Object.keys(loginList ?? {}).some((login) => Str.isSMSLogin(login));


How is it different from validPhoneInLoginList?

parasharrajat · 2025-09-26T20:15:11Z

src/languages/pt-BR.ts

        }),
    },
    receipt: {
+        alternativeMethodsTextReceipts: ({phoneNumber}: ReceiptAlternativeMethodsPhoneNumberParams) => `Text receipts to ${phoneNumber} (US numbers only)`,


Convert to a single string per sentence. Don't break into parts. Use RenderHTML component to render that whole sentense.

parasharrajat · 2025-09-26T20:17:03Z

src/pages/iou/request/step/IOURequestStepScan/index.tsx

                        />
                    </DragAndDropConsumer>
-                    {!shouldHideDownloadAppBanner && <DownloadAppBanner onLayout={(e) => setDownloadAppBannerHeight(e.nativeEvent.layout.height)} />}
+                    {!shouldHideAlternativeMethods && <ReceiptAlternativeMethods onLayout={(e) => setAlternativeMethodsHeight(e.nativeEvent.layout.height)} />}


DownloadAppBanner Remove this component if we are not using it anymore.

parasharrajat · 2025-09-27T12:31:09Z

src/components/ReceiptAlternativeMethods.tsx

+    onLayout?: (event: LayoutChangeEvent) => void;
+};
+
+function ReceiptAlternativeMethods({onLayout}: ReceiptAlternativeMethodsProps) {


Add displayName

Didn't get the usage of displayName here, can you clarify?

Suggested change

function ReceiptAlternativeMethods({onLayout}: ReceiptAlternativeMethodsProps) {

ReceiptAlternativeMethods.displayName = "ReceiptAlternativeMethods";

Add this at the bottom of this component.

parasharrajat · 2025-09-27T12:31:48Z

src/components/ReceiptAlternativeMethods.tsx

+    const {environmentURL} = useEnvironment();
+    const {translate} = useLocalize();
+    const {hasLoggedIntoMobileApp, isLastMobileAppLoginLoaded} = useHasLoggedIntoMobileApp();
+    const {hasPhoneNumberLogin, isLoaded: isPhoneNumberLoaded} = useHasPhoneNumberLogin();


Can you rename isLoaded to isPhoneNumberLoaded in the hook

parasharrajat · 2025-09-27T12:35:41Z

src/components/DownloadAppBanner.tsx

-                title={translate('common.getTheApp')}
-                subtitle={translate('common.scanReceiptsOnTheGo')}


let's remove these strings from the translations if not used in the app.

parasharrajat · 2025-09-27T12:36:23Z

src/languages/es.ts

+        alternativeMethodsTextReceipts: ({phoneNumber}: ReceiptAlternativeMethodsPhoneNumberParams) =>
+            `<muted-text-label>Text receipts to ${phoneNumber} (US numbers only)</muted-text-label>`,
+        alternativeMethodsForwardReceipts: ({email}: {email: string}) => `<muted-text-label>Forward receipts to <a href="mailto:${email}">${email}</a></muted-text-label>`,
+        alternativeMethodsDownloadApp: ({downloadUrl}: {downloadUrl: string}) => `<muted-text-label><a href="${downloadUrl}">Download the app</a> to scan from your phone</muted-text-label>`,
+        alternativeMethodsTitle: 'Other ways to add receipts:',
+        alternativeMethodsAddPhoneNumber: ({phoneNumber, contactMethodsUrl}: ReceiptAlternativeMethodsPhoneNumberParams & {contactMethodsUrl: string}) =>
+            `<muted-text-label><a href="${contactMethodsUrl}">Add your number</a> to text receipts to ${phoneNumber}</muted-text-label>`,
+        desktopSubtitleMultiple: 'or drag and drop them here',
+        desktopSubtitleSingle: 'or drag and drop them here',


Have you confirmed this on slack? Can you please add the slack discussion link in PR checklist

parasharrajat · 2025-09-27T12:38:16Z

Please use meaningful commit messages.

…honeNumberLoaded

parasharrajat · 2025-09-27T16:15:02Z

src/languages/es.ts

 } from './params';
 import type {TranslationDeepObject} from './types';

+type ReceiptAlternativeMethodsPhoneNumberParams = {


Move this type to params and import on each file.

src/languages/en.ts

parasharrajat · 2025-09-28T08:54:00Z

@ShridharGoel please add QA steps and test steps. You can see other PRs for examples.

Also, fix the checks.

…ams to params.ts

stitesExpensify · 2025-10-06T14:29:09Z

I manually ran the script and it keeps failing unfortunately. Can you please create an openAI key and run the script yourself like it was described here?

ShridharGoel · 2025-10-06T18:08:47Z

@parasharrajat The other translations are added now.

parasharrajat

@ShridharGoel It is all messed up. Can you carefully check all translation files and sync them.

Same key structure.
same key location.
All translation files have same changes except strings. in different languages.

ShridharGoel · 2025-10-06T19:54:34Z

@parasharrajat Updated the order of strings.

parasharrajat

May be you are not seeing what I am seeing but there are still issues.

parasharrajat · 2025-10-07T06:30:26Z

src/languages/en.ts

-        dragReceiptBeforeEmail: 'Drag a receipt onto this page, forward a receipt to ',
-        dragReceiptsBeforeEmail: 'Drag receipts onto this page, forward receipts to ',
-        dragReceiptAfterEmail: ' or choose a file to upload below.',
-        dragReceiptsAfterEmail: ' or choose files to upload below.',


This change is not consistent.

parasharrajat · 2025-10-07T06:33:36Z

Also, attach recordings of the flow impacted on all platforms.

…pensifyApp into alternateMethods

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

OSBotify · 2025-10-07T14:37:04Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

roryabraham · 2025-10-07T15:56:28Z

@shawnborton @trjExpensify for future reference, you can run translations on any given PR by triggering this workflow: https://github.com/Expensify/App/actions/workflows/generateTranslations.yml

roryabraham · 2025-10-07T16:00:42Z

Created a SO: https://stackoverflowteams.com/c/expensify/questions/22718/22719#22719

shawnborton · 2025-10-07T16:19:41Z

Oh, great to know!

OSBotify · 2025-10-08T05:10:50Z

🚀 Deployed to staging by https://github.com/inimaga in version: 9.2.27-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

IuliiaHerets · 2025-10-08T16:02:05Z

Hi @ShridharGoel , the new upload receipts UI on the scan tab is seen on Web & desktop only. No changes on mweb, iOS & Android apps. Is it expected, or do we need to log an issue?

ShridharGoel · 2025-10-08T16:03:57Z

That's expected

OSBotify · 2025-10-08T21:35:22Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.2.27-6 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Display new UI for alternate methods of scanning receipts

8b7f162

melvin-bot bot assigned ShridharGoel Sep 25, 2025

ShridharGoel added 5 commits September 26, 2025 21:04

Updates

960790f

Add missing key in translations

d959653

Updates

b1ce7dc

Lint fixes

6b76734

Lint fixes

5f03a26

ShridharGoel force-pushed the alternateMethods branch from 6f9073b to 5f03a26 Compare September 26, 2025 19:09

Update label

ff4a57b

ShridharGoel marked this pull request as ready for review September 26, 2025 20:00

ShridharGoel requested a review from a team as a code owner September 26, 2025 20:00

melvin-bot bot requested review from parasharrajat and removed request for a team September 26, 2025 20:00

parasharrajat suggested changes Sep 26, 2025

View reviewed changes

ShridharGoel added 3 commits September 27, 2025 17:11

Update based on comments

ee98408

Prettier fixes

74feeb6

Update

f4d8abc

parasharrajat reviewed Sep 27, 2025

View reviewed changes

ShridharGoel added 2 commits September 27, 2025 18:20

Update translations, remove unused strings and update isLoaded to isP…

da1dacb

…honeNumberLoaded

Update translations and remove unused strings

bd57d43

parasharrajat reviewed Sep 27, 2025

View reviewed changes

src/languages/en.ts Show resolved Hide resolved

Update string orders and move ReceiptAlternativeMethodsPhoneNumberPar…

775db36

…ams to params.ts

ShridharGoel added 2 commits October 6, 2025 22:28

Add translations for other languages

1a20221

Prettier fixes

522f425

ShridharGoel requested a review from parasharrajat October 6, 2025 18:08

parasharrajat reviewed Oct 6, 2025

View reviewed changes

ShridharGoel added 2 commits October 7, 2025 00:53

Update order of strings

573e778

Merge branch 'main' into alternateMethods

cc558d5

parasharrajat suggested changes Oct 7, 2025

View reviewed changes

ShridharGoel added 2 commits October 7, 2025 13:02

Remove some extra strings

8cb330e

Merge branch 'alternateMethods' of https://github.com/ShridharGoel/Ex…

cfdc6ce

…pensifyApp into alternateMethods

ShridharGoel requested a review from parasharrajat October 7, 2025 07:55

parasharrajat approved these changes Oct 7, 2025

View reviewed changes

melvin-bot bot requested a review from inimaga October 7, 2025 08:48

Fix desktopSubtitleMultiple translation in es.ts

2f7b90f

inimaga approved these changes Oct 7, 2025

View reviewed changes

inimaga merged commit 3f19f38 into Expensify:main Oct 7, 2025
20 checks passed

OSBotify mentioned this pull request Oct 8, 2025

Deploy Checklist: New Expensify 2025-10-08 #72057

Closed

62 tasks

melvin-bot bot mentioned this pull request Oct 8, 2025

[Due for payment 2025-10-15] [$250] Update Create expense > Scan screen on web/desktop ONLY #70693

Closed

ShridharGoel mentioned this pull request Oct 13, 2025

Add recovery code feature in auth form #72003

Merged

54 tasks

	const useHasPhoneNumber = () => {
	const useHasPhoneNumberLogin = () => {

		.map((login) => Str.removeSMSDomain(login))
		.find((login) => Str.isValidE164Phone(login));

	function ReceiptAlternativeMethods({onLayout}: ReceiptAlternativeMethodsProps) {
	ReceiptAlternativeMethods.displayName = "ReceiptAlternativeMethods";

		title={translate('common.getTheApp')}
		subtitle={translate('common.scanReceiptsOnTheGo')}

Conversation

ShridharGoel commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

1. No Mobile App • No Phone Number

2. Mobile App Logged In • No Phone Number

3. No Mobile App • Phone Number Present

4. Mobile App Logged In • Phone Number Present

Offline tests

QA Steps

Scenario A – No mobile app • No phone number

Scenario B – Mobile app used • No phone number

Scenario C – No mobile app • Phone number added

Scenario D – Mobile app used • Phone number added

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Sep 26, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

parasharrajat commented Sep 27, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

parasharrajat commented Sep 28, 2025

Uh oh!

stitesExpensify commented Oct 6, 2025

Uh oh!

ShridharGoel commented Oct 6, 2025

Uh oh!

parasharrajat left a comment

Choose a reason for hiding this comment

Uh oh!

ShridharGoel commented Oct 6, 2025

Uh oh!

parasharrajat left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

parasharrajat commented Oct 7, 2025

Uh oh!

parasharrajat left a comment

Choose a reason for hiding this comment

Reviewer Checklist

Uh oh!

Uh oh!

OSBotify commented Oct 7, 2025

Uh oh!

roryabraham commented Oct 7, 2025

ShridharGoel commented Sep 25, 2025 •

edited

Loading

codecov bot commented Sep 25, 2025 •

edited

Loading