Skip to content

Options default style fix #7136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Gonals merged 1 commit into from
Jan 12, 2022
Merged

Options default style fix #7136

Gonals merged 1 commit into from
Jan 12, 2022

Conversation

@chiragsalian
Copy link
Contributor

@chiragsalian chiragsalian commented Jan 11, 2022

Details

Fixed Issues

$ #7032
$ #6945

Tests / QA

  1. Create a new account.
  2. Create a workspace, then click on profile -> the workspace -> Manage members -> invite -> Type a random valid email.
  3. Confirm it shows up below the input as a clickable option.
    image
  4. Close this sidebar. Then click on the green plus icon on the bottom and select request money. Enter an amount and then a valid email.
  5. Confirm the email shows up below the input as a clickable option.
    image
  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@chiragsalian chiragsalian requested a review from a team as a code owner January 11, 2022 23:25
@chiragsalian chiragsalian self-assigned this Jan 11, 2022
@MelvinBot MelvinBot requested review from Gonals and removed request for a team January 11, 2022 23:26
@Gonals Gonals merged commit 7ba361b into main Jan 12, 2022
@Gonals Gonals deleted the chirag-option-style-fix branch January 12, 2022 11:04
@OSBotify OSBotify mentioned this pull request Jan 12, 2022
Closed
54 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Jan 12, 2022

🚀 Deployed to staging by @Gonals in version: 1.1.27-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Jan 12, 2022

🚀 Deployed to staging by @Gonals in version: 1.1.27-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Jan 12, 2022

🚀 Deployed to staging by @Gonals in version: 1.1.27-3 🚀

platform result
🤖 android 🤖 skipped 🚫
🖥 desktop 🖥 skipped 🚫
🍎 iOS 🍎 skipped 🚫
🕸 web 🕸 skipped 🚫

@puneetlath puneetlath mentioned this pull request Jan 12, 2022
Merged
@OSBotify
Copy link
Contributor

OSBotify commented Jan 14, 2022

🚀 Deployed to production by @Jag96 in version: 1.1.29-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gonals Gonals Gonals approved these changes

Assignees

@chiragsalian chiragsalian

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chiragsalian @OSBotify @Gonals