use useSearchSelector hook and remove unused and duplicated code by mkzie2 · Pull Request #71427 · Expensify/App

mkzie2 · 2025-09-27T17:34:53Z

Explanation of Change

use useSearchSelector hook and remove unused and duplicated code

Fixed Issues

$ #71061
PROPOSAL:

Tests

Case 1

Open Reports
Click on From filter
Select/Deselect the user
Verify that the selected user is displayed with the checkmark
Click on Filters > From
Select/Deselect the user
Verify that the selected user is displayed with the checkmark

Case 2

Go FAB > Start chat
Verify that the report and contact options are displayed correctly.
Verify that the selfDM is displayed as the first item if it exists
Type an email to any contact
Verify that the search result matches the search string
Select an option in Recent reports section
Send a message
Open Start chat page again
Verify that the report opened at step 6 is at the top of Recent reports and below the selfDM if it exists

Verify that no errors appear in the JS console

Offline tests

Same

QA Steps

Case 1

Open Reports
Click on From filter
Select/Deselect the user
Verify that the selected user is displayed with the checkmark
Click on Filters > From
Select/Deselect the user
Verify that the selected user is displayed with the checkmark

Case 2

Go FAB > Start chat
Verify that the report and contact options are displayed correctly.
Verify that the selfDM is displayed as the first item if it exists
Type an email to any contact
Verify that the search result matches the search string
Select an option in Recent reports section
Send a message
Open Start chat page again
Verify that the report opened at step 6 is at the top of Recent reports and below the selfDM if it exists

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-09-28.at.00.12.38.mov

Android: mWeb Chrome

Screen.Recording.2025-09-28.at.00.11.41.mov

iOS: Native

Screen.Recording.2025-09-28.at.00.14.25.mov

iOS: mWeb Safari

Screen.Recording.2025-09-28.at.00.13.23.mov

MacOS: Chrome / Safari

Screen.Recording.2025-09-28.at.00.11.09.mov

Screen.Recording.2025-10-08.at.21.44.38.mp4

MacOS: Desktop

Screen.Recording.2025-09-28.at.00.15.33.mov

codecov · 2025-09-27T17:50:20Z

Codecov Report

❌ Patch coverage is 56.52174% with 10 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...ponents/Search/FilterDropdowns/UserSelectPopup.tsx	0.00%	5 Missing ⚠️
...nents/Search/SearchFiltersParticipantsSelector.tsx	0.00%	4 Missing ⚠️
src/hooks/useSearchSelector.base.ts	90.00%	1 Missing ⚠️

Files with missing lines	Coverage Δ
src/pages/NewChatPage.tsx	`77.50% <100.00%> (-1.39%)`	⬇️
src/hooks/useSearchSelector.base.ts	`80.00% <90.00%> (+26.55%)`	⬆️
...nents/Search/SearchFiltersParticipantsSelector.tsx	`0.00% <0.00%> (ø)`
...ponents/Search/FilterDropdowns/UserSelectPopup.tsx	`0.00% <0.00%> (ø)`

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

melvin-bot · 2025-09-27T17:53:08Z

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2025-09-27T18:42:01Z

I suppose this is mine 😃

ZhenjaHorbach · 2025-09-27T18:42:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

2025-10-09.16.38.58.mov

Android: mWeb Chrome

2025-10-09.16.38.58.mov

iOS: HybridApp

2025-10-09.16.30.35.mov

iOS: mWeb Safari

2025-10-09.16.30.35.mov

MacOS: Chrome / Safari

2025-10-09.16.23.46.mov

MacOS: Desktop

2025-10-09.16.23.46.mov

sosek108 · 2025-09-30T07:48:08Z

I'd like to be added as additional reviewer @ZhenjaHorbach @pecanoro

ZhenjaHorbach · 2025-09-30T07:50:10Z

I'd like to be added as additional reviewer @ZhenjaHorbach @pecanoro

I think you can leave comments without any permission 😅

sosek108 · 2025-09-30T07:56:15Z

That's true 😅 I thought I need to be assigned officialy

ZhenjaHorbach · 2025-09-30T08:44:46Z

src/components/Search/FilterDropdowns/UserSelectPopup.tsx


 function getSelectedOptionData(option: Option) {
-    return {...option, reportID: `${option.reportID}`, selected: true};
+    // eslint-disable-next-line rulesdir/no-default-id-values


Just checked
Do we really need this rule disable?

Yes, I added because it was failed.

do we really still need this function at all?

useSearchSelector returns already selected options that have isSelected set to true. i think, this should be deprecated

ZhenjaHorbach · 2025-09-30T09:00:37Z

That's true 😅 I thought I need to be assigned officialy

@sosek108
No worries
You can help with the review !

sosek108 · 2025-09-30T09:34:34Z

Issue mentions 3 components to change:

UserSelectPopup
SearchFiltersParticipantsSelector
NewChatPage

Only Two are changed in current PR

sosek108 · 2025-09-30T09:35:13Z

I also worry that test cases only focuses on selection and not on other important cases like filtering, sorting etc.

mkzie2 · 2025-09-30T09:48:59Z

@sosek108 Does we want to keep the behavior on NewChatPage here?

sosek108 · 2025-09-30T09:56:40Z

@mkzie2 yeah, we want. useSearchSelector lacks this currently but I created a proposal for that #66615 (comment) .

mkzie2 · 2025-10-02T16:39:11Z

@sosek108 So we don't need to do that here, right?

sosek108 · 2025-10-03T07:21:08Z

Let's wait, please. You'll need to add one prop to getValidOptions call.

mkzie2 · 2025-10-03T08:01:55Z

Got it.

sosek108 · 2025-10-07T10:54:04Z

@mkzie2 PR with changes to that got merged. #71557

This PR introduces property maxRecentReportsToShow which helps you limit number of reports

mkzie2 · 2025-10-07T14:16:05Z

I will check and update soon.

mkzie2 · 2025-10-27T05:05:08Z

@pecanoro I resolved the conflict.

mkzie2 · 2025-10-27T05:05:33Z

Do we need to retest here?

I tested.

sosek108

LGTM

NikkiWines

Sorry for the delay, was OOO - this looks good 👍

NikkiWines · 2025-10-31T15:54:23Z

@mkzie2 could you merge main quick just cause this is a few days out of date?

ZhenjaHorbach · 2025-11-03T12:59:36Z

@mkzie2
Friendly bump!

mkzie2 · 2025-11-04T14:39:23Z

@ZhenjaHorbach @NikkiWines I merged main.

melvin-bot · 2025-11-04T16:23:27Z

@NikkiWines looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

NikkiWines · 2025-11-04T17:23:32Z

All the tests passed?? 😕

OSBotify · 2025-11-04T18:01:20Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-11-04T21:13:18Z

🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.2.44-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-11-05T20:06:42Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.44-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

use useSearchSelector hook and remove unused and duplicated code

8960b9c

melvin-bot bot assigned mkzie2 Sep 27, 2025

disable lint rule

6994cd7

mkzie2 marked this pull request as ready for review September 27, 2025 17:53

mkzie2 requested a review from a team as a code owner September 27, 2025 17:53

melvin-bot bot requested review from rushatgabhane and removed request for a team September 27, 2025 17:53

ZhenjaHorbach reviewed Sep 30, 2025

View reviewed changes

pecanoro requested a review from sosek108 October 1, 2025 10:30

Merge branch 'main' into mkzie2-issue/71061

a333262

mkzie2 added 3 commits October 8, 2025 21:12

resolve conflict

4d4358a

implement NewChatPage

b7974f3

fix ts check

1fbeee2

fix ts error

127ec62

sosek108 approved these changes Oct 27, 2025

View reviewed changes

NikkiWines approved these changes Oct 31, 2025

View reviewed changes

rushatgabhane removed their request for review November 3, 2025 20:49

Merge branch 'main' into mkzie2-issue/71061

f60abba

mkzie2 requested a review from a team as a code owner November 4, 2025 14:39

melvin-bot bot requested review from heyjennahay and removed request for a team November 4, 2025 14:39

NikkiWines merged commit 88b525e into Expensify:main Nov 4, 2025
34 of 44 checks passed

melvin-bot bot added the Emergency label Nov 4, 2025

github-actions bot mentioned this pull request Nov 4, 2025

Investigate workflow job failing on main: test / test (job 2) #74213

Closed

NikkiWines removed the Emergency label Nov 4, 2025

github-actions bot mentioned this pull request Nov 4, 2025

Investigate workflow job failing on main: test / test (job 2) #74219

Closed

OSBotify mentioned this pull request Nov 4, 2025

Deploy Checklist: New Expensify 2025-11-04 #74235

Closed

56 tasks

mitarachim mentioned this pull request Nov 4, 2025

[Due for payment 2025-11-13] [Due for payment 2025-11-12] Start chat & Reports - From list does not load when there are more than 50 contacts #74239

Closed

8 tasks

Eskalifer1 mentioned this pull request Nov 5, 2025

[Due for payment 2025-11-13] [Due for payment 2025-11-12] Reports - From filter shows no result found when searching for me/you #74277

Closed

8 tasks

linhvovan29546 mentioned this pull request Nov 5, 2025

Refactor provided component to use useSearchSelector hook and remove unused and duplicated code (Task 5) #71450

Merged

54 tasks

lakchote mentioned this pull request Nov 5, 2025

Revert "use useSearchSelector hook and remove unused and duplicated code" #74302

Merged

lanitochka17 mentioned this pull request Nov 5, 2025

[Due for payment 2025-11-13] [Due for payment 2025-11-12] Start chat - Self DM is missing from Recent list if there are more than 5 recent chats #74236

Closed

16 tasks

NikkiWines mentioned this pull request Nov 5, 2025

[Due for payment 2025-11-12] [$250] Refactor provided component to use useSearchSelector hook and remove unused and duplicated code (Task 4) #71061

Open

Conversation

mkzie2 commented Sep 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Sep 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Sep 27, 2025

Uh oh!

ZhenjaHorbach commented Sep 27, 2025

Uh oh!

ZhenjaHorbach commented Sep 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

sosek108 commented Sep 30, 2025

Uh oh!

ZhenjaHorbach commented Sep 30, 2025

Uh oh!

sosek108 commented Sep 30, 2025

Uh oh!

ZhenjaHorbach Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

mkzie2 Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

sosek108 Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sosek108 commented Sep 30, 2025

Uh oh!

sosek108 commented Sep 30, 2025

Uh oh!

mkzie2 commented Sep 30, 2025

Uh oh!

sosek108 commented Sep 30, 2025

Uh oh!

mkzie2 commented Oct 2, 2025

Uh oh!

sosek108 commented Oct 3, 2025

Uh oh!

mkzie2 commented Oct 3, 2025

Uh oh!

sosek108 commented Oct 7, 2025

Uh oh!

mkzie2 commented Oct 7, 2025

Uh oh!

mkzie2 commented Oct 27, 2025

Uh oh!

mkzie2 commented Oct 27, 2025

Uh oh!

sosek108 left a comment

Choose a reason for hiding this comment

Uh oh!

NikkiWines left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NikkiWines commented Oct 31, 2025

Uh oh!

ZhenjaHorbach commented Nov 3, 2025

Uh oh!

mkzie2 commented Nov 4, 2025

Uh oh!

Uh oh!

melvin-bot bot commented Nov 4, 2025

Uh oh!

mkzie2 commented Sep 27, 2025 •

edited

Loading

codecov bot commented Sep 27, 2025 •

edited

Loading

ZhenjaHorbach commented Sep 27, 2025 •

edited

Loading

ZhenjaHorbach commented Sep 30, 2025 •

edited

Loading

NikkiWines left a comment •

edited

Loading