-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Not redirected to the newly created WS chat after filI the "I'm a teacher" form #71445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid-app-2025-10-03_15.56.56.mp4Android: mWeb Chromeandroid-chrome-2025-10-03_14.54.32.mp4iOS: HybridAppios-app-2025-10-03_15.53.30.mp4iOS: mWeb Safariios-safari-2025-10-03_15.21.01.mp4MacOS: Chrome / Safaridesktop-chrome-2025-10-03_14.35.31.mp4MacOS: Desktopdesktop-app-2025-10-03_14.39.14.mp4 |
jjcoffee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/dangrous in version: 9.2.23-0 🚀
|
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.2.23-3 🚀
|
Explanation of Change
Fixed Issues
$ #71159
PROPOSAL: #71159
Tests
Offline tests
QA Steps
Similar to Tests step
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
website.android.mov
iOS: Native
ios.mov
iOS: mWeb Safari
website.ios.mov
MacOS: Chrome / Safari
website.mov
MacOS: Desktop
desktop.mov