Skip to content

Add stories for TextInput #7149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
roryabraham merged 1 commit into from
Jan 12, 2022
Merged

Add stories for TextInput #7149

roryabraham merged 1 commit into from
Jan 12, 2022

Conversation

@roryabraham
Copy link
Contributor

@roryabraham roryabraham commented Jan 12, 2022

Details

Adds stories for the TextInput component. Using this as a dummy PR for testing #6906

Fixed Issues

n/a

Tests

  1. Run npm run storybook
  2. Look at the new stories and verify they work correctly!
  • Verify that no errors appear in the JS console

QA Steps

  1. Go to https://new.expensify.com/docs/index.html
  2. Verify that you see the TextInput stories are available.
  3. Play with them a bit and see that they work 🙂
  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

@roryabraham roryabraham requested a review from a team as a code owner January 12, 2022 06:26
@roryabraham
Copy link
Contributor Author

roryabraham commented Jan 12, 2022

Keeping this on hold for the purpose of testing #6906

@MelvinBot MelvinBot requested review from danieldoglas and removed request for a team January 12, 2022 06:27
@roryabraham roryabraham self-assigned this Jan 12, 2022
@roryabraham roryabraham mentioned this pull request Jan 12, 2022
Merged
27 tasks
@roryabraham roryabraham changed the title [HOLD] Add stories for TextInput Add stories for TextInput Jan 12, 2022
@roryabraham roryabraham merged commit 3910a6c into main Jan 12, 2022
@roryabraham roryabraham deleted the Rory-TextInputStories branch January 12, 2022 19:42
@OSBotify
Copy link
Contributor

OSBotify commented Jan 12, 2022

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Jan 12, 2022
@roryabraham @OSBotify
Merge pull request #7149 from Expensify/Rory-TextInputStories
5d66867 
(cherry picked from commit 3910a6c)
@OSBotify OSBotify mentioned this pull request Jan 12, 2022
Merged
@OSBotify
Copy link
Contributor

OSBotify commented Jan 12, 2022

🚀 Cherry-picked to staging by @roryabraham in version: 1.1.29-2 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify OSBotify mentioned this pull request Jan 13, 2022
Closed
54 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Jan 14, 2022

🚀 Deployed to production by @Jag96 in version: 1.1.29-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Jan 15, 2022
Closed
66 tasks
@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danieldoglas danieldoglas danieldoglas approved these changes

+1 more reviewer

@Jag96 Jag96 Jag96 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@roryabraham roryabraham

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@roryabraham @OSBotify @Jag96 @danieldoglas