Skip to content

Give Storybook a facelift #7154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
roryabraham merged 6 commits into from
Jan 12, 2022
Merged

Give Storybook a facelift #7154

roryabraham merged 6 commits into from
Jan 12, 2022

Conversation

@roryabraham
Copy link
Contributor

@roryabraham roryabraham commented Jan 12, 2022 •
edited
Loading

Details

This adds our brand theme to our storybook docs. I am keeping this on hold in the meantime because I would like to use it to test #6906.

Fixed Issues

n/a

Tests

  1. Run npm i && npm run storybook
  2. Verify that the documentation site builds and looks great!
  • Verify that no errors appear in the JS console

QA Steps

Go to https://staging.new.expensify.com/docs/index.html and verify that you can see the storybook docs with the themes matching the screenshots below.

  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen Shot 2022-01-12 at 3 55 42 AM

Screen Shot 2022-01-12 at 3 55 56 AM

Screen Shot 2022-01-12 at 3 56 53 AM

Screen Shot 2022-01-12 at 3 56 23 AM

Screen Shot 2022-01-12 at 3 56 09 AM

@roryabraham roryabraham self-assigned this Jan 12, 2022
@roryabraham roryabraham changed the title Give Storybook a facelift [HOLD] Give Storybook a facelift Jan 12, 2022
@roryabraham roryabraham marked this pull request as ready for review January 12, 2022 12:05
@roryabraham roryabraham requested a review from a team as a code owner January 12, 2022 12:05
@MelvinBot MelvinBot requested review from MonilBhavsar and removed request for a team January 12, 2022 12:05
@roryabraham roryabraham mentioned this pull request Jan 12, 2022
Merged
27 tasks
Jag96
Jag96 approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@Jag96 Jag96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@roryabraham roryabraham changed the title [HOLD] Give Storybook a facelift Give Storybook a facelift Jan 12, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 12, 2022

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@roryabraham roryabraham merged commit ea70c2e into main Jan 12, 2022
@roryabraham roryabraham deleted the Rory-StorybookFacelift branch January 12, 2022 19:33
OSBotify pushed a commit that referenced this pull request Jan 12, 2022
@roryabraham @OSBotify
Merge pull request #7154 from Expensify/Rory-StorybookFacelift
be17e57 
(cherry picked from commit ea70c2e)
This was referenced Jan 12, 2022
Merged
Closed
@OSBotify
Copy link
Contributor

OSBotify commented Jan 12, 2022

🚀 Cherry-picked to staging by @roryabraham in version: 1.1.29-1 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@kbecciv kbecciv mentioned this pull request Jan 13, 2022
Closed
@OSBotify
Copy link
Contributor

OSBotify commented Jan 14, 2022

🚀 Deployed to production by @Jag96 in version: 1.1.29-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Jan 15, 2022
Closed
66 tasks
@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
@roryabraham roryabraham mentioned this pull request Apr 5, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MonilBhavsar MonilBhavsar Awaiting requested review from MonilBhavsar

1 more reviewer

@Jag96 Jag96 Jag96 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@roryabraham roryabraham

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@roryabraham @OSBotify @Jag96