-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[NO QA] Update Distance-Expenses.md #71618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adding details about creating distance expenses manually - Expensify/Expensify#505952
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@stephanieelliott Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
docs/articles/new-expensify/reports-and-expenses/Distance-Expenses.md
Outdated
Show resolved
Hide resolved
docs/articles/new-expensify/reports-and-expenses/Distance-Expenses.md
Outdated
Show resolved
Hide resolved
HelpDot Documentation ReviewOverall AssessmentThis PR adds valuable manual distance expense functionality to the existing Distance-Expenses.md documentation. The changes expand coverage to include both map-based and manual distance entry methods, making the guide more comprehensive for users who need flexibility in expense creation. Scores Summary
Key Findings
RecommendationsPriority fixes needed:
Style improvements:
Files Reviewed
The documentation successfully addresses the GitHub issue requirements and provides users with comprehensive guidance for creating distance expenses. With the minor formatting fixes addressed, this will be a solid addition to the HelpDot documentation. Note: The changes align well with HelpDot standards overall, with the main improvements needed being formatting consistency and minor language refinements. |
docs/articles/new-expensify/reports-and-expenses/Distance-Expenses.md
Outdated
Show resolved
Hide resolved
docs/articles/new-expensify/reports-and-expenses/Distance-Expenses.md
Outdated
Show resolved
Hide resolved
docs/articles/new-expensify/reports-and-expenses/Distance-Expenses.md
Outdated
Show resolved
Hide resolved
|
A preview of your ExpensifyHelp changes have been deployed to https://15366144.helpdot.pages.dev ⚡️ |
docs/articles/new-expensify/reports-and-expenses/Distance-Expenses.md
Outdated
Show resolved
Hide resolved
Changed Kilometres to Kilometers
kadiealexander
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
🚀 Deployed to staging by https://github.com/kadiealexander in version: 9.2.22-1 🚀
|
|
Hi @VictoriaExpensify, any QA steps here? |
|
@kadiealexander Can you please help with it?
|
Whoops yes this was NOQA. checked off |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.2.22-6 🚀
|
Adding details about creating distance expenses manually - https://github.com/Expensify/Expensify/issues/505952
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop