QBD Accounting Method #71667

mollfpr · 2025-10-01T12:01:01Z

Explanation of Change

We have implemented the accounting method config for QBD in OldDot, and also have the API command to update the QBD accounting method. Similar to #51512 and #57522 but for QBD.

Enhanced the QBD advanced page config to have auto-sync page selection
New QBD advanced auto-sync page
[New Feature] Add QBD advanced accounting method page for updating the QBD accounting method

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/422402
$ https://github.com/Expensify/Expensify/issues/474825
PROPOSAL:

Tests

Preresuite:

Have an account policy connected with QBD

Sign in to NewDot
Go to the workspace page > Accounting
Click on the Advanced menu
Verify the auto-sync show the value Enabled/Disabled
Click on the Auto-sync selection
Verify it's showing the auto-sync toggle and When to Export selection with accounting method value default to CASH
Click on the When to export selection
Select the value
Verify you will take back to auto-sync page and When to Export shows the selected accounting method

Verify that no errors appear in the JS console

Offline tests

Preresuite:

Have an account policy connected with QBD

Sign in to NewDot
Go to the workspace page > Accounting
Click on the Advanced menu
Verify the auto-sync show the value Enabled/Disabled
Click on the Auto-sync selection
Verify it's showing the auto-sync toggle and When to Export selection with accounting method value default to CASH
Click on the When to export selection
Select the value
Verify you will take back to auto-sync page and When to Export shows the selected accounting method

QA Steps

Preresuite:

Have an account policy connected with QBD

Sign in to NewDot
Go to the workspace page > Accounting
Click on the Advanced menu
Verify the auto-sync show the value Enabled/Disabled
Click on the Auto-sync selection
Verify it's showing the auto-sync toggle and When to Export selection with accounting method value default to CASH
Click on the When to export selection
Select the value
Verify you will take back to auto-sync page and When to Export shows the selected accounting method

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.Oct.1.2025.mp4

MacOS: Desktop

src/pages/workspace/accounting/qbd/advanced/QuickbooksDesktopAccountingMethodPage.tsx

src/pages/workspace/accounting/qbd/advanced/QuickbooksDesktopAdvancedPage.tsx

src/pages/workspace/accounting/qbd/advanced/QuickbooksDesktopAutoSyncPage.tsx

src/libs/actions/connections/QuickbooksDesktop.ts

src/pages/workspace/accounting/qbd/advanced/QuickbooksDesktopAccountingMethodPage.tsx

src/libs/API/types.ts

…unting-method

codecov · 2025-10-02T06:55:02Z

Codecov Report

❌ Patch coverage is 0% with 64 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...ing/qbd/advanced/QuickbooksDesktopAutoSyncPage.tsx	0.00%	21 Missing ⚠️
...advanced/QuickbooksDesktopAccountingMethodPage.tsx	0.00%	19 Missing ⚠️
...ing/qbd/advanced/QuickbooksDesktopAdvancedPage.tsx	0.00%	10 Missing ⚠️
src/ROUTES.ts	0.00%	8 Missing ⚠️
src/libs/actions/connections/QuickbooksDesktop.ts	0.00%	4 Missing ⚠️
...gation/AppNavigator/ModalStackNavigators/index.tsx	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #71667      +/-   ##
==========================================
- Coverage   35.20%   35.16%   -0.04%     
==========================================
  Files        3297     3299       +2     
  Lines      108149   108205      +56     
  Branches    34545    34562      +17     
==========================================
- Hits        38070    38048      -22     
- Misses      69893    69971      +78     
  Partials      186      186

Files with missing lines	Coverage Δ
src/CONST/index.ts	`85.84% <ø> (ø)`
src/SCREENS.ts	`100.00% <ø> (ø)`
src/libs/API/types.ts	`100.00% <ø> (ø)`
...gation/linkingConfig/RELATIONS/WORKSPACE_TO_RHP.ts	`100.00% <ø> (ø)`
src/libs/Navigation/linkingConfig/config.ts	`75.00% <ø> (ø)`
...gation/AppNavigator/ModalStackNavigators/index.tsx	`8.26% <0.00%> (-0.03%)`	⬇️
src/libs/actions/connections/QuickbooksDesktop.ts	`0.00% <0.00%> (ø)`
src/ROUTES.ts	`10.63% <0.00%> (-0.10%)`	⬇️
...ing/qbd/advanced/QuickbooksDesktopAdvancedPage.tsx	`0.00% <0.00%> (ø)`
...advanced/QuickbooksDesktopAccountingMethodPage.tsx	`0.00% <0.00%> (ø)`
... and 1 more

... and 3 files with indirect coverage changes

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

src/pages/workspace/accounting/qbd/advanced/QuickbooksDesktopAccountingMethodPage.tsx

src/pages/workspace/accounting/qbd/advanced/QuickbooksDesktopAdvancedPage.tsx

src/pages/workspace/accounting/qbd/advanced/QuickbooksDesktopAutoSyncPage.tsx

src/pages/workspace/accounting/qbd/advanced/QuickbooksDesktopAccountingMethodPage.tsx

melvin-bot · 2025-10-02T11:28:24Z

@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…unting-method

mollfpr · 2025-10-06T13:35:25Z

@dominictb Could you take a review? Thanks!

francoisl · 2025-10-06T17:57:27Z

src/languages/fr.ts

+                label: 'Quand exporter',
+                description: 'Choisissez quand exporter les dépenses :',
+                values: {
+                    [COMMON_CONST.INTEGRATIONS.ACCOUNTING_METHOD.ACCRUAL]: 'Accrual',


This doesn't seem to have been translated in fr.ts, it.ts, and nl.ts.

Yeah, it hasn't been translated. We also didn't translate the copy for xero, qbo, or intacct.

dominictb · 2025-10-07T18:40:14Z

src/libs/API/parameters/UpdateQuickbooksDesktopAccountingMethodParams.ts

+
+type UpdateQuickbooksDesktopAccountingMethodParams = {
+    policyID: string;
+    accountingMethod: ValueOf<typeof COMMON_CONST.INTEGRATIONS.ACCOUNTING_METHOD>;


I see that all of the endpoints for QuickbooksDesktop has this idempotencyKey param but am not sure what it's for. Do we need it here as well?

My understanding is the idempotency key is a unique identifier used to ensure that the same operation can be safely retried multiple times without causing duplicate or unintended side effects.

For QBD API, we actually haven't use it in the BE. So probably it's okay to not pass it here. @francoisl Could you confirm it?

I don't know either. The only API commands I see where we use the value in the backend are AddAttachment and AddTextAndAttachment, so... yes I think it's safe to remove? I don't understand why so many other API commands' parameter definitions have it though.

dominictb · 2025-10-07T18:52:02Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

Screen.Recording.2025-10-08.at.01.59.18.mov

iOS: HybridApp

Screen.Recording.2025-10-08.at.01.52.52-compressed.mov

iOS: mWeb Safari

Screen.Recording.2025-10-08.at.01.55.57-compressed.mov

MacOS: Chrome / Safari

Screen.Recording.2025-10-08.at.01.49.05-compressed.mov

MacOS: Desktop

github-actions · 2025-10-08T05:47:50Z

src/pages/workspace/accounting/qbd/advanced/QuickbooksDesktopAccountingMethodPage.tsx

+    const config = policy?.connections?.quickbooksDesktop?.config;
+    const accountingMethod = config?.export?.accountingMethod ?? COMMON_CONST.INTEGRATIONS.ACCOUNTING_METHOD.CASH;
+
+    const data: MenuListItem[] = Object.values(COMMON_CONST.INTEGRATIONS.ACCOUNTING_METHOD).map((accountingMethodType) => ({


❌ PERF-4 (docs)

Objects passed as props should be properly memoized to prevent unnecessary re-renders. Creating a new array with Object.values().map() on every render triggers re-renders of child components.

const data: MenuListItem[] = useMemo(() => Object.values(COMMON_CONST.INTEGRATIONS.ACCOUNTING_METHOD).map((accountingMethodType) => ({ value: accountingMethodType, text: translate(`workspace.qbd.accountingMethods.values.${accountingMethodType}` as TranslationPaths), alternateText: translate(`workspace.qbd.accountingMethods.alternateText.${accountingMethodType}` as TranslationPaths), keyForList: accountingMethodType, isSelected: accountingMethod === accountingMethodType, })), [translate, accountingMethod]);

github-actions · 2025-10-08T05:47:57Z

src/pages/workspace/accounting/qbd/advanced/QuickbooksDesktopAutoSyncPage.tsx

+            {!!autoSync?.enabled && (
+                <OfflineWithFeedback pendingAction={pendingAction}>
+                    <MenuItemWithTopDescription
+                        title={


❌ PERF-4 (docs)

The ternary conditional creates a new translated string object on every render. This should be memoized to prevent unnecessary re-renders of the MenuItemWithTopDescription component.

const accountingMethodTitle = useMemo(() => { return accountingMethod === COMMON_CONST.INTEGRATIONS.ACCOUNTING_METHOD.ACCRUAL ? translate(`workspace.qbd.accountingMethods.values.${COMMON_CONST.INTEGRATIONS.ACCOUNTING_METHOD.ACCRUAL}` as TranslationPaths) : translate(`workspace.qbd.accountingMethods.values.${COMMON_CONST.INTEGRATIONS.ACCOUNTING_METHOD.CASH}` as TranslationPaths); }, [translate, accountingMethod]); // Then use:

github-actions · 2025-10-08T05:48:06Z

src/pages/workspace/accounting/qbd/advanced/QuickbooksDesktopAdvancedPage.tsx

    const route = useRoute<PlatformStackRouteProp<SettingsNavigatorParamList, typeof SCREENS.WORKSPACE.ACCOUNTING.QUICKBOOKS_DESKTOP_ADVANCED>>();
+    const accountingMethod = qbdConfig?.export?.accountingMethod ?? COMMON_CONST.INTEGRATIONS.ACCOUNTING_METHOD.CASH;

    const qbdToggleSettingItems = [


❌ PERF-4 (docs)

The qbdToggleSettingItems array contains objects with function references that are created on every render. This should be memoized to prevent unnecessary re-renders of child components.

const qbdToggleSettingItems = useMemo(() => [ { title: translate('workspace.qbd.advancedConfig.createEntities'), subtitle: translate('workspace.qbd.advancedConfig.createEntitiesDescription'), switchAccessibilityLabel: translate('workspace.qbd.advancedConfig.createEntitiesDescription'), isActive: !!qbdConfig?.shouldAutoCreateVendor, onToggle: (isOn: boolean) => { updateQuickbooksDesktopShouldAutoCreateVendor(policyID, isOn); }, subscribedSetting: CONST.QUICKBOOKS_DESKTOP_CONFIG.SHOULD_AUTO_CREATE_VENDOR, errors: getLatestErrorField(qbdConfig, CONST.QUICKBOOKS_DESKTOP_CONFIG.SHOULD_AUTO_CREATE_VENDOR), pendingAction: settingsPendingAction([CONST.QUICKBOOKS_DESKTOP_CONFIG.SHOULD_AUTO_CREATE_VENDOR], qbdConfig?.pendingFields), }, ], [translate, qbdConfig?.shouldAutoCreateVendor, qbdConfig, policyID]);

…unting-method

github-actions · 2025-10-08T20:07:30Z

src/pages/workspace/accounting/qbd/advanced/QuickbooksDesktopAutoSyncPage.tsx

+            headerTitle="common.settings"
+            accessVariants={[CONST.POLICY.ACCESS_VARIANTS.ADMIN, CONST.POLICY.ACCESS_VARIANTS.PAID]}
+            policyID={policyID}
+            featureName={CONST.POLICY.MORE_FEATURES.ARE_CATEGORIES_ENABLED}


❌ PERF-6 (docs)

Using CONST.POLICY.MORE_FEATURES.ARE_CATEGORIES_ENABLED seems incorrect for a QuickBooks Desktop connection feature. This should likely be CONST.POLICY.MORE_FEATURES.ARE_CONNECTIONS_ENABLED to match the feature being used.

Fix: Change the featureName prop to use the appropriate constant:

featureName={CONST.POLICY.MORE_FEATURES.ARE_CONNECTIONS_ENABLED}

dominictb

melvin-bot · 2025-10-09T11:08:02Z

@chuckdries Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2025-10-09T11:08:06Z

🎯 @dominictb, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #72196.

chuckdries

LGTM! I don't understand why melvinbot requested a review from me when we already had a review from @francoisl - I'll leave the final approval to him

OSBotify · 2025-10-09T17:09:02Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-10-10T11:12:37Z

🚀 Deployed to staging by https://github.com/francoisl in version: 9.2.29-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-13T20:59:35Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.29-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

mollfpr added 7 commits October 1, 2025 18:50

add new copy for qbd accounting method

e0ad20c

add new action to update qbd accounting method

261e25d

new screens for qbd autosync and accounting method

2057ae3

new page for qbd accounting method

44326c3

new screen for qbd autosync

8938cb8

update qbd advanced page to navigate autosync instead toggle

42c8df9

add accountingMethod to qbd config

42079ed

mollfpr self-assigned this Oct 1, 2025