-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Fix < (backspace) button in time picker
#71702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix < (backspace) button in time picker
#71702
Conversation
fd5febb to
2cb0123
Compare
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid-app-2025-10-03_16.49.14.mp4Android: mWeb Chromeandroid-chrome-2025-10-03_16.51.08.mp4iOS: HybridAppios-app-2025-10-03_16.54.22.mp4iOS: mWeb Safariios-safari-2025-10-03_16.55.31.mp4MacOS: Chrome / Safaridesktop-chrome-2025-10-03_16.40.11.mp4MacOS: Desktopdesktop-app-2025-10-03_16.43.47.mp4 |
jjcoffee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/dangrous in version: 9.2.23-0 🚀
|
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.2.23-3 🚀
|
Explanation of Change
Fixes the
<button in the TimePicker component, which is unresponsive in Standalone app and causes a crash in HybridApp. This only occurs with "full format" input (also includes seconds and milliseconds).Fixed Issues
$ #71345
PROPOSAL: #71345 (comment)
Tests
Same as QA Steps
Offline tests
N/A
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
71702.android.native.mp4
Android: mWeb Chrome
71702.android.chrome.mp4
iOS: Native
71702.ios.native.mp4
iOS: mWeb Safari
71702.ios.safari.mp4
MacOS: Chrome / Safari
71702.macos.chrome.mov
MacOS: Desktop
71702.macos.desktop.mov