Skip to content

Update create expense confirmation page to more clearly indicate automation#72002

Closed
mkzie2 wants to merge 20 commits intoExpensify:mainfrom
mkzie2:mkzie2-issue/71601
Closed

Update create expense confirmation page to more clearly indicate automation#72002
mkzie2 wants to merge 20 commits intoExpensify:mainfrom
mkzie2:mkzie2-issue/71601

Conversation

@mkzie2
Copy link
Contributor

@mkzie2 mkzie2 commented Oct 7, 2025

Explanation of Change

Fixed Issues

$ #71601
PROPOSAL: #71601 (comment)

Tests

  1. Go to ND
  2. Create scan expense
  3. Verify that the UI is matched here
  4. Verify that we can still create expense normally
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

  1. Go to ND
  2. Create scan expense
  3. Verify that the UI is matched here
  4. Verify that we can still create expense normally
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android.mov
android.mov
Android: mWeb Chrome
android-web.mov
android-web.mov
iOS: Native
ios.mov
ios.mov
iOS: mWeb Safari
ios-web.mov
ios-web.mov
MacOS: Chrome / Safari
web.mov
web.mov
MacOS: Desktop
desktop.mov
desktop.mov

pendingMatchWithCreditCardDescription: 'Receipt pending match with card transaction. Mark as cash to cancel.',
markAsCash: 'Mark as cash',
routePending: 'Route pending...',
automaticallyEnterExpenseDetails: 'Concierge will automatically enter the expense details for you, or you can add them manually.',
Copy link
Contributor Author

@mkzie2 mkzie2 Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

card: 'Tarjeta',
whyDoWeAskForThis: '¿Por qué pedimos esto?',
required: 'Obligatorio',
automatic: 'Automático',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkzie2 mkzie2 changed the title Mkzie2 issue/71601 Update create expense confirmation page to more clearly indicate automation Oct 7, 2025
@codecov
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/components/ImageWithSizeCalculation.tsx 100.00% <ø> (ø)
src/components/MoneyRequestConfirmationList.tsx 54.98% <100.00%> (+0.66%) ⬆️
src/components/ReceiptImage/index.tsx 65.62% <ø> (-6.25%) ⬇️
...ListWithSections/BaseSelectionListWithSections.tsx 74.52% <ø> (-1.20%) ⬇️
src/components/ThumbnailImage.tsx 67.74% <ø> (-19.36%) ⬇️
src/hooks/useStyleUtils.ts 50.00% <ø> (ø)
...es/utils/getReceiptContainerStyles/index.native.ts 100.00% <100.00%> (ø)
src/styles/utils/index.ts 38.42% <ø> (-8.53%) ⬇️
src/components/MenuItem.tsx 83.58% <0.00%> (-2.50%) ⬇️
src/libs/TransactionUtils/index.ts 68.82% <87.50%> (-0.30%) ⬇️
... and 3 more
... and 205 files with indirect coverage changes

@mkzie2 mkzie2 marked this pull request as ready for review October 7, 2025 15:56
@mkzie2 mkzie2 requested review from a team as code owners October 7, 2025 15:56
@melvin-bot melvin-bot bot requested review from allroundexperts and removed request for a team October 7, 2025 15:56
@melvin-bot
Copy link

melvin-bot bot commented Oct 7, 2025

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@shawnborton
Copy link
Contributor

Is this ready for some test builds?

@shawnborton
Copy link
Contributor

For this screen here:
CleanShot 2025-10-07 at 18 23 08@2x

The idea was to use flex to just make the receipt area take up as much possible space without needing to scroll. Then when we actually click on "View more" we would use a fixed receipt height that is shorter.

CleanShot.2025-10-07.at.18.24.12.mp4

@shawnborton
Copy link
Contributor

When you select "Show more" I think the idea was to get rid of the little tip/message about things being filled out automatically:
CleanShot 2025-10-07 at 18 25 09@2x

@puneetlath
Copy link
Contributor

@mkzie2 any updates?

@mkzie2
Copy link
Contributor Author

mkzie2 commented Oct 15, 2025

Sorry for the delay. It is little bit tricky, I'm trying to find the solution and finalize the PR today

@JmillsExpensify
Copy link
Contributor

Yes, please prioritize this one over other PRs. We're doing a monthly product update next week and we'd like to include a demo of this as part of the release.

@mkzie2
Copy link
Contributor Author

mkzie2 commented Oct 15, 2025

FYI: I have fixed the auto height issue in desktop, web. However, there is another issue in native device. I'm trying to fix it now

@JmillsExpensify
Copy link
Contributor

Can we plan on getting this into review tomorrow, including the test builds?

@JmillsExpensify
Copy link
Contributor

Is this ready for C+ review?

@allroundexperts
Copy link
Contributor

@Expensify/design Is this looking good from your perspective?

@allroundexperts
Copy link
Contributor

@puneetlath Can you please trigger the adhoc builds?

@github-actions
Copy link
Contributor

🚧 @puneetlath has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions
Copy link
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #72002.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/72002/index.html ❌ FAILED ❌
Android The QR code can't be generated, because the iOS build failed
Desktop 💻 Web 🕸️
❌ FAILED ❌ https://72002.pr-testing.expensify.com
The QR code can't be generated, because the Desktop build failed Web

👀 View the workflow run that generated this build 👀

@dubielzyk-expensify
Copy link
Contributor

For landscape receipts the thumbnail isn't fully covered:

CleanShot 2025-10-23 at 09 54 37@2x

@dubielzyk-expensify
Copy link
Contributor

Is there a way to make the transition from tall receipt to small receipt smoother with an animation? It's a bit jarring at the moment:

CleanShot.2025-10-23.at.09.57.21.mp4

@dubielzyk-expensify
Copy link
Contributor

Otherwise this is looking pretty sweet already 😄 cc @dannymcclain for extra eyes

@dannymcclain
Copy link
Contributor

Is there a way to make the transition from tall receipt to small receipt smoother with an animation? It's a bit jarring at the moment:

Big agree with this! It doesn't need to be anything fancy either IMO, just a simple ease would do wonders here.

@dannymcclain
Copy link
Contributor

Looks like my portrait receipt isn't filling properly either:
CleanShot 2025-10-23 at 08 45 31@2x

And like I mentioned above, I agree with Jon about the transition. But other than that it's looking pretty sweet.

@allroundexperts
Copy link
Contributor

@mkzie2 Can you please resolve the comments?

@mkzie2
Copy link
Contributor Author

mkzie2 commented Oct 27, 2025

I've just resolved the image height issue and add transition animation. Please help check if it is matched with you expectation

Screen.Recording.2025-10-27.at.18.25.43.mov
Screen.Recording.2025-10-27.at.18.26.14.mov

@mkzie2
Copy link
Contributor Author

mkzie2 commented Oct 27, 2025

Test failure is not related to this PR, it is a known issue

@dannymcclain
Copy link
Contributor

I've just resolved the image height issue and add transition animation.

Can we make it to where all the elements move together at the same pace? Ideally this should feel like the entire bottom UI is just sliding up in unison.

@dubielzyk-expensify
Copy link
Contributor

dubielzyk-expensify commented Oct 27, 2025

Agree. This feels a quite janky , but the idea is there

CleanShot.2025-10-28.at.09.29.23.mp4

@mkzie2 mkzie2 requested a review from a team as a code owner November 12, 2025 10:54
@melvin-bot
Copy link

melvin-bot bot commented Nov 12, 2025

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@melvin-bot melvin-bot bot requested review from JmillsExpensify and removed request for a team November 12, 2025 10:54
@puneetlath
Copy link
Contributor

@mkzie2 what's the status of this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants