Split expense flow (Phase 2 - Reverting existing split expenses) #72086

ZhenjaHorbach · 2025-10-08T12:03:06Z

Split expense flow (Phase 2 - Reverting existing split expenses)

Explanation of Change

Fixed Issues

$ #61029

PROPOSAL: NA

Tests

Enable newDotRevertSplits beta
Navigate to an eligible expense in your reports or expenses list.
Open the More menu.
Click the Split button.
Save the splits.
Open the created split transaction.
Click the Edit splits button in More menu or click the amount to open the split screen.
Remove the splits to leave one.
Verify that the split has been reverted correctly and the current split works as a default expense

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Enable newDotRevertSplits beta
Navigate to an eligible expense in your reports or expenses list.
Open the More menu.
Click the Split button.
Save the splits.
Open the created split transaction.
Click the Edit splits button in More menu or click the amount to open the split screen.
Remove the splits to leave one.
Verify that the split has been reverted correctly and the current split works as a default expense

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

2025-09-29.16.52.42.mov

Android: mWeb Chrome

2025-09-29.16.52.42.mov

iOS: Native

2025-09-29.16.52.42.mov

iOS: mWeb Safari

2025-09-29.16.52.42.mov

MacOS: Chrome / Safari

2025-09-29.16.52.42.mov

MacOS: Desktop

2025-09-29.16.52.42.mov

melvin-bot · 2025-10-08T12:06:42Z

@eh2077 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

lakchote · 2025-10-08T12:10:07Z

@eh2077 this is a very high priority one, as we want the splits feature to be live next week.

eh2077 · 2025-10-08T12:14:35Z

Got it, reviewing it!

codecov · 2025-10-08T12:23:20Z

Codecov Report

❌ Patch coverage is 33.10811% with 99 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/hooks/useDeleteTransactions.ts	15.62%	54 Missing ⚠️
src/libs/actions/IOU.ts	70.00%	12 Missing ⚠️
src/pages/iou/SplitExpensePage.tsx	0.00%	7 Missing ⚠️
src/components/MoneyReportHeader.tsx	0.00%	6 Missing ⚠️
src/components/MoneyRequestHeader.tsx	0.00%	6 Missing ⚠️
...c/components/ReportActionItem/MoneyRequestView.tsx	0.00%	4 Missing ⚠️
src/hooks/useSelectedTransactionsActions.ts	0.00%	4 Missing ⚠️
...ort/ContextMenu/PopoverReportActionContextMenu.tsx	50.00%	4 Missing ⚠️
src/pages/ReportDetailsPage.tsx	60.00%	2 Missing ⚠️

Files with missing lines	Coverage Δ
src/libs/API/types.ts	`100.00% <ø> (ø)`
src/libs/TransactionUtils/index.ts	`68.43% <100.00%> (ø)`
src/pages/ReportDetailsPage.tsx	`58.82% <60.00%> (+0.36%)`	⬆️
...c/components/ReportActionItem/MoneyRequestView.tsx	`0.28% <0.00%> (-0.01%)`	⬇️
src/hooks/useSelectedTransactionsActions.ts	`3.22% <0.00%> (+0.42%)`	⬆️
...ort/ContextMenu/PopoverReportActionContextMenu.tsx	`40.10% <50.00%> (+1.27%)`	⬆️
src/components/MoneyReportHeader.tsx	`0.18% <0.00%> (-0.01%)`	⬇️
src/components/MoneyRequestHeader.tsx	`0.61% <0.00%> (-0.02%)`	⬇️
src/pages/iou/SplitExpensePage.tsx	`0.00% <0.00%> (ø)`
src/libs/actions/IOU.ts	`63.67% <70.00%> (+<0.01%)`	⬆️
... and 1 more

... and 14 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

eh2077 · 2025-10-08T15:25:45Z

Is BE ready? I'm using staging server and the RevertSplitTransaction command returned error

Screen.Recording.2025-10-08.at.11.21.31.PM.mov

eh2077 · 2025-10-08T16:08:27Z

Bug: Get one split after deleting the other split

create an expense
split expense
open a split expense
click secondary delete button to delete a split expense
the remain split expense is not reverted

Screen.Recording.2025-10-08.at.11.59.10.PM.mov

eh2077 · 2025-10-08T16:10:42Z

Bug: Offline - distance splits - system message contains pending keyword after reverting

Screen.Recording.2025-10-09.at.12.08.04.AM.mov

ZhenjaHorbach · 2025-10-08T16:20:23Z

Is BE ready? I'm using staging server and the RevertSplitTransaction command returned error

Screen.Recording.2025-10-08.at.11.21.31.PM.mov

Strange
Everything works for me
But actually staging server is enabled for me
Maybe that's the reason

ZhenjaHorbach · 2025-10-08T16:20:57Z

Bug: Get one split after deleting the other split

create an expense

split expense

open a split expense

click secondary delete button to delete a split expense

the remain split expense is not reverted

Screen.Recording.2025-10-08.at.11.59.10.PM.mov

Oh
Yeah
I suppose we need to call the save split function here also

ZhenjaHorbach · 2025-10-08T16:22:32Z

Bug: Offline - distance splits - system message contains pending keyword after reverting

Screen.Recording.2025-10-09.at.12.08.04.AM.mov

Fixed !

eh2077 · 2025-10-08T16:24:48Z

Bug: comments of the original expense isn't shown under the split table (they're in the same report ID)

create an expense
add a comment in the expense thread
split expense
the comment is not shown under the split table but the parent report preview action indicates the comment exists

After reverting splits, do we need to show comments of the original expense?

Screen.Recording.2025-10-09.at.12.18.12.AM.mov

eh2077

Code looks good so far, just a comment about TS types.

src/libs/API/parameters/SplitTransactionParams.ts

eh2077 · 2025-10-08T16:29:08Z

Is BE ready? I'm using staging server and the RevertSplitTransaction command returned error
Screen.Recording.2025-10-08.at.11.21.31.PM.mov

Strange Everything works for me But actually staging server is enabled for me Maybe that's the reason

Hmm, so that means my account ericwdev001+63738c@gmail.com needs to be whitelist in BE, right? cc @lakchote

ZhenjaHorbach · 2025-10-08T16:31:05Z

Bug: comments of the original expense isn't shown under the split table (they're in the same report ID)

create an expense

add a comment in the expense thread

split expense

the comment is not shown under the split table but the parent report preview action indicates the comment exists

After reverting splits, do we need to show comments of the original expense?

Screen.Recording.2025-10-09.at.12.18.12.AM.mov

Actually good question
I suppose it's because we still have the invisible original transaction, which we don't show in the report (but still have report actions from this transaction)

ZhenjaHorbach · 2025-10-08T16:31:41Z

Is BE ready? I'm using staging server and the RevertSplitTransaction command returned error
Screen.Recording.2025-10-08.at.11.21.31.PM.mov

Strange Everything works for me But actually staging server is enabled for me Maybe that's the reason

Hmm, so that means my account ericwdev001+63738c@gmail.com needs to be whitelist in BE, right? cc @lakchote

I don't think so
I didn't give my email to anyone

ZhenjaHorbach · 2025-10-09T07:49:49Z

Is BE ready? I'm using staging server and the RevertSplitTransaction command returned error

Screen.Recording.2025-10-08.at.11.21.31.PM.mov

About this
Sorry for confusing
If we don't pass a comment or category (which are optional), BE returns an error
But this will be fixed soon from BE side

…m/ZhenjaHorbach/App into split-expense-flow-phase-2-revert

lakchote · 2025-10-22T14:06:59Z

@ZhenjaHorbach there are conflicts and lint failing, let's push this one to the finish line!

lakchote · 2025-10-23T09:09:26Z

The eslint check failing is unrelated to this PR, see https://expensify.slack.com/archives/C01GTK53T8Q/p1761207966046699

melvin-bot · 2025-10-23T09:09:28Z

@lakchote looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

lakchote · 2025-10-23T09:09:40Z

Not an emergency, see #72086 (comment)

izarutskaya · 2025-10-23T13:05:36Z

Hi @ZhenjaHorbach

Enable newDotRevertSplits beta

Can we check testing this PR with Expensifail accounts or we need some specific settings?

OSBotify · 2025-10-23T13:09:08Z

🚀 Deployed to staging by https://github.com/lakchote in version: 9.2.37-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

ZhenjaHorbach · 2025-10-23T13:09:13Z

Hi @ZhenjaHorbach

Enable newDotRevertSplits beta

Can we check testing this PR with Expensifail accounts or we need some specific settings?

As far as I know, Expensifail accounts always have all betas enabled
If yes
Then you can test on Expensifail accounts without specific settings!

aldo-expensify · 2025-10-23T23:12:31Z

src/pages/ReportDetailsPage.tsx

-        } else {
-            deleteMoneyRequest(
-                iouTransactionID,
-                requestParentReportAction,
-                duplicateTransactions,
-                duplicateTransactionViolations,
-                iouReport,
-                chatIOUReport,
-                isChatIOUReportArchived,
-                isSingleTransactionView,
-            );
+        } else if (iouTransactionID) {
+            deleteTransactions([iouTransactionID], duplicateTransactions, duplicateTransactionViolations, currentSearchHash, isSingleTransactionView);


@ZhenjaHorbach Could these changes be causing #73330 ?

I'm reverting these here https://github.com/Expensify/App/pull/73379/files and it seems to fix the issue

Honestly, I never would have thought it was related to this PR
Because the issue is the broken navigation, which we didn't change
But I will try to fix !

izarutskaya · 2025-10-24T08:04:24Z

@ZhenjaHorbach PR is failing only on Desktop, iOS with #73383

ZhenjaHorbach · 2025-10-24T08:50:08Z

@ZhenjaHorbach PR is failing only on Desktop, iOS with #73383

Thanks for testing!

Looks like a BE issue
But I will try to find the root cause

OSBotify · 2025-10-24T17:51:19Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.2.37-8 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Add new command for revert and update getChildTransactions

45d8d87

melvin-bot bot assigned ZhenjaHorbach Oct 8, 2025

ZhenjaHorbach marked this pull request as ready for review October 8, 2025 12:06

ZhenjaHorbach requested a review from a team as a code owner October 8, 2025 12:06

melvin-bot bot requested a review from eh2077 October 8, 2025 12:06

melvin-bot bot removed the request for review from a team October 8, 2025 12:06

lakchote self-requested a review October 8, 2025 12:08

Fix prettier issues

de9466e

eh2077 reviewed Oct 8, 2025

View reviewed changes

src/libs/API/parameters/SplitTransactionParams.ts Outdated Show resolved Hide resolved

ZhenjaHorbach mentioned this pull request Oct 9, 2025

Split expense flow (Phase 2 - Editing existing split expenses) #63738

Merged

54 tasks

ZhenjaHorbach added 5 commits October 9, 2025 12:52

Fix bugs

ed5fedc

Refactor updateSplitTransactions to reuse in other places

82de263

Fix eslint issues

7696de2

Fix eslint issues

0d589a7

Merge branch 'split-expense-flow-phase-2-revert' of https://github.co…

fb0d171

…m/ZhenjaHorbach/App into split-expense-flow-phase-2-revert

ZhenjaHorbach added 4 commits October 22, 2025 16:40

Fix conflicts

bb9b043

Fix conflicts

1312104

Fix prettier issues

47e4f57

Fix conflicts

2a5cb83

lakchote previously approved these changes Oct 23, 2025

View reviewed changes

Fix conflicts

3561bee

ZhenjaHorbach dismissed lakchote’s stale review via 3561bee October 23, 2025 08:28

lakchote approved these changes Oct 23, 2025

View reviewed changes

lakchote merged commit 8c11c1e into Expensify:main Oct 23, 2025
24 of 25 checks passed

melvin-bot bot added the Emergency label Oct 23, 2025

lakchote removed the Emergency label Oct 23, 2025

lakchote mentioned this pull request Oct 23, 2025

Expense - Expense report show duplicate previews of the remaining split after deleting split #73295

Closed

8 tasks

OSBotify mentioned this pull request Oct 23, 2025

Deploy Checklist: New Expensify 2025-10-23 #73307

Closed

88 tasks

aldo-expensify reviewed Oct 23, 2025

View reviewed changes

aldo-expensify mentioned this pull request Oct 23, 2025

[CP Staging] Partially revert PR related to expense flow #73379

Merged

54 tasks

This was referenced Oct 24, 2025

[Splits in NewDot] Expense - Expense report loads infinitely after removing split and reset app #73383

Closed

[$250] Expense - Remove hold option is missing for the last split after deleting all the splits #73384

Closed

jponikarchuk mentioned this pull request Oct 27, 2025

[$250] Expense - Expense preview appears twice after reverting split and editing amount #73573

Closed

8 tasks

eh2077 mentioned this pull request Nov 6, 2025

[Due for payment 2025-11-13] [Due for payment 2025-11-03] [Splits in NewDot] (Phase 2) Allow users to remove splits to revert to a regular expense #61029

Closed

nlemma mentioned this pull request Dec 11, 2025

[$250] Reports - Split is not reverted when split expense is deleted on Reports #77396

Open

8 tasks

Split expense flow (Phase 2 - Reverting existing split expenses) #72086

Split expense flow (Phase 2 - Reverting existing split expenses) #72086

Uh oh!

Conversation

ZhenjaHorbach commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Oct 8, 2025

Uh oh!

lakchote commented Oct 8, 2025

Uh oh!

eh2077 commented Oct 8, 2025

Uh oh!

codecov bot commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

eh2077 commented Oct 8, 2025

Uh oh!

eh2077 commented Oct 8, 2025

Uh oh!

eh2077 commented Oct 8, 2025

Uh oh!

ZhenjaHorbach commented Oct 8, 2025

Uh oh!

ZhenjaHorbach commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eh2077 commented Oct 8, 2025

Uh oh!

eh2077 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

eh2077 commented Oct 8, 2025

Uh oh!

ZhenjaHorbach commented Oct 8, 2025

Uh oh!

ZhenjaHorbach commented Oct 8, 2025

Uh oh!

ZhenjaHorbach commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lakchote commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

lakchote commented Oct 23, 2025

Uh oh!

melvin-bot bot commented Oct 23, 2025

Uh oh!

lakchote commented Oct 23, 2025

Uh oh!

izarutskaya commented Oct 23, 2025

Uh oh!

OSBotify commented Oct 23, 2025

Uh oh!

ZhenjaHorbach commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aldo-expensify Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

izarutskaya commented Oct 24, 2025

Uh oh!

ZhenjaHorbach commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ZhenjaHorbach commented Oct 8, 2025 •

edited

Loading

codecov bot commented Oct 8, 2025 •

edited

Loading

ZhenjaHorbach commented Oct 8, 2025 •

edited

Loading

ZhenjaHorbach commented Oct 8, 2025 •

edited

Loading

ZhenjaHorbach commented Oct 9, 2025 •

edited

Loading

lakchote commented Oct 22, 2025 •

edited

Loading

ZhenjaHorbach commented Oct 23, 2025 •

edited

Loading

ZhenjaHorbach commented Oct 24, 2025 •

edited

Loading