-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[CP Staging] Revert "Implement confirmation message when toggling off approvals" #72101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 8054eae7..b969c9ce 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -1106,7 +1106,7 @@ const translations = {
totalAmountGreaterThanOriginal: ({amount}: TotalAmountGreaterOrLessThanOriginalParams) => `Het totale bedrag is ${amount} meer dan de oorspronkelijke uitgave.`,
totalAmountLessThanOriginal: ({amount}: TotalAmountGreaterOrLessThanOriginalParams) => `Het totale bedrag is ${amount} minder dan de oorspronkelijke uitgave.`,
splitExpenseZeroAmount: 'Voer een geldig bedrag in voordat u doorgaat.',
- splitExpenseOneMoreSplit: 'Geen splitsing toegevoegd. Voeg er ten minste \u00E9\u00E9n toe om op te slaan.',
+ splitExpenseOneMoreSplit: 'Geen splitsing toegevoegd. Voeg er ten minste één toe om op te slaan.',
splitExpenseCannotBeEditedModalTitle: 'Deze uitgave kan niet worden bewerkt',
splitExpenseCannotBeEditedModalDescription: 'Goedgekeurde of betaalde uitgaven kunnen niet worden bewerkt',
splitExpenseEditTitle: ({amount, merchant}: SplitExpenseEditTitleParams) => `Bewerk ${amount} voor ${merchant}`,
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
mountiny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Straight revert, straight to jail
|
@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
Straight revert |
[CP Staging] Revert "Implement confirmation message when toggling off approvals" (cherry picked from commit c877625) (cherry-picked to staging by lakchote)
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.2.27-3 🚀
|
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.2.27-6 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.2.28-0 🚀
|
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.2.28-5 🚀
|
Reverts #71555
Fixes blocker #72087