Adds KYC Wall trigger for Transfer Balance action by marcaaron · Pull Request #7211 · Expensify/App

marcaaron · 2022-01-13T19:52:50Z

Details

Adds the KYC checks to attempts to transfer a balance
Fixes up the positioning of the "add payment method" popover

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/187802

Tests

Note: In order to simulate a user instantly passing Onfido + IDOlogy we need to take a few additional steps that are explained here.

Start with an account that has a gold wallet + payment method added i.e. able to "Send Money"
Send money to an account that does not have a gold wallet
As the recipient, navigate to the "Settings > Payments" screen and tap "Transfer Balance"
Verify that a popup appears asking you to add a "Bank account" or "Debit card"
Select Bank Account + add a test bank account
Verify you are navigated to the "Verify identity" flow next
Go through Onfido
Enter the required information in Additional details step (follow second answer here)
Verify that you are brought to the balance transfer page

Verify that no errors appear in the JS console

QA Steps

Internal QA ... maybe Production QA? Not sure if Onfido works on staging.

Tested On

Screenshots

Web

Mobile Web

Desktop

iOS

Android

nickmurray47

not able to test right now because of some Auth/VM issues but code LGTM too!

stitesExpensify · 2022-01-19T15:57:12Z

Will test and merge this morning

marcochavezf · 2022-01-19T19:06:39Z

I got this error in step 3:

I'm going to test again with a different account.

marcochavezf · 2022-01-19T19:38:06Z

Getting the same issue with another account with Gold wallet. Seems the userWalletproperty is missing here:

App/src/pages/settings/Payments/TransferBalancePage.js

Lines 109 to 112 in c857f8b

    
           const paymentMethods = PaymentUtils.formatPaymentMethods( 
        
               this.props.bankAccountList, 
        
               this.props.cardList, 
        
           );

Because it's undefined in PaymentUtils.formatPaymentMethods:

marcaaron · 2022-01-19T19:39:08Z

Uh hmm,

App/src/pages/settings/Payments/TransferBalancePage.js

Lines 109 to 112 in a2f6349

    
           const paymentMethods = PaymentUtils.formatPaymentMethods( 
        
               this.props.bankAccountList, 
        
               this.props.cardList, 
        
           );

We are not passing it here

marcaaron · 2022-01-19T19:41:53Z

Pushed a change to fix this here. Gonna re-test myself (last time I checked I had no issues accessing).

marcaaron · 2022-01-19T20:53:29Z

Hmm, I'm really confused why this is not working all of a sudden... the data is there

I have a feeling this is related to the IndexedDB change...

marcaaron · 2022-01-19T22:06:01Z

Ok it took me way too long to figure out that we need to pass a paypal me name to the formatPaymentMethods() method 😂

The SvgChase() error + propTypes were unrelated, but also fixing them here to avoid future confusion.

marcaaron · 2022-01-19T22:06:22Z

Updated.

marcochavezf · 2022-01-20T17:06:10Z

src/pages/settings/Payments/TransferBalancePage.js

@@ -30,7 +30,7 @@ const propTypes = {
    userWallet: userWalletPropTypes.userWallet,

    /** Array of bank account objects */


NAB: Ah I think we should update that this is no longer an array but an object, no?

marcochavezf · 2022-01-20T17:10:45Z

src/pages/settings/Payments/TransferBalancePage.js

@@ -45,7 +45,7 @@ const propTypes = {
    })),

    /** Array of card objects */


NAB: Same here? Which can be an Object (or Dictionary) of card objects?

marcaaron · 2022-01-20T17:19:25Z

Updated.

marcochavezf · 2022-01-20T17:43:18Z

The Transfer Balance page is working fine now :D but for some reason I'm stuck in step 5; the button Instant (Debit Card) is selected but the Transfer button is disabled also I can't select the other option 1-3 Business Days (Bank Account)

Screen.Recording.2022-01-20.at.11.33.28.mov

marcaaron · 2022-01-20T18:07:36Z

for some reason I'm stuck in step 5; the button Instant (Debit Card) is selected but the Transfer button is disabled also I can't select the other option 1-3 Business Days (Bank Account)

Which step 5? The QA for this PR is to just make sure you can get to the "Transfer Balance" page and looks like you were able to do it :)

marcaaron · 2022-01-20T18:08:10Z

I'll add some pics to show what I'm looking for here.

marcaaron · 2022-01-20T19:44:59Z

Just tested the flow again and added screenshots. @marcochavezf let me know if everything looks good to you!

marcochavezf · 2022-01-20T20:19:22Z

Oh I see, thanks! I was using an account that was skipping the "Verify identity" step

stitesExpensify

Nice!

OSBotify · 2022-01-20T20:55:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-01-21T00:59:59Z

🚀 Deployed to staging by @stitesExpensify in version: 1.1.31-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mvtglobally · 2022-01-22T15:45:23Z

@marcaaron @marcochavezf @nickmurray47 @stitesExpensify This PR is ready to QA internally

marcaaron · 2022-01-24T20:17:12Z

Thanks, there is an issue where we can't access the production API so we will need to test this on production. This feature is still behind a beta so we can check this off I think.

#7371

OSBotify · 2022-01-25T19:46:59Z

🚀 Deployed to production by @AndrewGable in version: 1.1.32-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Fix up popover placements

b1984f0

marcaaron self-assigned this Jan 13, 2022

marcaaron added 2 commits January 18, 2022 09:39

Merge

bdd4dc3

add paddingRight style to paypal button

c857f8b

marcaaron marked this pull request as ready for review January 18, 2022 20:04

marcaaron requested a review from a team as a code owner January 18, 2022 20:04

marcaaron changed the title ~~[WIP] Adds KYC Wall trigger for Transfer Balance action~~ Adds KYC Wall trigger for Transfer Balance action Jan 18, 2022

MelvinBot requested review from marcochavezf and removed request for a team January 18, 2022 20:04

stitesExpensify previously approved these changes Jan 19, 2022

View reviewed changes

nickmurray47 previously approved these changes Jan 19, 2022

View reviewed changes

marcaaron added 2 commits January 19, 2022 09:39

Merge remote-tracking branch 'origin' into marcaaron-transferBalanceKYC

02d52cd

Add userWallet to formatPaymentMethods

4f77c4c

marcaaron dismissed stale reviews from nickmurray47 and stitesExpensify via 4f77c4c January 19, 2022 19:40

fix various things

d49c4a4

marcochavezf reviewed Jan 20, 2022

View reviewed changes

marcaaron added 2 commits January 20, 2022 07:17

Update propTypes

c9cdedf

fix conflicts

3d1a7ee

marcochavezf approved these changes Jan 20, 2022

View reviewed changes

stitesExpensify approved these changes Jan 20, 2022

View reviewed changes

stitesExpensify merged commit 5ae1d91 into main Jan 20, 2022

stitesExpensify deleted the marcaaron-transferBalanceKYC branch January 20, 2022 20:54

OSBotify mentioned this pull request Jan 20, 2022

Deploy Checklist: New Expensify 2022-01-20 #7347

Closed

33 tasks

		@@ -30,7 +30,7 @@ const propTypes = {
		userWallet: userWalletPropTypes.userWallet,

		/** Array of bank account objects */

		@@ -45,7 +45,7 @@ const propTypes = {
		})),

		/** Array of card objects */

Conversation

marcaaron commented Jan 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

QA Steps

Tested On

Screenshots

Web

Mobile Web

Desktop

iOS

Android

Uh oh!

nickmurray47 left a comment

Choose a reason for hiding this comment

Uh oh!

stitesExpensify commented Jan 19, 2022

Uh oh!

marcochavezf commented Jan 19, 2022

Uh oh!

marcochavezf commented Jan 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marcaaron commented Jan 19, 2022

Uh oh!

marcaaron commented Jan 19, 2022

Uh oh!

marcaaron commented Jan 19, 2022

Uh oh!

marcaaron commented Jan 19, 2022

Uh oh!

marcaaron commented Jan 19, 2022

Uh oh!

marcochavezf Jan 20, 2022

Choose a reason for hiding this comment

Uh oh!

marcochavezf Jan 20, 2022

Choose a reason for hiding this comment

Uh oh!

marcaaron commented Jan 20, 2022

Uh oh!

marcochavezf commented Jan 20, 2022

Uh oh!

marcaaron commented Jan 20, 2022

Uh oh!

marcaaron commented Jan 20, 2022

Uh oh!

marcaaron commented Jan 20, 2022

Uh oh!

marcochavezf commented Jan 20, 2022

Uh oh!

stitesExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jan 20, 2022

Uh oh!

OSBotify commented Jan 21, 2022

Uh oh!

mvtglobally commented Jan 22, 2022

Uh oh!

marcaaron commented Jan 24, 2022

Uh oh!

OSBotify commented Jan 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

marcaaron commented Jan 13, 2022 •

edited

Loading

marcochavezf commented Jan 19, 2022 •

edited

Loading