Merged
Conversation
robertjchen
changed the title
Contributor
danieldoglas
left a comment
danieldoglas
left a comment
There was a problem hiding this comment.
Code LGTM, but maybe we should have printscreens of Android and desktop too?
Contributor
Author
|
@danieldoglas Yep, screenshots added! |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
33 tasks
Contributor
|
🚀 Deployed to staging by @danieldoglas in version: 1.1.31-2 🚀
|
Contributor
|
🚀 Deployed to production by @AndrewGable in version: 1.1.32-0 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Thanks for the review! Let's hide the name/date header of messages when in edit mode. This reduces UI clutter and jerky transitions, and brings this behavior in-line with other popular chat clients. #design-approved ✅
Before
After
Fixed Issues
$ #6901
Tests / QA Steps
Tested On
iOS Screenshot
Android Screenshot
Desktop Screenshot