[No QA] Remove react-native-community/cli as a hardcoded dependency #7246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Following up on @kidroca's advice here, this PR removes
@react-native-community/clias an explicit dependency – instead we'll let it be a transitive dependency of RN (properly upgraded now).This PR also adds
@react-native-community/cli-toolsas an explicit dev dependency because it's used directly in our code.Fixed Issues
$ n/a
Tests
npm run clean && npm i && cd ios && pod install && cd ..QA Steps
None.
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android