You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hmm good point, I guess previously, the changes in Expensify/react-native-web@5548f3a were only comment changes, so no big deal that the last commit wasn't set in E/App
Hmm I think it's best if you can link all of the GH issues this will fix, because we have some automation that goes through merged PRs per release, finds all issues linked to PRs, and comments on them with the PR that is fixing said issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
numberOfLines={1}react-native-web#5I just found out that we were not using the latest commit from our RN-web fork. Any specific reason.

Fixed Issues
$ #7206
$ #6913
Tests | ### QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android