Skip to content

Upgrade RN-web#7254

Merged
Beamanator merged 1 commit intoExpensify:mainfrom
parasharrajat:rnw-upgrade
Jan 17, 2022
Merged

Upgrade RN-web#7254
Beamanator merged 1 commit intoExpensify:mainfrom
parasharrajat:rnw-upgrade

Conversation

@parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Jan 15, 2022

Details

  1. Submitted a new PR to our RN-web fork Fix ellipsis issues for Text numberOfLines={1} react-native-web#5

I just found out that we were not using the latest commit from our RN-web fork. Any specific reason.
ll

Fixed Issues

$ #7206
$ #6913

Tests | ### QA Steps

  1. Test all the listed issues on the linked issue.
  2. Test that ellipsis are shown correctly on LHN when chat title length exceeds the width of LHN.
  3. Check the same for Search page.
  4. Check that Ellipsis are shown near the RIght edge of the screen. And does not start from the middle of the screen.
  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

Mobile Web

Desktop

iOS

Android

@Beamanator
Copy link
Contributor

Hmm good point, I guess previously, the changes in Expensify/react-native-web@5548f3a were only comment changes, so no big deal that the last commit wasn't set in E/App

@Beamanator Beamanator self-requested a review January 17, 2022 08:54
@Beamanator Beamanator merged commit 738d913 into Expensify:main Jan 17, 2022
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@Beamanator
Copy link
Contributor

@parasharrajat I think you should also mention that this PR fixes #6913

@parasharrajat
Copy link
Member Author

Updated. Actually, this fixes many issues so I thought of only referencing the Tracking issue.

@Beamanator
Copy link
Contributor

Hmm I think it's best if you can link all of the GH issues this will fix, because we have some automation that goes through merged PRs per release, finds all issues linked to PRs, and comments on them with the PR that is fixing said issue

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Beamanator in version: 1.1.30-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @chiragsalian in version: 1.1.31-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants