remove remaining inline selectors by TMisiukiewicz · Pull Request #72546 · Expensify/App

TMisiukiewicz · 2025-10-14T08:46:52Z

Explanation of Change

Migrating the remaining inline selectors to stable selectors. They were most likely accidentally missed during migration or created while the migration was ongoing.

Fixed Issues

$ #70272
PROPOSAL:

Tests

Open app
Verify the app loads properly

Verify that no errors appear in the JS console

Offline tests

n/a

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

iOS: Native

ios.mov

iOS: mWeb Safari

ios.web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2025-10-14T08:46:59Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2025-10-14T08:57:53Z

Codecov Report

❌ Patch coverage is 41.26984% with 37 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/selectors/Policy.ts	12.50%	7 Missing ⚠️
src/pages/NewReportWorkspaceSelectionPage.tsx	0.00%	5 Missing ⚠️
src/pages/TransactionMerge/DetailsReviewPage.tsx	0.00%	4 Missing ⚠️
src/pages/ReportChangeWorkspacePage.tsx	0.00%	3 Missing ⚠️
src/selectors/ReportNameValuePairs.ts	62.50%	3 Missing ⚠️
...e/SearchFiltersReportFieldPage/ReportFieldList.tsx	0.00%	2 Missing ⚠️
...chAdvancedFiltersPage/SearchFiltersTaxRatePage.tsx	0.00%	2 Missing ⚠️
...pages/home/report/ReportActionItemParentAction.tsx	0.00%	2 Missing ⚠️
src/selectors/Onboarding.ts	0.00%	2 Missing ⚠️
...c/components/Navigation/NavigationTabBar/index.tsx	80.00%	1 Missing ⚠️
... and 6 more

Files with missing lines	Coverage Δ
src/components/MigratedUserWelcomeModal.tsx	`9.09% <ø> (ø)`
src/components/ProductTrainingContext/index.tsx	`91.66% <ø> (+28.33%)`	⬆️
...components/SelectionList/ListItem/UserListItem.tsx	`4.54% <100.00%> (+2.21%)`	⬆️
src/components/TestDrive/TestDriveDemo.tsx	`7.69% <ø> (+1.02%)`	⬆️
src/hooks/useArchivedReportsIdSet.ts	`100.00% <ø> (+27.27%)`	⬆️
src/hooks/useIsPaidPolicyAdmin.ts	`100.00% <100.00%> (ø)`
src/hooks/useOnboardingFlow.ts	`82.35% <ø> (ø)`
src/hooks/useTransactionViolationOfWorkspace.tsx	`72.72% <100.00%> (+72.72%)`	⬆️
src/libs/Navigation/NavigationRoot.tsx	`79.38% <ø> (ø)`
src/pages/Search/EmptySearchView.tsx	`80.89% <ø> (+80.89%)`	⬆️
... and 18 more

... and 342 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

dukenv0307 · 2025-10-15T14:49:45Z

3 more places

App/src/hooks/usePersonalPolicy.ts

Line 19 in d057ac4

    
           const [allPolicies] = useOnyx(ONYXKEYS.COLLECTION.POLICY, {selector: (c) => mapOnyxCollectionItems(c, policySelector), canBeMissing: true});

App/src/components/FloatingCameraButton.tsx

Line 37 in d057ac4

const [policyChatForActivePolicy] = useOnyx(ONYXKEYS.COLLECTION.REPORT, {

App/src/components/SelectionList/ListItem/UserListItem.tsx

Line 59 in d057ac4

selector: (report) => !!report,

dukenv0307 · 2025-10-15T14:51:33Z

src/hooks/useTransactionViolationOfWorkspace.tsx

        }
    });
+
+    const transactionViolationSelector = (violations: OnyxCollection<TransactionViolations>) => {


let's use useCallback

dukenv0307 · 2025-10-15T14:52:20Z

src/selectors/Onboarding.ts

+ * `true` means the onboarding flow is loading
+ * `false` means the onboarding flow is not loading
+ */
+function isOnboardingLoadingSelector(onboarding: OnyxValue<typeof ONYXKEYS.NVP_ONBOARDING>): boolean | undefined {


why don't we move it to selectors folder?

Good call, I missed the fact that it's not there

…line-selectors

TMisiukiewicz · 2025-10-16T08:33:27Z

Updated ✅

…line-selectors

roryabraham

@TMisiukiewicz Can you please upgrade eslint-config-expensify to include the no-inline-useOnyx-selector rule we added in Expensify/eslint-config-expensify#160, now that the ESLint 9 upgrade is complete?

…line-selectors

github-actions · 2025-10-17T06:56:34Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

TMisiukiewicz · 2025-10-17T06:56:47Z

@roryabraham amazing! Bumped version to 2.0.92

dukenv0307 · 2025-10-17T08:37:23Z

@TMisiukiewicz Can you please fix the eslint check?

…line-selectors

TMisiukiewicz · 2025-10-30T07:58:52Z

Should be good now!

TMisiukiewicz · 2025-10-30T09:26:13Z

Looks like tests are flaky

dukenv0307 · 2025-11-03T03:00:36Z

@TMisiukiewicz we got the conflict, can you please merge main?

…line-selectors

TMisiukiewicz · 2025-11-03T07:31:10Z

done

…line-selectors

JmillsExpensify

No product pr review required

carlosmiceli · 2025-11-04T14:44:07Z

@TMisiukiewicz lint errors this time 🙇

gelocraft · 2025-11-04T20:49:00Z

@TMisiukiewicz lint errors this time 🙇

@TMisiukiewicz lint error happens because the number of warnings exceeds the limit of 131.

you can fix this by increasing the maximum warnings threshold in package.json lint script.

gelocraft · 2025-11-04T20:53:24Z

I hope this PR gets merged today 🥺

…line-selectors

TMisiukiewicz · 2025-11-05T16:21:39Z

Resolved conflicts again

carlosmiceli · 2025-11-05T16:58:58Z

All yours @roryabraham

TMisiukiewicz · 2025-11-05T17:05:51Z

Praying for a merge before conflict happens... 🤣

OSBotify · 2025-11-06T23:50:58Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.46-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-11-07T23:31:05Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.46-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

TMisiukiewicz added 6 commits October 14, 2025 09:07

replace existing selectors

bccb1e7

update policies selectors

0a0823b

report action transactions

9d26f1f

personal details selector

0e376d8

report name value pairs selectors

288b19b

transactions selectors

d8c65fa

TMisiukiewicz requested a review from a team as a code owner October 14, 2025 08:46

melvin-bot bot assigned TMisiukiewicz Oct 14, 2025

melvin-bot bot requested review from dukenv0307 and removed request for a team October 14, 2025 08:46

TMisiukiewicz mentioned this pull request Oct 14, 2025

[Due for payment 2025-11-14] [$1250] Forbid inline useOnyx selectors #70272

Closed

dukenv0307 reviewed Oct 15, 2025

View reviewed changes

TMisiukiewicz added 3 commits October 16, 2025 10:07

Merge remote-tracking branch 'upstream/main' into remove-remaining-in…

ca52070

…line-selectors

move onboarding selectors to folder

35132d2

update remaining inline selectors

825003b

Merge remote-tracking branch 'upstream/main' into remove-remaining-in…

bc81cfe

…line-selectors

roryabraham requested changes Oct 16, 2025

View reviewed changes

Merge remote-tracking branch 'upstream/main' into remove-remaining-in…

cac727c

…line-selectors

TMisiukiewicz requested a review from roryabraham October 17, 2025 07:00

bump eslint-config-expensify to 2.0.92

6133146

TMisiukiewicz force-pushed the remove-remaining-inline-selectors branch from 2e64e20 to 6133146 Compare October 17, 2025 07:01

use useCallback for selector

e4985c4

Merge remote-tracking branch 'upstream/main' into remove-remaining-in…

47ef090

…line-selectors

TMisiukiewicz dismissed stale reviews from carlosmiceli and roryabraham via 47ef090 October 30, 2025 07:58

Merge remote-tracking branch 'upstream/main' into remove-remaining-in…

eabdd33

…line-selectors

TMisiukiewicz added 2 commits November 3, 2025 08:50

fix lint

8be1710

Merge remote-tracking branch 'upstream/main' into remove-remaining-in…

7485fde

…line-selectors

TMisiukiewicz requested a review from a team as a code owner November 4, 2025 06:47

melvin-bot bot requested review from JmillsExpensify and removed request for a team November 4, 2025 06:47

sobitneupane mentioned this pull request Nov 4, 2025

chore (eslint-config-expensify): enforce to use .find or .findLast instead of .filter #73284

Merged

54 tasks

JmillsExpensify reviewed Nov 4, 2025

View reviewed changes

TMisiukiewicz added 3 commits November 5, 2025 10:10

Merge branch 'main' into remove-remaining-inline-selectors

7682ecc

remove inline selector

65b7a30

Merge remote-tracking branch 'upstream/main' into remove-remaining-in…

7b0694f

…line-selectors

carlosmiceli approved these changes Nov 5, 2025

View reviewed changes

mountiny merged commit 47fdef9 into Expensify:main Nov 5, 2025
33 checks passed

github-actions bot mentioned this pull request Nov 5, 2025

[Due for payment 2025-12-10] [$125] Investigate workflow job failing on main: test / test (job 2) #74380

Closed

OSBotify mentioned this pull request Nov 6, 2025

Deploy Checklist: New Expensify 2025-11-06 #74515

Closed

64 tasks

Conversation

TMisiukiewicz commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Oct 14, 2025

Uh oh!

codecov bot commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dukenv0307 commented Oct 15, 2025

Uh oh!

dukenv0307 Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

TMisiukiewicz Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

TMisiukiewicz commented Oct 16, 2025

Uh oh!

roryabraham left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 17, 2025

Uh oh!

TMisiukiewicz commented Oct 17, 2025

Uh oh!

dukenv0307 commented Oct 17, 2025

Uh oh!

TMisiukiewicz commented Oct 30, 2025

Uh oh!

TMisiukiewicz commented Oct 30, 2025

Uh oh!

dukenv0307 commented Nov 3, 2025

Uh oh!

TMisiukiewicz commented Nov 3, 2025

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

carlosmiceli commented Nov 4, 2025

Uh oh!

gelocraft commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gelocraft commented Nov 4, 2025

Uh oh!

TMisiukiewicz commented Nov 5, 2025

Uh oh!

carlosmiceli commented Nov 5, 2025

Uh oh!

TMisiukiewicz commented Nov 5, 2025

Uh oh!

Uh oh!

OSBotify commented Nov 6, 2025

Uh oh!

OSBotify commented Nov 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

TMisiukiewicz commented Oct 14, 2025 •

edited

Loading

codecov bot commented Oct 14, 2025 •

edited

Loading

gelocraft commented Nov 4, 2025 •

edited

Loading