[No QA] fix: Fixed error with frequently used emojis not showing up

[mananjadhav]

Details

• When working with Fix: Added emoji category translations #7125 we changed the logic for dynamic spacing. A bug was introduced where Frequently Used Emojis stopped showing up and this PR fixes it.

Fixed Issues

$ #7074

Tests

1. Tested frequently used emojis in the EmojiPicker

• Verify that no errors appear in the JS console

QA Steps

• Verify that no errors appear in the JS console

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

[mananjadhav]

@stitesExpensify @parasharrajat @rushatgabhane When working with the last EmojiPicker PR, I introduced a bug where frequently used emojis stopped showing up. Adding a fix for this and I am hoping if this can be CPed to staging.

[rushatgabhane]

Thanks for noticing and pushing the fix!
Small change requested

[mananjadhav]

PR updated

[rushatgabhane]

LGTM!
cc: @stitesExpensify

[stitesExpensify]

LGTM

[github-actions]

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[roryabraham]

Whoa, it seems like the CP label may not have worked here ... 🤔 I've never seen this so I'm going to investigate.

[roryabraham]

Okay, so here's what happened:

1. This pull request was merged before the CP Staging label was added, triggering this preDeploy.yml workflow run.
2. The merged pull request was fetched here and did not have the CP Staging label at the time. It therefore was not CP'd.
3. The CP Staging label was added at some point after the PR was already merged (and after it had been fetched in the preDeploy.yml workflow), which triggered a warnCPLabel.yml workflow run.

So two things here:

1. I am manually CPing this to staging here, so that's an easy fix.
2. There is a race condition afoot here, and it will be good to resolve to clarify this situation in the future. I've documented it along with a proposed solution here

[OSBotify]

🚀 Cherry-picked to staging by @roryabraham in version: 1.1.30-2 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by @roryabraham in version: 1.1.30-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅