Fix lag on the wide RHP modal opening animation by WojtekBoman · Pull Request #72580 · Expensify/App

WojtekBoman · 2025-10-14T14:53:00Z

Explanation of Change

This PR fixes the following issues:

loading bar visible under overlay when RHP is visible,
performance when opening RHP in the reports tab (now the screen is preloaded before opening it)

Fixed Issues

$ #72314
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Verify if the animation when opening RHP in the Reports tab works better.
Verify if the loading bar under the overlay doesn't appear when opening RHP in the Reports tab.

Offline tests

QA Steps

Verify that no errors appear in the JS console

Verify if the animation when opening RHP in the Reports tab works better.
Verify if the loading bar under the overlay doesn't appear when opening RHP in the Reports tab.

PR Author Checklist

Screenshots/Videos

MacOS: Chrome / Safari

Screen.Recording.2025-10-22.at.09.38.44.mov

MacOS: Desktop

Screen.Recording.2025-10-22.at.09.47.43.mov

codecov · 2025-10-14T15:05:32Z

Codecov Report

❌ Patch coverage is 15.38462% with 11 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/components/WideRHPContextProvider/index.tsx	0.00%	6 Missing ⚠️
src/components/Search/openSearchReport/index.ts	0.00%	3 Missing ⚠️
...components/Search/openSearchReport/index.native.ts	0.00%	2 Missing ⚠️

Files with missing lines	Coverage Δ
...stReportView/MoneyRequestReportTransactionList.tsx	`4.21% <ø> (+1.74%)`	⬆️
src/components/Navigation/TopBar.tsx	`100.00% <100.00%> (ø)`
src/components/Search/index.tsx	`0.00% <ø> (ø)`
src/libs/SearchUIUtils.ts	`70.58% <100.00%> (+0.28%)`	⬆️
...components/Search/openSearchReport/index.native.ts	`0.00% <0.00%> (ø)`
src/components/Search/openSearchReport/index.ts	`0.00% <0.00%> (ø)`
src/components/WideRHPContextProvider/index.tsx	`0.00% <0.00%> (ø)`

... and 1446 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2025-10-17T12:10:28Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

dubielzyk-expensify · 2025-10-21T22:57:13Z

Definitely looking better, but not 60fps by any means. Happy to ship this though 👍

mountiny · 2025-10-21T23:12:53Z

Lets take it out of draft 🙌

melvin-bot · 2025-10-22T08:21:01Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny · 2025-10-22T12:15:32Z

@parasharrajat Are you able to prioritize this review in next 2 days given all the other tasks you are assigned?

github-actions · 2025-10-22T12:16:47Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

parasharrajat · 2025-10-22T12:40:44Z

yes. It will be done.

github-actions · 2025-10-22T12:41:32Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #72580.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/72580/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/72580/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/72580/NewExpensify.dmg	https://72580.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

parasharrajat

Does this PR handle the Expense report transaction list as well? We show Wide RHP on that page too and from the slack thead the bug was reported on that page not search/reports page.

MoneyRequestReportTransactionList

parasharrajat · 2025-10-22T14:22:01Z

src/components/Navigation/TopBar.tsx

    const [session] = useOnyx(ONYXKEYS.SESSION, {selector: authTokenTypeSelector, canBeMissing: true});
    const shouldShowLoadingBarForReports = useLoadingBarVisibility();
    const isAnonymousUser = isAnonymousUserUtil(session);
+    const isRhpVisible = useRootNavigationState((state) => state?.routes?.at(-1)?.name === NAVIGATORS.RIGHT_MODAL_NAVIGATOR);


It does not look correct, as RHP can have any screen. Do we have to hide the top bar? Did we confirm this with the product team? cc: @mountiny

22.10.2025_19.50.49_REC.mp4

I think this was only in the case the RHP also has a top bar so there are no two indicators shown at the same time

But this change currently is hiding indicator from LHN when we open the report details as shown in above vid. I think we should hide the LHN indicator only when expense wide view is open as that will show the indicator.

@WojtekBoman Can you please update this logic to fix this. The top bar on LHN should only hide when it is visible on RHP.

@collectioneur has already fixed that

parasharrajat · 2025-10-22T14:33:25Z

src/components/Search/openSearchReport/index.ts

+import SCREENS from '@src/SCREENS';
+
+export default function openSearchReport(reportID: string, backTo: string) {
+    navigationRef.dispatch({


Please add a comment on why we are preloading?

parasharrajat · 2025-10-22T14:39:22Z

src/components/Search/index.tsx

                if (item.isOneTransactionReport && firstTransaction && transactionPreviewData) {
                    setOptimisticDataForTransactionThreadPreview(firstTransaction, transactionPreviewData);
                }
                requestAnimationFrame(() => Navigation.navigate(ROUTES.SEARCH_MONEY_REQUEST_REPORT.getRoute({reportID, backTo})));


What about this case?

This one is currently opened in the central screen, so we don't need to optimize it

I think the issue is also present in central pane as shown in the video linked on issue description.

parasharrajat · 2025-10-22T14:39:33Z

src/components/Search/index.tsx

This one as well?

It has been addressed

parasharrajat · 2025-10-22T14:40:10Z

src/components/Search/index.tsx


            if (isReportActionListItemType(item)) {
                const reportActionID = item.reportActionID;
                Navigation.navigate(ROUTES.SEARCH_REPORT.getRoute({reportID, reportActionID, backTo}));


Screen.Recording.2025-10-27.at.15.28.06.mov

This one is used for the purpose shown on the video, we don't need to adjust this case

dubielzyk-expensify · 2025-10-22T23:11:28Z

In the latest adhoc I get empty wide RHP without the image thumbnail:

collectioneur · 2025-10-23T12:44:27Z

Hey @dubielzyk-expensify, could you please share the steps to reproduce this report state?

dubielzyk-expensify · 2025-10-23T23:44:19Z

I'm clicking just any expense after going to Reports -> Expenses

collectioneur · 2025-10-24T11:37:46Z

Everything works fine on my side, I can’t reproduce the issue. Could you send a video of your entire screen so I can better understand where to look?

Screen.Recording.2025-10-24.at.15.22.02.mov

dubielzyk-expensify · 2025-10-26T23:14:57Z

Retried in incognito and that seems to fix it so wonder if there's some weird cache or something. Have had this before as well.

dubielzyk-expensify · 2025-10-26T23:15:19Z

Keen to have @dannymcclain test and see if he has any issues

parasharrajat · 2025-10-27T06:07:15Z

There are some comments from me too. Please check them as well.

dannymcclain · 2025-10-27T13:28:29Z

Ran into the same issue as Jon, but opening in an incognito window seemed to fix it. The build seems pretty good to me unless Jon has any other timing/animation notes.

parasharrajat · 2025-10-28T07:42:11Z

It's better, but it is still not smooth. Tested on adhoc web build. Try opening consecutive expenses on reports page.

28.10.2025_13.10.23_REC.mp4

…iate recalculation after closing RHP, it should be recalculated after closing animation

collectioneur · 2025-10-28T14:36:31Z

I found a bug related to the wideRHP closing animation, which was the reason it looked choppy and cut off. After fixing it, the animation became much smoother. Please check it on your side, it should look noticeably better

Screen.Recording.2025-10-28.at.15.11.58.mov

collectioneur · 2025-10-28T15:53:11Z

Does this PR handle the Expense report transaction list as well? We show Wide RHP on that page too and from the slack thead the bug was reported on that page not search/reports page.

MoneyRequestReportTransactionList

This comment has been addressed too. @parasharrajat I believe everything should be fine now

parasharrajat · 2025-10-28T19:10:52Z

This looks better on exit. But I noticed when data is loading or an expense RHP is opened for the first time, it lags a lot.

Is there a way to heavy operations while animation is running?

I am running a M2 Pro laptop with 16GB ram.

29.10.2025_00.38.42_REC.mp4

…d of classic rhp

…ion for bug prevention when using rootState

collectioneur · 2025-10-29T15:03:04Z

On the first open quite a lot of things are calculated dynamically and in general the Wide RHP contains many sections, each of which is fairly heavy. That’s why I’m not sure we can achieve a significant performance improvement or make it much faster. @parasharrajat could you please test it again on the latest build?
@mountiny could you please trigger another ad-hoc build?

github-actions · 2025-10-29T20:03:47Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

mountiny · 2025-10-29T20:04:01Z

@parasharrajat @collectioneur running a new build, I think that making these animations smooth for first and any consecutive opening is important and we should keep that as a priority cc @staszekscp @blazejkustra

github-actions · 2025-10-29T20:19:22Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #72580.

Android 🤖	iOS 🍎
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Android build failed	The QR code can't be generated, because the iOS build failed

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/72580/NewExpensify.dmg	https://72580.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

parasharrajat · 2025-10-30T12:40:02Z

Same for me. @mountiny Can you please review the web version?

mountiny · 2025-10-30T13:47:04Z

It feels better for me, I think we can move forwards @parasharrajat - can you please complete the review?

parasharrajat · 2025-10-30T14:07:32Z

Great, Thanks. On it.

parasharrajat · 2025-10-30T14:07:39Z

Screenshots

🔲 iOS / native

🔲 iOS / Safari

30.10.2025_21.01.46_REC.mp4

🔲 MacOS / Desktop

30.10.2025_20.59.06_REC.mp4

🔲 MacOS / Chrome

30.10.2025_20.54.45_REC.mp4

🔲 Android / Chrome

30.10.2025_20.56.57_REC.mp4

🔲 Android / native

30.10.2025_21.08.24_REC.mp4

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

mountiny

Just one comment but since that is not technicallly related to your changes I wont block on this

mountiny · 2025-10-30T16:29:03Z

src/components/Search/index.tsx

            }

-            requestAnimationFrame(() => Navigation.navigate(ROUTES.SEARCH_REPORT.getRoute({reportID, backTo})));
+            openSearchReport(reportID, backTo);


Do you see the ESLint warning?

React Hook useCallback has an unnecessary dependency: 'type'. Either exclude it or remove the dependency array

Seems like type is not used so you could remove it

Yes, I've missed that, thanks for pointing out

Np, thanks!

OSBotify · 2025-10-30T16:54:29Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-10-31T21:46:08Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.42-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

IuliiaHerets · 2025-11-03T08:59:40Z

@WojtekBoman PR failed on Desktop by the QA team with an original issue

1761991078340.Screen_Recording_2025-11-01_at_11.55.23.mp4

OSBotify · 2025-11-03T22:39:21Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.42-11 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

mountiny · 2025-11-04T22:19:42Z

Reverted

melvin-bot bot assigned WojtekBoman Oct 14, 2025

WojtekBoman mentioned this pull request Oct 17, 2025

[Due for payment 2025-11-28] Fix lag on the wide RHP modal opening animation #72314

Closed

16 tasks

This comment has been minimized.

Sign in to view

dubielzyk-expensify self-requested a review October 21, 2025 22:57

dubielzyk-expensify previously approved these changes Oct 21, 2025

View reviewed changes

WojtekBoman dismissed dubielzyk-expensify’s stale review via b5f7ab7 October 22, 2025 07:35

WojtekBoman force-pushed the wide-rhp-animation-lag branch from a0fd320 to b5f7ab7 Compare October 22, 2025 07:35

WojtekBoman marked this pull request as ready for review October 22, 2025 08:20

WojtekBoman requested a review from a team as a code owner October 22, 2025 08:20

melvin-bot bot requested review from parasharrajat and removed request for a team October 22, 2025 08:20

parasharrajat suggested changes Oct 22, 2025

View reviewed changes

Hide loading bar on top bar when rhp is visible

f3c0727

collectioneur added 2 commits October 28, 2025 10:38

adjust navigating to wide rhp in transactions list

d0cb97b

removed lastVisibleRHPRouteKey from dependency array to prevent immid…

37a41c7

…iate recalculation after closing RHP, it should be recalculated after closing animation

collectioneur added 2 commits October 29, 2025 13:44

fixed widerhp initialization after efresh to have widerhp size instea…

14a901f

…d of classic rhp

Refactor last visible RHP route key calculation into a separate funct…

e1c264f

…ion for bug prevention when using rootState

collectioneur force-pushed the wide-rhp-animation-lag branch from 566a6bb to e1c264f Compare October 29, 2025 14:35

parasharrajat approved these changes Oct 30, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny October 30, 2025 15:39

mountiny approved these changes Oct 30, 2025

View reviewed changes

mountiny merged commit d02782c into Expensify:main Oct 30, 2025
26 checks passed

OSBotify mentioned this pull request Oct 31, 2025

Deploy Checklist: New Expensify 2025-10-31 #73985

Closed

linhvovan29546 mentioned this pull request Nov 2, 2025

App crashes after clicking outside report details RHP opened from Reports > Chats #74034

Closed

8 tasks

mountiny mentioned this pull request Nov 3, 2025

[CP Staging] Revert "Fix lag on the wide RHP modal opening animation" #74061

Merged

collectioneur mentioned this pull request Nov 17, 2025

Double loading bar issue when opening wide RHP fix #75288

Merged

54 tasks

Conversation

WojtekBoman commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Oct 17, 2025

Uh oh!

This comment has been minimized.

dubielzyk-expensify commented Oct 21, 2025

Uh oh!

mountiny commented Oct 21, 2025

Uh oh!

melvin-bot bot commented Oct 22, 2025

Uh oh!

mountiny commented Oct 22, 2025

Uh oh!

github-actions bot commented Oct 22, 2025

Uh oh!

parasharrajat commented Oct 22, 2025

Uh oh!

github-actions bot commented Oct 22, 2025

Uh oh!

parasharrajat left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WojtekBoman Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dubielzyk-expensify commented Oct 22, 2025

Uh oh!

collectioneur commented Oct 23, 2025

Uh oh!

dubielzyk-expensify commented Oct 23, 2025

Uh oh!

collectioneur commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dubielzyk-expensify commented Oct 26, 2025

Uh oh!

dubielzyk-expensify commented Oct 26, 2025

Uh oh!

parasharrajat commented Oct 27, 2025

Uh oh!

dannymcclain commented Oct 27, 2025

Uh oh!

WojtekBoman commented Oct 14, 2025 •

edited

Loading

codecov bot commented Oct 14, 2025 •

edited

Loading

WojtekBoman Oct 27, 2025 •

edited

Loading

collectioneur commented Oct 24, 2025 •

edited

Loading

parasharrajat commented Oct 28, 2025 •

edited

Loading

parasharrajat commented Oct 30, 2025 •

edited

Loading