refactor: move getPolicyTagsData to IOU and Transaction files by Skalakid · Pull Request #72678 · Expensify/App

Skalakid · 2025-10-15T10:10:17Z

Explanation of Change

This PR is part of a refactor to remove Onyx.connect from the src/libs/actions/Policy/Tag.ts file and replace it with useOnyx.

It isolates the getPolicyTagsData function from the Onyx.connect data by moving Onyx.connect temporarily to the files that were using it. Refactoring it right now would require a lot of complex changes, which would be hard to test in the future. Thanks to separating it to IOU.ts, Transaction.ts, and TransactionUtils/index.ts, we will be able to refactor everything in smaller PRs in a more organized and testable way.

I've marked getPolicyTagsData as deprecated and added the comment // TODO: Replace getPolicyTagsData with useOnyx hook above each use.

Fixed Issues

$ #69022
PROPOSAL:

Tests

Go to the workspace settings and enable the invoice feature
Force being offline
Create an invoice
Verify optimistic result
Go back online
Verify if the invoice was added successfully
Play with IOU and verify if it works as before

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

web.mov

codecov · 2025-10-15T10:21:22Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/actions/IOU/Duplicate.ts	`86.53% <100.00%> (+0.26%)`	⬆️
src/libs/actions/IOU/SendInvoice.ts	`95.86% <100.00%> (+0.10%)`	⬆️
src/libs/actions/IOU/Split.ts	`68.48% <100.00%> (+0.22%)`	⬆️
src/libs/actions/IOU/index.ts	`69.13% <100.00%> (+0.10%)`	⬆️
src/libs/actions/Policy/Tag.ts	`69.20% <ø> (-1.02%)`	⬇️
src/libs/actions/Transaction.ts	`67.19% <100.00%> (+0.22%)`	⬆️
src/libs/TransactionUtils/index.ts	`73.21% <77.77%> (+0.12%)`	⬆️
... and 9 files with indirect coverage changes

Skalakid · 2025-10-15T11:34:02Z

Hello @tgolen , can you create subtasks for IOU, Transaction and TransactionUtils for removing ONYXKEYS.COLLECTION.POLICY_TAGS please? I'm moving Onyx.connect (similarly to this PR) to these files because migration (especially in IOU) will require many changes, and I think it would be better to do it in smaller PRs for better testing and organization 😄

tgolen · 2025-10-15T20:09:08Z

OK, I created them!

…nnect/getPolicyTagsData-src-libs-actions-Policy-Tag.ts

melvin-bot · 2025-10-23T08:40:14Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shubham1206agra · 2025-10-23T09:16:46Z

src/libs/actions/IOU.ts

+// `allPolicyTags` was moved here temporarily from `src/libs/actions/Policy/Tag.ts` during the `Deprecate Onyx.connect` refactor.
+// All uses of this variable should be replaced with `useOnyx`.
+let allPolicyTags: OnyxCollection<OnyxTypes.PolicyTagLists> = {};
+Onyx.connect({


@Skalakid Can you create issue for refactoring all 3 new usages?
cc @tgolen

Already created here

IOU, TransactionUtils, Transaction

@shubham1206agra, bump. Can you review it again so we can get this one merged? :D

…nnect/getPolicyTagsData-src-libs-actions-Policy-Tag.ts

Skalakid · 2025-10-31T10:13:11Z

@shubham1206agra @tgolen bump

shubham1206agra · 2025-10-31T12:15:53Z

@Skalakid Can you give better test steps as current steps are too generic?

Skalakid · 2025-11-04T12:02:41Z

@shubham1206agra I updated test steps and uploaded a video 🫡 This PR affects many functions and scenarios, but it only moves the Onyx.connect from the Transaction file to IOU.ts, so it shouldn't make any difference in the behaviour

…nnect/getPolicyTagsData-src-libs-actions-Policy-Tag.ts # Conflicts: # src/libs/TransactionUtils/index.ts # src/libs/actions/IOU.ts # src/libs/actions/Policy/Tag.ts

…/libs/actions/Policy/Tag.ts

Guccio163 · 2026-01-22T23:40:42Z

There are some checks failing, probably because someone used getPolicyTagsData imported from Policy/Tag.ts once more - I'll get it fixed once it's ready, in the meantime @shubham1206agra please review this one so we can merge it and not fall into more issues incoming like that

Guccio163 · 2026-01-22T23:48:02Z

Hi @tgolen , can we please get another issue created, this time for src/libs/actions/IOU/Split.ts?

tgolen · 2026-01-24T01:05:34Z

OK, here you go: #80401

…-fork into @Skalakid/refactor/useonyx-deprecate-onyx-connect/getPolicyTagsData-src-libs-actions-Policy-Tag.ts

…licyTagsData-src-libs-actions-Policy-Tag.ts' of github.com:software-mansion-labs/expensify-app-fork into @Skalakid/refactor/useonyx-deprecate-onyx-connect/getPolicyTagsData-src-libs-actions-Policy-Tag.ts

…-fork into @Skalakid/refactor/useonyx-deprecate-onyx-connect/getPolicyTagsData-src-libs-actions-Policy-Tag.ts

Guccio163 · 2026-01-26T10:36:12Z

Hi, I went with the getter pattern and refactored this PR - we migrated Onyx.connect only to IOU/index.ts and from then we are using getPolicyTags(); This way it will be easier to migrate and track, I'll delete both the connect and getter function while all the usages are removed ✅

In the meantime, @shubham1206agra are you able to review this PR? If you need some help, I can ask @tgolen for assigning someone else

shubham1206agra · 2026-01-26T14:06:52Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
xIf a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-01-26.at.7.35.08.PM.mov

melvin-bot · 2026-01-26T14:07:38Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #69022 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

Guccio163 · 2026-01-26T15:54:29Z

@youssef-lr looks like this one's ready, let's get it merged 🚀

…-fork into @Skalakid/refactor/useonyx-deprecate-onyx-connect/getPolicyTagsData-src-libs-actions-Policy-Tag.ts

OSBotify · 2026-01-27T19:01:53Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-27T20:10:40Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.3.10-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-28T22:56:15Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.10-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

refactor: move getPolicyTagsData to IOU and Transaction files

17917f8

melvin-bot bot assigned Skalakid Oct 15, 2025

Skalakid added 3 commits October 15, 2025 12:59

fix: move Onyx.connect temporarily to TransactionUtils

b08a9a5

fix: update link to the issues in TODO comments in Transaction.ts

d293bdf

fix: remove getPolicyTagsData export

b2fae7c

refactor: update issue urls

5978bbf

Skalakid force-pushed the @Skalakid/refactor/useonyx-deprecate-onyx-connect/getPolicyTagsData-src-libs-actions-Policy-Tag.ts branch from b9c2934 to 5978bbf Compare October 16, 2025 10:16

dariusz-biela approved these changes Oct 20, 2025

View reviewed changes

Skalakid added 2 commits October 23, 2025 10:35

Merge branch 'main' into @Skalakid/refactor/useonyx-deprecate-onyx-co…

c676eea

…nnect/getPolicyTagsData-src-libs-actions-Policy-Tag.ts

fix: fix eslint errors

0efdb55

Skalakid marked this pull request as ready for review October 23, 2025 08:40

Skalakid requested a review from a team as a code owner October 23, 2025 08:40

melvin-bot bot requested a review from shubham1206agra October 23, 2025 08:40

melvin-bot bot removed the request for review from a team October 23, 2025 08:40

shubham1206agra reviewed Oct 23, 2025

View reviewed changes

Merge branch 'main' into @Skalakid/refactor/useonyx-deprecate-onyx-co…

4a0f467

…nnect/getPolicyTagsData-src-libs-actions-Policy-Tag.ts

Skalakid requested a review from shubham1206agra October 27, 2025 07:34

Merge branch 'main' into @Skalakid/refactor/useonyx-deprecate-onyx-co…

36619a9

…nnect/getPolicyTagsData-src-libs-actions-Policy-Tag.ts

Merge branch 'main' into @Skalakid/refactor/useonyx-deprecate-onyx-co…

6ae91eb

…nnect/getPolicyTagsData-src-libs-actions-Policy-Tag.ts # Conflicts: # src/libs/TransactionUtils/index.ts # src/libs/actions/IOU.ts # src/libs/actions/Policy/Tag.ts

dariusz-biela requested a review from a team as a code owner November 18, 2025 13:16

melvin-bot bot requested review from trjExpensify and removed request for a team November 18, 2025 13:16

feat: removes Onyx.connect for ONYXKEYS.COLLECTION.POLICY_TAGS in src…

bdf606c

…/libs/actions/Policy/Tag.ts

migrating also to Split.ts

6e70379

prettier

13d34d8

Guccio163 added 6 commits January 24, 2026 12:53

Split issue update

766ea1b

Merge branch 'main' of github.com:software-mansion-labs/expensify-app…

96d6826

…-fork into @Skalakid/refactor/useonyx-deprecate-onyx-connect/getPolicyTagsData-src-libs-actions-Policy-Tag.ts

update Mobile

2f63889

Merge branch '@Skalakid/refactor/useonyx-deprecate-onyx-connect/getPo…

0952df6

…licyTagsData-src-libs-actions-Policy-Tag.ts' of github.com:software-mansion-labs/expensify-app-fork into @Skalakid/refactor/useonyx-deprecate-onyx-connect/getPolicyTagsData-src-libs-actions-Policy-Tag.ts

Merge branch 'main' of github.com:software-mansion-labs/expensify-app…

21e3cae

…-fork into @Skalakid/refactor/useonyx-deprecate-onyx-connect/getPolicyTagsData-src-libs-actions-Policy-Tag.ts

bump max-warnings

89a384a

Guccio163 mentioned this pull request Jan 25, 2026

Remove Onyx.connect() for the key: ONYXKEYS.NVP_RECENT_WAYPOINTS in src/libs/actions/IOU.ts #73024

Open

Guccio163 added 3 commits January 26, 2026 11:25

use getPolicyTags from IOU/index.ts

0a7b0be

Merge branch 'main' of github.com:software-mansion-labs/expensify-app…

c544d6e

…-fork into @Skalakid/refactor/useonyx-deprecate-onyx-connect/getPolicyTagsData-src-libs-actions-Policy-Tag.ts

fix TODO comments

94c2272

Guccio163 added 2 commits January 26, 2026 11:50

fix imports

5df43b7

bring back Onyx.connect to TransactionUtils to fix tests

d0ac3a2

shubham1206agra approved these changes Jan 26, 2026

View reviewed changes

melvin-bot bot requested a review from youssef-lr January 26, 2026 14:07

Merge branch 'main' of github.com:software-mansion-labs/expensify-app…

debca04

…-fork into @Skalakid/refactor/useonyx-deprecate-onyx-connect/getPolicyTagsData-src-libs-actions-Policy-Tag.ts

youssef-lr approved these changes Jan 27, 2026

View reviewed changes

youssef-lr merged commit 33b026b into Expensify:main Jan 27, 2026
29 checks passed

OSBotify mentioned this pull request Jan 27, 2026

Deploy Checklist: New Expensify 2026-01-27 #80656

Closed

70 tasks

Conversation

Skalakid commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Oct 15, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Skalakid commented Oct 15, 2025

Uh oh!

tgolen commented Oct 15, 2025

Uh oh!

melvin-bot bot commented Oct 23, 2025

Uh oh!

shubham1206agra Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

Skalakid Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

Skalakid Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Skalakid commented Oct 31, 2025

Uh oh!

shubham1206agra commented Oct 31, 2025

Uh oh!

Skalakid commented Nov 4, 2025

Uh oh!

Guccio163 commented Jan 22, 2026

Uh oh!

Guccio163 commented Jan 22, 2026

Uh oh!

tgolen commented Jan 24, 2026

Uh oh!

Guccio163 commented Jan 26, 2026

Uh oh!

shubham1206agra commented Jan 26, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 26, 2026

Uh oh!

Guccio163 commented Jan 26, 2026

Uh oh!

Uh oh!

OSBotify commented Jan 27, 2026

Uh oh!

OSBotify commented Jan 27, 2026

Uh oh!

OSBotify commented Jan 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Skalakid commented Oct 15, 2025 •

edited

Loading

codecov bot commented Oct 15, 2025 •

edited by github-actions bot

Loading