refactor: isolate saveWaypoint from Onyx.connect data by Skalakid · Pull Request #72770 · Expensify/App

Skalakid · 2025-10-16T12:36:46Z

Explanation of Change

This PR is part of a refactor to remove Onyx.connect for the key: ONYXKEYS.NVP_RECENT_WAYPOINTS from the src/libs/actions/Transaction.ts file and replace it with useOnyx.

It isolates the saveWaypoint function from the Onyx.connect data.

To ensure this refactor doesn't break anything, it adds automated tests to the saveWaypoint function.

Fixed Issues

$ #67775
PROPOSAL:

Tests

Open the app
Press + button in the left bottom corner
Select the Track distance option
Add 2 destinations and save the tracked distance
Verify if it was saved successfully
Press + button in the left bottom corner
Select the Track distance option
Press Start and then press on the input and verify if previously entered destinations are listed as Recent

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

waypoints_web.mov

tests/unit/TransactionTest.ts

src/libs/actions/Transaction.ts

…nnect/saveWaypoint-src-libs-actions-Transaction.ts

codecov · 2025-10-24T08:38:23Z

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
.../pages/iou/request/step/IOURequestStepWaypoint.tsx	0.00%	2 Missing ⚠️

Files with missing lines	Coverage Δ
src/libs/actions/Transaction.ts	`47.45% <100.00%> (+3.48%)`	⬆️
.../pages/iou/request/step/IOURequestStepWaypoint.tsx	`0.00% <0.00%> (ø)`

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

melvin-bot · 2025-10-27T07:43:31Z

@DylanDylann @tgolen One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

tgolen · 2025-10-28T15:37:36Z

@DylanDylann This is waiting on you to do the reviewer checklist.

DylanDylann · 2025-10-28T15:58:31Z

I am reviewing

DylanDylann · 2025-10-28T15:58:35Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2025-10-28.at.23.10.53.mov

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

DylanDylann · 2025-10-28T16:16:20Z

src/pages/iou/request/step/IOURequestStepWaypoint.tsx

+        if (!allRecentWaypoints) {
+            return;
+        }


If this happens, users might experience an issue where clicking the save button and nothing happens. So I think this code doesn’t make sense. @tgolen What do you think?

Yeah, that doesn't sound good. This would be the case for any brand new account that is just using this for the first time, right? So, they would be in a case where they have no recent waypoints.

I think we can default it to an empty object instead of returning early like this.

cc @Skalakid

Changed 🫡

DylanDylann · 2025-10-28T16:45:34Z

The rest looks fine to me

…nnect/saveWaypoint-src-libs-actions-Transaction.ts

DylanDylann

LGTM

tgolen · 2025-10-29T15:37:13Z

This PR picked up some conflicts

tgolen · 2025-10-30T14:44:23Z

Bump @Skalakid to fix conflicts then this can be merged

…nnect/saveWaypoint-src-libs-actions-Transaction.ts

Skalakid · 2025-10-31T10:03:22Z

@tgolen fixed!

OSBotify · 2025-10-31T15:20:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-10-31T21:46:23Z

🚀 Deployed to staging by https://github.com/tgolen in version: 9.2.42-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-11-03T22:39:36Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.42-11 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Skalakid added 3 commits October 16, 2025 12:18

refactor: isolate saveWaypoint from Onyx.connect data

6cb1c75

fix: update saveWaypoint props in IOURequestStepWaypoint

8e08fb3

fix: fix passing not whole subset of recent waypoints

98e6e20

melvin-bot bot assigned Skalakid Oct 16, 2025

dariusz-biela reviewed Oct 22, 2025

View reviewed changes

tests/unit/TransactionTest.ts Show resolved Hide resolved

src/libs/actions/Transaction.ts Outdated Show resolved Hide resolved

Skalakid added 2 commits October 24, 2025 10:18

review: fix test

1cc7ee3

Merge branch 'main' into @Skalakid/refactor/useonyx-deprecate-onyx-co…

b6b27e8

…nnect/saveWaypoint-src-libs-actions-Transaction.ts

Skalakid requested a review from dariusz-biela October 24, 2025 08:27

Skalakid marked this pull request as ready for review October 27, 2025 07:43

Skalakid requested a review from a team as a code owner October 27, 2025 07:43

melvin-bot bot requested review from DylanDylann and tgolen and removed request for a team October 27, 2025 07:43

tgolen previously approved these changes Oct 27, 2025

View reviewed changes

DylanDylann reviewed Oct 28, 2025

View reviewed changes

review: remove early returns

72bafe9

Skalakid dismissed tgolen’s stale review via 72bafe9 October 29, 2025 09:35

Skalakid requested review from DylanDylann and tgolen October 29, 2025 09:41

Merge branch 'main' into @Skalakid/refactor/useonyx-deprecate-onyx-co…

968ff21

…nnect/saveWaypoint-src-libs-actions-Transaction.ts

DylanDylann mentioned this pull request Oct 29, 2025

refactor: remove getRecentWaypoints from Transaction.ts #72838

Merged

54 tasks

DylanDylann approved these changes Oct 29, 2025

View reviewed changes

tgolen previously approved these changes Oct 29, 2025

View reviewed changes

Merge branch 'main' into @Skalakid/refactor/useonyx-deprecate-onyx-co…

c80964c

…nnect/saveWaypoint-src-libs-actions-Transaction.ts

Skalakid dismissed tgolen’s stale review via c80964c October 31, 2025 10:02

Skalakid requested a review from tgolen October 31, 2025 10:13

tgolen approved these changes Oct 31, 2025

View reviewed changes

tgolen merged commit 2e0d870 into Expensify:main Oct 31, 2025
26 checks passed

OSBotify mentioned this pull request Oct 31, 2025

Deploy Checklist: New Expensify 2025-10-31 #73985

Closed

Conversation

Skalakid commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Oct 27, 2025

Uh oh!

tgolen commented Oct 28, 2025

Uh oh!

DylanDylann commented Oct 28, 2025

Uh oh!

DylanDylann commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

tgolen Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

DylanDylann Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DylanDylann Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

Skalakid Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Oct 28, 2025

Uh oh!

DylanDylann left a comment

Choose a reason for hiding this comment

Uh oh!

tgolen commented Oct 29, 2025

Uh oh!

tgolen commented Oct 30, 2025

Uh oh!

Skalakid commented Oct 31, 2025

Uh oh!

Uh oh!

OSBotify commented Oct 31, 2025

Uh oh!

OSBotify commented Oct 31, 2025

Uh oh!

OSBotify commented Nov 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Skalakid commented Oct 16, 2025 •

edited

Loading

codecov bot commented Oct 24, 2025 •

edited

Loading

DylanDylann commented Oct 28, 2025 •

edited

Loading

DylanDylann Oct 28, 2025 •

edited

Loading