Conversation
…formWriteAction from ReportUtils.ts part 5"
|
@blimpich looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
LGTM |
. Thank you for your hard work!![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| undefined, | ||
| isChatIOUReportArchived, | ||
| ); | ||
| deleteTrackExpense(reportIDRef.current, originalMessage?.IOUTransactionID, reportAction, duplicateTransactions, duplicateTransactionViolations, isReportArchived); |
There was a problem hiding this comment.
Bug: Parameter Mismatch Causes Incorrect Deletion Behavior
The deleteTrackExpense call passes isReportArchived as the sixth parameter, which is intended for isSingleTransactionView. This semantic mismatch causes the function to misinterpret the context of the deletion, potentially leading to incorrect navigation or behavior.
|
LGTM |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
Straight revert, not emergency |
(cherry picked from commit 3de280d) (cherry-picked to staging by blimpich)
|
🚀 Cherry-picked to staging by https://github.com/blimpich in version: 9.2.33-4 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.2.33-4 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/blimpich in version: 9.2.34-0 🚀
|
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.34-2 🚀
|
3 participants
Reverts #72619