Skip to content

use preferred skin tone emoji when add using enter#7292

Merged
luacmartins merged 2 commits intoExpensify:mainfrom
thesahindia:thesahindia/ux/emoji-on-enter
Jan 19, 2022
Merged

use preferred skin tone emoji when add using enter#7292
luacmartins merged 2 commits intoExpensify:mainfrom
thesahindia:thesahindia/ux/emoji-on-enter

Conversation

@thesahindia
Copy link
Member

Details

Fixed the default emoji issue when added using enter

Fixed Issues

$ #7264

Tests

  • Verify that no errors appear in the JS console

QA Steps

  1. Open a chat
  2. Open the emoji picker
  3. Change the default skin tone to something other than yellow
  4. Select an emoji and hit enter/return on the keyboard
  5. Verify the added emoji's skin tone is the preferred skin tone
  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen.Recording.2022-01-19.at.12.19.45.AM.mov

Mobile Web

Desktop

Screen.Recording.2022-01-19.at.12.16.27.AM.mov

iOS

Android

@thesahindia thesahindia requested a review from a team as a code owner January 18, 2022 19:06
@MelvinBot MelvinBot requested review from luacmartins and parasharrajat and removed request for a team January 18, 2022 19:07
Copy link
Contributor

@luacmartins luacmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What @parasharrajat said

Copy link
Contributor

@luacmartins luacmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tests well. Thanks @thesahindia!

@luacmartins luacmartins merged commit a2f6349 into Expensify:main Jan 19, 2022
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Copy link
Member

@parasharrajat parasharrajat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. a little late but I reviewed it already.

🎀 👀 🎀 C+ reviewed

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @luacmartins in version: 1.1.31-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @AndrewGable in version: 1.1.32-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@hayata-suenaga
Copy link
Contributor

I'll link a related regression reported here, although this PR might have not directly caused the issue.

There is a possibility that emoji is not highlighted when there is no emoji candidates. When that happens emoji is undefined, and accessing code property of undefined causes an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants