use preferred skin tone emoji when add using enter#7292
use preferred skin tone emoji when add using enter#7292luacmartins merged 2 commits intoExpensify:mainfrom thesahindia:thesahindia/ux/emoji-on-enter
Conversation
luacmartins
left a comment
There was a problem hiding this comment.
What @parasharrajat said
luacmartins
left a comment
There was a problem hiding this comment.
LGTM and tests well. Thanks @thesahindia!
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
parasharrajat
left a comment
There was a problem hiding this comment.
LGTM. a little late but I reviewed it already.
🎀 👀 🎀 C+ reviewed
|
🚀 Deployed to staging by @luacmartins in version: 1.1.31-2 🚀
|
|
🚀 Deployed to production by @AndrewGable in version: 1.1.32-0 🚀
|
|
I'll link a related regression reported here, although this PR might have not directly caused the issue. There is a possibility that emoji is not highlighted when there is no emoji candidates. When that happens |
Details
Fixed the default emoji issue when added using enter
Fixed Issues
$ #7264
Tests
QA Steps
Tested On
Screenshots
Web
Screen.Recording.2022-01-19.at.12.19.45.AM.mov
Mobile Web
Desktop
Screen.Recording.2022-01-19.at.12.16.27.AM.mov
iOS
Android