Skip to content

[No QA] Fix directory error on node run web#7300

Merged
Jag96 merged 2 commits intoExpensify:mainfrom
candidia:CSFlorin/fix-initial-node-run-web
Jan 19, 2022
Merged

[No QA] Fix directory error on node run web#7300
Jag96 merged 2 commits intoExpensify:mainfrom
candidia:CSFlorin/fix-initial-node-run-web

Conversation

@candidia
Copy link
Contributor

Details

This makes config/webpack/CustomVersionFilePlugin.js ensure all of version.js's parent directories exist before creating it.

Fixed Issues

$ #7011

Tests

  1. Make a fresh copy of the repo
  2. Install node & npm: brew install node
  3. Install watchman: brew install watchman
  4. Install dependencies: npm install
  5. Run npm run web
  • Verify that no errors appear in the JS console

QA Steps

I think simply deploying this to staging should validate it worked if staging has a fresh copy of the repo each time.

  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

N/A, this is dev bug

Web

N/A

Mobile Web

N/A

Desktop

N/A

iOS

N/A

Android

N/A

@candidia candidia requested a review from a team as a code owner January 18, 2022 22:29
@MelvinBot MelvinBot requested review from Jag96 and rushatgabhane and removed request for a team January 18, 2022 22:29
@github-actions
Copy link
Contributor

github-actions bot commented Jan 18, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@candidia
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@candidia
Copy link
Contributor Author

recheck

@rushatgabhane
Copy link
Member

Hi @CSFlorin, can you please change your title to something like - [No QA] Fix directory error on node run web. Thanks!

Copy link
Member

@rushatgabhane rushatgabhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

cc: @Jag96

@candidia candidia changed the title Cs florin/fix initial node run web [No QA] Fix directory error on node run web Jan 19, 2022
@Jag96 Jag96 merged commit 8ad0c4c into Expensify:main Jan 19, 2022
@OSBotify
Copy link
Contributor

@CSFlorin, Great job getting your first Expensify/App pull request over the finish line! 🎉

I know there's a lot of information in our contributing guidelines, so here are some points to take note of 📝:

  1. Now that your first PR has been merged, you can be hired for another issue. Once you've completed a few issues, you may be eligible to work on more than one job at a time.
  2. Once your PR is deployed to our staging servers, it will undergo quality assurance (QA) testing. If we find that it doesn't work as expected or causes a regression, you'll be responsible for fixing it. Typically, we would revert this PR and give you another chance to create a similar PR without causing a regression.
  3. Once your PR is deployed to production, we start a 7-day timer ⏰. After it has been on production for 7 days without causing any regressions, then we pay out the Upwork job. 💰

So it might take a while before you're paid for your work, but we typically post multiple new jobs every day, so there's plenty of opportunity. I hope you've had a positive experience contributing to this repo! 😊

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Jag96 in version: 1.1.31-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @AndrewGable in version: 1.1.32-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@candidia candidia deleted the CSFlorin/fix-initial-node-run-web branch January 27, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants