[No QA] Fix directory error on node run web#7300
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
|
Hi @CSFlorin, can you please change your title to something like - [No QA] Fix directory error on node run web. Thanks! |
|
@CSFlorin, Great job getting your first Expensify/App pull request over the finish line! 🎉 I know there's a lot of information in our contributing guidelines, so here are some points to take note of 📝:
So it might take a while before you're paid for your work, but we typically post multiple new jobs every day, so there's plenty of opportunity. I hope you've had a positive experience contributing to this repo! 😊 |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to production by @AndrewGable in version: 1.1.32-0 🚀
|
Details
This makes config/webpack/CustomVersionFilePlugin.js ensure all of version.js's parent directories exist before creating it.
Fixed Issues
$ #7011
Tests
brew install nodebrew install watchmannpm installnpm run webQA Steps
I think simply deploying this to staging should validate it worked if staging has a fresh copy of the repo each time.
Tested On
Screenshots
N/A, this is dev bug
Web
N/A
Mobile Web
N/A
Desktop
N/A
iOS
N/A
Android
N/A