Skip to content

[CP Staging] Revert "[NoQA] Remove call to getReportNameValuePairs() in method canUserPerformWriteAction from ReportUtils.ts part 6"#73095

Merged
blimpich merged 1 commit intomainfrom
revert-72585-fix/67103-part-6
Oct 21, 2025
Merged

[CP Staging] Revert "[NoQA] Remove call to getReportNameValuePairs() in method canUserPerformWriteAction from ReportUtils.ts part 6"#73095
blimpich merged 1 commit intomainfrom
revert-72585-fix/67103-part-6

Conversation

@grgia
Copy link
Contributor

@grgia grgia commented Oct 21, 2025

HOLD as Fix in review: #73119


Reverts #72585

Fixes blocker (app crash)

$ #73081

…UserPerformWriteAction from ReportUtils.ts part 6"
@github-actions
Copy link
Contributor

🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions
Copy link
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #73095.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ ⏩ SKIPPED ⏩
The build for Android was skipped The build for iOS was skipped
Desktop 💻 Web 🕸️
⏩ SKIPPED ⏩ https://73095.pr-testing.expensify.com
The build for Desktop was skipped Web

👀 View the workflow run that generated this build 👀

@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

❌ Patch coverage is 41.96429% with 65 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/libs/actions/IOU.ts 33.33% 12 Missing ⚠️
src/libs/actions/Report.ts 36.84% 12 Missing ⚠️
.../pages/tasks/TaskShareDestinationSelectorModal.tsx 0.00% 12 Missing ⚠️
src/libs/ReportUtils.ts 64.28% 10 Missing ⚠️
src/hooks/useSelectedTransactionsActions.ts 0.00% 9 Missing ⚠️
...es/iou/request/step/IOURequestStepConfirmation.tsx 66.66% 3 Missing ⚠️
src/components/MoneyReportHeader.tsx 0.00% 1 Missing ⚠️
...RequestReportView/MoneyRequestReportNavigation.tsx 0.00% 1 Missing ⚠️
...nents/ReportActionItem/MoneyRequestReceiptView.tsx 0.00% 1 Missing ⚠️
src/components/Search/index.tsx 0.00% 1 Missing ⚠️
... and 3 more
Files with missing lines Coverage Δ
...tachments/AttachmentCarousel/extractAttachments.ts 70.83% <ø> (ø)
src/components/MoneyRequestHeader.tsx 0.91% <ø> (ø)
...c/components/Search/SearchFiltersChatsSelector.tsx 0.00% <ø> (ø)
src/hooks/useIsReportReadyToDisplay.ts 100.00% <100.00%> (ø)
src/libs/DebugUtils.ts 69.06% <100.00%> (+0.06%) ⬆️
src/libs/Navigation/AppNavigator/AuthScreens.tsx 53.62% <ø> (+0.03%) ⬆️
src/libs/OptionsListUtils/index.ts 70.85% <100.00%> (+0.01%) ⬆️
src/libs/QuickActionUtils.ts 42.35% <100.00%> (+0.68%) ⬆️
src/libs/SidebarUtils.ts 80.63% <100.00%> (+0.04%) ⬆️
src/pages/ReportDetailsPage.tsx 58.33% <ø> (ø)
... and 14 more

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@grgia grgia requested review from DylanDylann and tgolen October 21, 2025 14:38
@grgia grgia marked this pull request as ready for review October 21, 2025 14:38
@grgia grgia requested a review from a team as a code owner October 21, 2025 14:38
@melvin-bot melvin-bot bot requested review from Gonals and removed request for a team October 21, 2025 14:38
@melvin-bot
Copy link

melvin-bot bot commented Oct 21, 2025

@Gonals Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions
Copy link
Contributor

LGTM :feelsgood:. Thank you for your hard work!

@grgia grgia changed the title Revert "[NoQA] Remove call to getReportNameValuePairs() in method canUserPerformWriteAction from ReportUtils.ts part 6" [HOLD, FIX UP] Revert "[NoQA] Remove call to getReportNameValuePairs() in method canUserPerformWriteAction from ReportUtils.ts part 6" Oct 21, 2025
Copy link
Contributor

@blimpich blimpich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed revert fixes #73081 locally

@blimpich blimpich changed the title [HOLD, FIX UP] Revert "[NoQA] Remove call to getReportNameValuePairs() in method canUserPerformWriteAction from ReportUtils.ts part 6" Revert "[NoQA] Remove call to getReportNameValuePairs() in method canUserPerformWriteAction from ReportUtils.ts part 6" Oct 21, 2025
@blimpich blimpich changed the title Revert "[NoQA] Remove call to getReportNameValuePairs() in method canUserPerformWriteAction from ReportUtils.ts part 6" [CP Staging] Revert "[NoQA] Remove call to getReportNameValuePairs() in method canUserPerformWriteAction from ReportUtils.ts part 6" Oct 21, 2025
@blimpich blimpich merged commit 6294b5c into main Oct 21, 2025
27 of 37 checks passed
@blimpich blimpich deleted the revert-72585-fix/67103-part-6 branch October 21, 2025 20:18
@melvin-bot
Copy link

melvin-bot bot commented Oct 21, 2025

@blimpich looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@blimpich
Copy link
Contributor

Not an emergency, straight revert of a PR to fix a deploy blocker

OSBotify pushed a commit that referenced this pull request Oct 21, 2025
(cherry picked from commit 6294b5c)

(cherry-picked to staging by blimpich)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Oct 21, 2025
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/blimpich in version: 9.2.35-4 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/blimpich in version: 9.2.35-4 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/blimpich in version: 9.2.36-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/lakchote in version: 9.2.36-7 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants