[Internal QA] Missing personal details magic code modal uses navigation by jmusial · Pull Request #73116 · Expensify/App

jmusial · 2025-10-21T15:00:03Z

Explanation of Change

Rewrites missing personal details modal to use RHP with url instead of modal.

Fixed Issues

PROPOSAL:

Tests

NOTE:
For DEV: physical card cannot be really iussued. Testing done via preparing the optimistic response to look like a real life response

Pre requisite:
have a physical card generated but not send on an account (state: 2)

Open app
Go to Account -> Wallet
Click on your Physical card
Click Get physical card
Fill missing details form
Type in magic code
Modal closes* (or request succeeds and nothing happens)

* mimicking woking API by adding in src/libs/actions/PersonalDetails.ts#537

            {
                onyxMethod: Onyx.METHOD.MERGE,
                key: ONYXKEYS.CARD_LIST,
                value: {
                    [PHYSICAL_CARD_ID]: {state: 3},
                },
            },

to finallyData

Offline tests

N/A

QA Steps

Not sure if can be tested by QA due to physical card restrictions, but steps should be same as tests.

PR Author Checklist

Screenshots/Videos

Android: Native

0070.android.native.mov

Android: mWeb Chrome

0070.android.chrome.mov

iOS: Native

0070.ios.native.mov

iOS: mWeb Safari

0070.ios.safari.mov

MacOS: Chrome / Safari

0070.desktop.chrome.mov

MacOS: Desktop

0070.desktop.native.mov

codecov · 2025-10-21T15:14:26Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/ROUTES.ts	`11.75% <ø> (ø)`
src/SCREENS.ts	`100.00% <ø> (ø)`
src/libs/Navigation/linkingConfig/config.ts	`75.00% <ø> (ø)`
src/libs/PersonalDetailsUtils.ts	`80.25% <100.00%> (+1.06%)`	⬆️
src/libs/ReportActionsUtils.ts	`51.01% <100.00%> (-0.18%)`	⬇️
src/selectors/Account.ts	`100.00% <100.00%> (ø)`
src/selectors/PersonalDetails.ts	`75.00% <ø> (ø)`
...gation/AppNavigator/ModalStackNavigators/index.tsx	`8.46% <0.00%> (-0.02%)`	⬇️
...alDetails/MissingPersonalDetailsMagicCodeModal.tsx	`0.00% <0.00%> (ø)`
.../pages/settings/Wallet/ExpensifyCardPage/index.tsx	`66.66% <0.00%> (+3.50%)`	⬆️
... and 2 more
... and 8 files with indirect coverage changes

…navigation

melvin-bot · 2025-11-03T12:45:17Z

@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2025-11-03T12:47:47Z

LGTM . Thank you for your hard work!

mountiny · 2025-11-04T22:10:47Z

@aimane-chnaif Can you review please?

aimane-chnaif

For DEV: physical card cannot be really iussued. Testing done via preparing the optimistic response to look like a real life response

Can you please add this to step? Maybe Onyx test data.

Please merge main.

aimane-chnaif · 2025-11-05T15:57:19Z

src/pages/MissingPersonalDetails/MissingPersonalDetailsMagicCodePage.tsx

+function MissingPersonalDetailsMagicCodePage() {
    const {translate} = useLocalize();
-    const [privatePersonalDetails] = useOnyx(ONYXKEYS.PRIVATE_PERSONAL_DETAILS, {canBeMissing: true});
+    const [privatePersonalDetails] = useOnyx(ONYXKEYS.PRIVATE_PERSONAL_DETAILS, {canBeMissing: false});


canBeMissing: true -> false

What's this change for? Would be good to have some context.

Assumed this was misissue of {canBeMissing: true}.

Following canBeMissing docstring

If the component calling this does not load the data then you should set it to false, which means that if the data is not there, it will log an alert, as it means we are using data that no one loaded and that's most probably a bug.

This pages` logic relies on privatePersonalDetails so changed it to false

aimane-chnaif · 2025-11-05T15:58:02Z

src/pages/MissingPersonalDetails/MissingPersonalDetailsMagicCodePage.tsx

+    const handleSubmitForm = (validateCode: string) => {
+        updatePersonalDetailsAndShipExpensifyCards(values, validateCode, countryCode);
+    };


add useCallback here

…navigation

jmusial · 2025-11-06T15:03:39Z

@aimane-chnaif updated & added data I've been testing with. Also added [Internal QA] (I saw that on some of the older PRs regarding physical cards. Hope that's ok).

mountiny · 2025-11-06T23:23:18Z

@aimane-chnaif Can you continue to the review please?

github-actions · 2025-11-06T23:24:03Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-11-06T23:49:53Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #73116.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/73116/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/73116/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/73116/NewExpensify.dmg	https://73116.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

trjExpensify · 2025-11-06T23:53:49Z

PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself.

aimane-chnaif · 2025-11-07T10:04:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-11-07.at.12.54.13.pm.mov

Android: mWeb Chrome

iOS: HybridApp

Screen.Recording.2025-11-07.at.12.16.53.pm.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-11-07.at.1.12.36.pm.mov

MacOS: Desktop

Screen.Recording.2025-11-07.at.12.37.16.pm.mov

OlGierd03 · 2025-11-10T21:02:02Z

Wanted to merge main branch and resolve the conflict with #68749, however it seems difficult for me to handle without much context, so I'll leave it for @jmusial to do. He's OOO until Wednesday (12.11)

mountiny · 2025-11-11T15:52:25Z

Thanks, ping me when done please

…navigation

mountiny · 2025-11-12T10:40:55Z

src/pages/MissingPersonalDetails/MissingPersonalDetailsMagicCodePage.tsx

+    const [draftValues] = useOnyx(ONYXKEYS.FORMS.PERSONAL_DETAILS_FORM_DRAFT, {canBeMissing: false});
+    const [countryCode = CONST.DEFAULT_COUNTRY_CODE] = useOnyx(ONYXKEYS.COUNTRY_CODE, {canBeMissing: false});
+
+    const [cardList] = useOnyx(ONYXKEYS.CARD_LIST, {canBeMissing: true});


Should we add the areAllCardsShipped logic to selector? I think that should be the right way to do it with the "selector-first" mind

mountiny · 2025-11-12T10:41:36Z

src/pages/MissingPersonalDetails/MissingPersonalDetailsMagicCodePage.tsx

+    const [countryCode = CONST.DEFAULT_COUNTRY_CODE] = useOnyx(ONYXKEYS.COUNTRY_CODE, {canBeMissing: false});
+
+    const [cardList] = useOnyx(ONYXKEYS.CARD_LIST, {canBeMissing: true});
+    const [account] = useOnyx(ONYXKEYS.ACCOUNT, {canBeMissing: true});


Same here, we only need the primary logic so we should select that, otherwise this is subscribed to all props of account key even if we only care about the primaryLogin

jmusial · 2025-11-12T11:19:47Z

@mountiny all updated

Unfortunately #68749 introduced another ConfirmCode usage to be handled. codewise it's not a big change but testing gonna be more painful, will do it in separate PR. Added to the latest list in task

mountiny · 2025-11-12T11:26:41Z

@aimane-chnaif Please keep that selector comments in mind to ask authors to refactor to use selectors when possible, thanks

mountiny

Thanks!

mountiny · 2025-11-12T11:28:12Z

src/libs/PersonalDetailsUtils.ts

+function arePersonalDetailsMissing(privatePersonalDetails: OnyxEntry<PrivatePersonalDetails>): boolean {
+    return (
+        !privatePersonalDetails?.legalFirstName ||
+        !privatePersonalDetails?.legalLastName ||
+        !privatePersonalDetails?.dob ||
+        !privatePersonalDetails?.phoneNumber ||
+        isEmptyObject(privatePersonalDetails?.addresses) ||
+        privatePersonalDetails.addresses.length === 0
+    );
+}


Lets also add a test for this method if there is none @jmusial feel free to do that in a follow up 🙇

aimane-chnaif · 2025-11-12T11:29:02Z

@aimane-chnaif Please keep that selector comments in mind to ask authors to refactor to use selectors when possible, thanks

Noted thanks

OSBotify · 2025-11-12T14:21:46Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-11-12T16:07:45Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.55-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-11-13T01:20:18Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.57-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

joekaufmanexpensify · 2025-11-13T16:30:05Z

Tested on staging and works well 👍

OSBotify · 2025-11-13T17:13:04Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.57-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

Missing person magic code modal uses navigation

64a2299

melvin-bot bot assigned jmusial Oct 21, 2025

jmusial added 4 commits October 27, 2025 15:43

Merge branch 'main' into feat/missing-person-confirm-code-modal-uses-…

d26cacd

…navigation

Merge branch 'main' into feat/missing-person-confirm-code-modal-uses-…

b974274

…navigation

dismoss modal on success

cecb8d8

Merge branch 'main' into feat/missing-person-confirm-code-modal-uses-…

960480b

…navigation

jmusial marked this pull request as ready for review November 3, 2025 12:45

jmusial requested a review from a team as a code owner November 3, 2025 12:45

melvin-bot bot requested review from ishpaul777 and removed request for a team November 3, 2025 12:45

jmusial mentioned this pull request Nov 4, 2025

Expensify Card - After entering magic code to confirm shipping details, RHP does not close #57736

Closed

8 tasks

mountiny requested review from aimane-chnaif and mountiny and removed request for ishpaul777 November 4, 2025 22:10

mountiny mentioned this pull request Nov 4, 2025

[Due for payment now] [Tracking] [$1000] Update the ValidateCodeActionModal to be its own screen in the stack #69171

Closed

aimane-chnaif suggested changes Nov 5, 2025

View reviewed changes

Merge branch 'main' into feat/missing-person-confirm-code-modal-uses-…

3d020e3

…navigation

jmusial requested a review from a team as a code owner November 6, 2025 14:48

melvin-bot bot requested review from trjExpensify and removed request for a team November 6, 2025 14:48

add use callback

6b0a48f

jmusial changed the title ~~Missing person magic code modal uses navigation~~ [Internal QA] Missing person magic code modal uses navigation Nov 6, 2025

jmusial requested a review from aimane-chnaif November 6, 2025 15:02

mountiny added the InternalQA This pull request required internal QA label Nov 6, 2025

trjExpensify removed their request for review November 6, 2025 23:53

jmusial changed the title ~~[Internal QA] Missing person magic code modal uses navigation~~ [Internal QA] Missing personal details magic code modal uses navigation Nov 7, 2025

aimane-chnaif approved these changes Nov 7, 2025

View reviewed changes

OlGierd03 mentioned this pull request Nov 10, 2025

Handle errors for missing KBA data #68749

Merged

64 tasks

jmusial added 3 commits November 12, 2025 11:24

Merge branch 'main' into feat/missing-person-confirm-code-modal-uses-…

677ac74

…navigation

add arePersonalDetailsMissing util

3e7e802

oops

537fa20

mountiny reviewed Nov 12, 2025

View reviewed changes

jmusial added 2 commits November 12, 2025 11:42

remove stashed file

4e84735

use selectors

f906694

mountiny approved these changes Nov 12, 2025

View reviewed changes

mountiny merged commit d311736 into Expensify:main Nov 12, 2025
27 checks passed

OSBotify mentioned this pull request Nov 12, 2025

Deploy Checklist: New Expensify 2025-11-12 #74958

Closed

67 tasks

Conversation

jmusial commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Oct 21, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Nov 3, 2025

Uh oh!

github-actions bot commented Nov 3, 2025

Uh oh!

mountiny commented Nov 4, 2025

Uh oh!

aimane-chnaif left a comment

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

jmusial Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

jmusial commented Nov 6, 2025

Uh oh!

mountiny commented Nov 6, 2025

Uh oh!

github-actions bot commented Nov 6, 2025

Uh oh!

github-actions bot commented Nov 6, 2025

Uh oh!

trjExpensify commented Nov 6, 2025

Uh oh!

aimane-chnaif commented Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

OlGierd03 commented Nov 10, 2025

Uh oh!

mountiny commented Nov 11, 2025

Uh oh!

mountiny Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

mountiny Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

jmusial commented Nov 12, 2025

Uh oh!

mountiny commented Nov 12, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif commented Nov 12, 2025

Uh oh!

Uh oh!

OSBotify commented Nov 12, 2025

Uh oh!

OSBotify commented Nov 12, 2025

Uh oh!

OSBotify commented Nov 13, 2025

Uh oh!

joekaufmanexpensify commented Nov 13, 2025

Uh oh!

jmusial commented Oct 21, 2025 •

edited

Loading

codecov bot commented Oct 21, 2025 •

edited by github-actions bot

Loading

jmusial Nov 6, 2025 •

edited

Loading

aimane-chnaif commented Nov 7, 2025 •

edited

Loading