fix: handle selection mode in search context#73232
fix: handle selection mode in search context#73232youssef-lr merged 5 commits intoExpensify:mainfrom
Conversation
Codecov Report❌ Patch coverage is
... and 132 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp2025-11-03.14.35.56.movAndroid: mWeb Chrome2025-11-03.14.32.49.moviOS: HybridApp2025-11-03.14.25.12.moviOS: mWeb Safari2025-11-03.14.25.12.movMacOS: Chrome / Safari2025-11-03.14.28.57.movMacOS: Desktop2025-11-03.14.28.57.mov |
|
@daledah |
|
@ZhenjaHorbach i added |
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Good from a product perspective 👍
|
LGTM! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.2.46-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.46-3 🚀
|
Explanation of Change
Fixed Issues
$ #69251
#73089
PROPOSAL: #69251 (comment)
Tests
Scenario 1: Incorrect selection state after resizing
Scenario 2: Header not updating on resize in selection mode
Scenario 3:
Offline tests
QA Steps
Scenario 1: Incorrect selection state after resizing
Scenario 2: Header not updating on resize in selection mode
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-10-13.at.01.03.05.mov
a.mov
Android: mWeb Chrome
Screen.Recording.2025-10-13.at.01.07.13.mov
am.mov
iOS: Native
Screen.Recording.2025-10-13.at.01.07.31.mov
m.mov
iOS: mWeb Safari
Screen.Recording.2025-10-13.at.01.35.58.mov
im.mov
MacOS: Chrome / Safari
Screen.Recording.2025-10-13.at.01.36.18.mov
w.mov
MacOS: Desktop
Screen.Recording.2025-10-13.at.01.36.47.mov
des.mov