Skip to content

Autoclose address autocomplete list#7330

Merged
NikkiWines merged 1 commit intoExpensify:mainfrom
parasharrajat:fix-tab-navigation
Jan 20, 2022
Merged

Autoclose address autocomplete list#7330
NikkiWines merged 1 commit intoExpensify:mainfrom
parasharrajat:fix-tab-navigation

Conversation

@parasharrajat
Copy link
Member

Details

Fixed Issues

$ #6235

Tests | QA Steps

  1. Go to Bank account, Company Information step.
  2. Search for an address on Company Address field.
  3. Autocomplete List should show up.
  4. Click somewhere outside the autocomplete list. the list should close.
  5. Click back to Company Address field. The list should show up.
  6. Now press Tab on your keyboard.
  7. Focus should move away from Company Address field.
  8. Click somewhere outside the autocomplete list. the list should close.
  9. Click back to the Company Address field. The list should show up.
  10. Now press the tab the number of times equal to the items shown on the autocomplete list.
  11. As soon as you press the Tab one more time, the focus should move to the next field Phone number and list should close.
  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

screen-2022-01-13-054406_WVDEpzeq.mp4

Mobile Web

Desktop

Not able to test it on the development server due to CORS errors.

iOS

Android

@parasharrajat parasharrajat requested a review from a team as a code owner January 20, 2022 06:15
@MelvinBot MelvinBot requested review from NikkiWines and removed request for a team January 20, 2022 06:15
Copy link
Contributor

@NikkiWines NikkiWines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@NikkiWines NikkiWines merged commit 3cce147 into Expensify:main Jan 20, 2022
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@parasharrajat
Copy link
Member Author

@NikkiWines Can I apply for the same job to get compensated?

@NikkiWines
Copy link
Contributor

NikkiWines commented Jan 20, 2022

Yep. @kevinksullivan, @parasharrajat ended up fixing #6235 by forking the repo and implementing a solution on the fork. This PR updates New Expensify so we use that fork. Can we hire him for that job and issue payment for it once this PR has been on prod for a week w/ no regressions?

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @NikkiWines in version: 1.1.31-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @AndrewGable in version: 1.1.32-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants