Fix split translations in workspace.distanceRates#73331
Merged
youssef-lr merged 7 commits intoExpensify:mainfrom Nov 6, 2025
Merged
Fix split translations in workspace.distanceRates#73331youssef-lr merged 7 commits intoExpensify:mainfrom
youssef-lr merged 7 commits intoExpensify:mainfrom
Conversation
Codecov Report❌ Patch coverage is
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Contributor
|
Why is this 
It should be like this, no? cc @Expensify/design for extra eyes 
I notice it's wrong in the product today as well: 
|
Contributor
|
Good catch Jon - totally agree. That should be using our |
Contributor
Author
|
@dubielzyk-expensify can we make the parent issue for $250 so that we can fix this bug in the same PR? otherwise such issues are reported through normal bug process |
Contributor
|
I'll let @eh2077 figure out that bit. We can also file it separately. I don't mind. |
Contributor
|
Yeah, I think we can handle it separately |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / SafariScreen.Recording.2025-11-05.at.3.33.06.PM.movMacOS: Desktop
|
eh2077
reviewed
Oct 31, 2025
Comment on lines
+50
to
+59
| return onLinkPress ? ( | ||
| <RenderHTMLConfigProvider | ||
| defaultTextProps={{selectable: true}} | ||
| renderersProps={renderersProps} | ||
| > | ||
| {htmlSource} | ||
| </RenderHTMLConfigProvider> | ||
| ) : ( | ||
| htmlSource | ||
| ); |
Contributor
There was a problem hiding this comment.
I'm not sure if it is a good pattern to conditionally wrap with config provider.
Contributor
Author
There was a problem hiding this comment.
@eh2077 we got this code merged in another PR, what do you suggest instead? i can update it in this PR
Contributor
There was a problem hiding this comment.
Okay, then I think it should be fine.
Comment on lines
12
to
+21
| // Configuration for RenderHTML is handled in a top-level component providing | ||
| // context to RenderHTMLSource components. See https://git.io/JRcZb | ||
| // The provider is available at src/components/HTMLEngineProvider/ | ||
| function RenderHTML({html: htmlParam}: RenderHTMLProps) { | ||
| function RenderHTML({html: htmlParam, onLinkPress}: RenderHTMLProps) { |
Contributor
There was a problem hiding this comment.
The render config is handled in HTMLEngineProvider as mentioned, this change will conflict with it. I think it's better to make it consistent.
Contributor
Author
There was a problem hiding this comment.
sorry didn't quite catch that can you reference the code for what you are trying to say?
Contributor
There was a problem hiding this comment.
I think this comment can be marked as resolved too because the change isn't in this PR.
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
eh2077
approved these changes
Nov 5, 2025
youssef-lr
approved these changes
Nov 6, 2025
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
64 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.2.46-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.46-3 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #72054
PROPOSAL: #72054 (comment)
Tests
Offline tests
QA Steps
Verify that the track tax toggle is disabled and the subtext is displayed correctly
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop