Remove openReport calls from the merge transaction flows - Part 1 by hoangzinh · Pull Request #73439 · Expensify/App

hoangzinh · 2025-10-24T16:21:18Z

Explanation of Change

During Merge Transaction PRs, we need to workaround by triggering openReport API calls to get report data for displaying purposes. We need to remove those workarounds to avoid increasing traffic to BE. This PR is the first part to remove openReport call in MergeTransactionsListContent by using reportName in GetTransactionsForMerging API.

Fixed Issues

$ #69564
PROPOSAL:

Tests

Same as QA

Verify that no errors appear in the JS console

Offline tests

Same as QA

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Prerequisite:

Create 2 workspaces. Then create an expense in each workspace (Called E1, E2)
Create another expense in selfDM

Case 1: Merge an expense with an unreported expense in selfDM

Sign in to Expensify.
Open expense E1.
Tap More → Merge.
Select the selfDM expense and tap Continue.
Verify that the Select details page displays:
- E1’s report name, and
- “None” for the selfDM expense under the Report selection.
Select None in the Report selection.
Verify that the Confirmation page displays the selfDM's report name.

Case 2: Merge two expenses

Sign in to Expensify.
Open expense E1.
Tap More → Merge.
Select expense E2.
Verify that the Select details page displays both E1’s and E2’s report names in the Report selection.
Select E2’s report name in the Report selection.
Verify that the Confirmation page displays E2’s report name.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-10-27.at.16.04.13.android.mov

Android: mWeb Chrome

Screen.Recording.2025-10-27.at.16.00.44.android.chrome.mov

iOS: Native

Screen.Recording.2025-10-27.at.16.13.10.mov

iOS: mWeb Safari

Screen.Recording.2025-10-27.at.16.07.04.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2025-10-27.at.15.53.57.web.mov

MacOS: Desktop

Screen.Recording.2025-10-27.at.15.58.34.desktop.mov

codecov · 2025-10-24T16:39:26Z

Codecov Report

❌ Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...c/components/ReportActionItem/MoneyRequestView.tsx	0.00%	3 Missing ⚠️

Files with missing lines	Coverage Δ
src/libs/DebugUtils.ts	`68.91% <100.00%> (+0.06%)`	⬆️
src/libs/MergeTransactionUtils.ts	`84.93% <100.00%> (+1.71%)`	⬆️
src/libs/actions/MergeTransaction.ts	`55.55% <100.00%> (ø)`
src/pages/TransactionMerge/DetailsReviewPage.tsx	`0.00% <ø> (ø)`
.../TransactionMerge/MergeTransactionsListContent.tsx	`0.00% <ø> (ø)`
...c/components/ReportActionItem/MoneyRequestView.tsx	`0.28% <0.00%> (+<0.01%)`	⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- Extract currency handling logic from DetailsReviewPage into centralized function - Add MergeTransactionUpdateValues type for better type safety with null values - Update setMergeTransactionKey to handle null values for Onyx key clearing - Add comprehensive tests for merge field update scenarios - Improve code organization by centralizing field update logic

- Add reportName handling to merge transaction flow - Update MoneyRequestView to support merged report names - Enhance MergeTransactionUtils with reportName merge logic - Add comprehensive tests for getMergeFieldUpdatedValues function - Improve confirmation page display for merged transactions

melvin-bot · 2025-10-27T13:36:06Z

@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

youssef-lr · 2025-10-27T20:38:58Z

@hoangzinh I wonder how does this affect the required dependency of transactionThreadReport in MoneyRequestView?

hoangzinh · 2025-10-28T09:13:01Z

The openReport call in this PR (will fetch money report) is independent with transactionThreadReport in MoneyRequestView @youssef-lr. No affected at all.

youssef-lr · 2025-10-28T16:23:12Z

Ah I see. So this doesn't conflict with what I'm trying to do which is removing openReport from here

App/src/pages/TransactionMerge/DetailsReviewPage.tsx

Line 118 in 2f78586

return openReport(targetTransactionThreadReportID);

hoangzinh · 2025-10-29T08:10:03Z

Yes, @youssef-lr

trjExpensify · 2025-10-29T19:53:54Z

What's the ETA on reviewing this PR? Can we keep it moving?

dominictb · 2025-10-29T20:54:52Z

Still testing, will complete tomorrow morning.

dominictb · 2025-10-30T22:45:15Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

Screen.Recording.2025-10-31.at.21.46.10.mov

iOS: HybridApp

iOS: mWeb Safari

Screen.Recording.2025-10-31.at.05.47.01.mov

MacOS: Chrome / Safari

Screen.Recording.2025-10-31.at.05.42.36.mov

MacOS: Desktop

dominictb · 2025-10-30T22:51:45Z

BUG

Infinite loading in confirmation step in offline and target transaction is the unreported transaction

Screen.Recording.2025-10-31.at.05.49.53.mov

Not sure if it's related to this PR

src/libs/actions/MergeTransaction.ts

Co-authored-by: Dominic <165644294+dominictb@users.noreply.github.com>

hoangzinh · 2025-10-31T10:54:41Z

@dominictb this bug was fixed somewhere in main. Can you test again? TY

dominictb

🎀

OSBotify · 2025-10-31T22:02:11Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-11-03T23:02:12Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.2.43-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-11-04T20:49:45Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.43-2 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot bot assigned hoangzinh Oct 24, 2025

Remove openReport temporary solution by using transaction.reportName

852a70b

hoangzinh force-pushed the fix/remove-openreport-calls-merge branch from 30a9f77 to 852a70b Compare October 24, 2025 16:26

Fix eslint

b197d4c

hoangzinh added 3 commits October 27, 2025 10:58

Revert changes

beb322b

hoangzinh changed the title ~~Remove openReport calls from the merge transaction flows~~ Remove openReport calls from the merge transaction flows - Part 1 Oct 27, 2025

hoangzinh added 4 commits October 27, 2025 11:35

Fix type errors

b7e9fbb

Fix failed spec

1109c31

Add spec of getDisplayValue for reportID

0a8e670

Fix spellcheck

5f58e12

hoangzinh marked this pull request as ready for review October 27, 2025 13:35

hoangzinh requested a review from a team as a code owner October 27, 2025 13:36

melvin-bot bot requested review from dominictb and removed request for a team October 27, 2025 13:36

hoangzinh mentioned this pull request Oct 27, 2025

[Due for payment 2025-12-04] [Merge] Remove OpenReport calls from the Merge code #69564

Closed

dominictb mentioned this pull request Oct 30, 2025

[Merge] Merging tax rates #71244

Merged

54 tasks

dominictb suggested changes Oct 30, 2025

View reviewed changes

src/libs/actions/MergeTransaction.ts Outdated Show resolved Hide resolved

Update suggestion

51da8e9

Co-authored-by: Dominic <165644294+dominictb@users.noreply.github.com>

hoangzinh added 2 commits October 31, 2025 17:52

Merge branch 'main' into fix/remove-openreport-calls-merge

ea0af18

Fix linter

499b185

dominictb approved these changes Oct 31, 2025

View reviewed changes

melvin-bot bot requested a review from youssef-lr October 31, 2025 14:47

youssef-lr approved these changes Oct 31, 2025

View reviewed changes

youssef-lr merged commit 6cee42f into Expensify:main Oct 31, 2025
26 checks passed

OSBotify mentioned this pull request Nov 3, 2025

Deploy Checklist: New Expensify 2025-11-03 #74140

Closed

54 tasks

luacmartins mentioned this pull request Nov 4, 2025

Revert "Remove openReport calls from the merge transaction flows - Part 1" #74212

Merged

51 tasks

Conversation

hoangzinh commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Oct 27, 2025

Uh oh!

youssef-lr commented Oct 27, 2025

Uh oh!

hoangzinh commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

youssef-lr commented Oct 28, 2025

Uh oh!

hoangzinh commented Oct 29, 2025

Uh oh!

trjExpensify commented Oct 29, 2025

Uh oh!

dominictb commented Oct 29, 2025

Uh oh!

dominictb commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

dominictb commented Oct 30, 2025

Uh oh!

Uh oh!

hoangzinh commented Oct 31, 2025

Uh oh!

dominictb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Oct 31, 2025

Uh oh!

OSBotify commented Nov 3, 2025

Uh oh!

OSBotify commented Nov 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

hoangzinh commented Oct 24, 2025 •

edited

Loading

codecov bot commented Oct 24, 2025 •

edited

Loading

hoangzinh commented Oct 28, 2025 •

edited

Loading

dominictb commented Oct 30, 2025 •

edited

Loading