Submit query lingers on other member when switching accounts via copilot by paulnjs · Pull Request #73511 · Expensify/App

paulnjs · 2025-10-27T04:38:45Z

Explanation of Change

Fixed Issues

$ #72773
PROPOSAL: #72773 (comment)

Tests

Precondition: Setup account A as account B's copilot

Login as account A
Go to Reports
Go Account > Switch to account B
Go to Reports again
Verify that the submit query link to the current user
Switch to account A again
Repeat steps 4-5
Verify that the result is the same

Verify that no errors appear in the JS console

Offline tests

None

QA Steps

Precondition: Setup account A as account B's copilot

Login as account A
Go to Reports
Go Account > Switch to account B
Go to Reports again
Verify that the submit query link to the current user
Switch to account A again
Repeat steps 4-5
Verify that the result is the same

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-10-27.at.11.46.17.mov

Android: mWeb Chrome

Screen.Recording.2025-10-27.at.11.48.40.mov

iOS: Native

Screen.Recording.2025-10-27.at.11.49.37.mov

iOS: mWeb Safari

Screen.Recording.2025-10-27.at.11.51.19.mov

MacOS: Chrome / Safari

Screen.Recording.2025-10-27.at.11.43.56.mov

MacOS: Desktop

Screen.Recording.2025-10-27.at.11.53.57.mov

codecov · 2025-10-27T04:51:08Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/actions/Delegate.ts	`32.18% <0.00%> (-0.38%)`	⬇️
.../createSplitNavigator/usePreserveNavigatorState.ts	`78.57% <25.00%> (-21.43%)`	⬇️
... and 14 files with indirect coverage changes

melvin-bot · 2025-10-27T05:12:24Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jjcoffee · 2025-10-28T15:49:55Z

@paulnjs I think there's a regression here. If you switch quickly back to the Reports page after switching users (before it finishes loading, basically), the Expenses tab loads instead of the Submit tab.

desktop-chrome-regression-2025-10-28_16.43.31.mp4

jjcoffee · 2025-10-30T08:24:18Z

@paulnjs Any thoughts on this?

paulnjs · 2025-10-30T09:32:17Z

I think there's a regression here. If you switch quickly back to the Reports page after switching users (before it finishes loading, basically), the Expenses tab loads instead of the Submit tab.

@jjcoffee I think it's not a problem since we cleared the preserved state then the Expense tab loads while the data is loading. We can see the same behavior if we go to the account tab reload page --> reset cache --> Go Reports quickly --> The Expense tab is also loaded

jjcoffee · 2025-10-30T10:07:55Z

@paulnjs It will be considered a regression since it's a change in behaviour that could potentially be confusing.

paulnjs · 2025-11-03T06:53:36Z

@paulnjs It will be considered a regression since it's a change in behaviour that could potentially be confusing.

In my opinion, the staging behavior is more confusing:

On the staging: User A search a query X --> Switch to user B --> Search page still displays query X --> Switch to user A and open search page quickly --> Search page displays the query X (Submit tab) while this tab isn't loaded. The confusion here is a todo query is displayed while the data is loading and doesn't have enough data to display in the left-hand. This is more confusing on staging if after switching to user B we type any query and then switch back to user A. In this case, the user B query will be displayed on search page after switching back
With our PR: The search page always displays the first default query with the data at this time when switching between accounts

@JS00001 What do you think

JS00001 · 2025-11-03T17:52:54Z

@trjExpensify Which behavior do you prefer?

User A is on submit -> copilots into User B -> navigates to search -> Is landed on User B's submit page
or
User A is on submit -> copilots into User B -> navigates to search -> Is landed on User B's expense page

trjExpensify · 2025-11-04T02:00:43Z

User A is on submit -> copilots into User B -> navigates to search -> Is landed on User B's submit page

This one seems to make more logical sense to me as the topmost LHN row on the Reports page, where you expect to be "first" when you navigate to the Reports tab.

JS00001 · 2025-11-04T12:31:40Z

confusion here is a todo query is displayed while the data is loading and doesn't have enough data to display in the left-hand.

Also, as a heads up, theres a PR being worked on to fix this: #72034

jjcoffee · 2025-11-04T15:19:03Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android-app-2025-11-04_17.11.44.mp4

Android: mWeb Chrome

android-chrome-2025-11-04_17.13.52.mp4

iOS: HybridApp

ios-app-2025-11-04_17.19.12.mp4

iOS: mWeb Safari

ios-safari-2025-11-04_17.22.07.mp4

MacOS: Chrome / Safari

desktop-chrome-2025-11-04_16.27.31.mp4

MacOS: Desktop

desktop-app-2025-11-04_17.04.46.mp4

jjcoffee · 2025-11-04T15:19:53Z

@paulnjs Looks like we're settling on fixing the issue. Can you come up with a fix, or would this depend on #72034?

paulnjs · 2025-11-05T14:52:02Z

@jjcoffee This problem is minor since we need to navigate to Reports quickly, which is an edge case, and it will be fixed here. I think we can move forward here now.

jjcoffee · 2025-11-10T09:51:09Z

@paulnjs As I said, it will be considered a regression, so we can't just ignore it unfortunately! 😄 I think it makes sense for us to wait for #72034 to be merged, so we can be sure it fixes the issue.

jjcoffee · 2025-11-19T12:41:33Z

@paulnjs #72034 has been merged to main, but I see the same issue after merging main to your PR. Could you take a look?

paulnjs · 2025-11-21T04:54:55Z

@jjcoffee Okay, let me investigate more and get back to you

paulnjs · 2025-11-24T17:10:51Z

@jjcoffee I realize that #72034 is reverted. Let me test #75704 and see if the issue still happens or not

paulnjs · 2025-11-26T04:19:43Z

This is what i got when i tested #75704.
@jjcoffee Can we wait for it to be merged

Screen.Recording.2025-11-26.at.11.16.41.mov

jjcoffee · 2025-11-26T09:07:54Z

@paulnjs Isn't that the same bug, just with a different tab? I think we want the Submit tab to load. Or are you saying that PR introduces the same bug as your PR?

paulnjs · 2025-11-27T10:53:41Z

Or are you saying that PR introduces the same bug as your PR?

@jjcoffee Yup, i think that but lemme investigate more to handle it in our PR

paulnjs · 2025-12-01T10:48:03Z

@paulnjs Isn't that the same bug, just with a different tab? I think we want the Submit tab to load. Or are you saying that PR introduces the same bug as your PR?

@jjcoffee After checking this PR, I see the bug we mentioned above was fixed and the default tab will be approve tab instead. The behavior with this PR + our PR is:

User A on a any query tab > switch user B > open Reports > user B is on the user B's default tab > switch back to user A > open Reports > user A is on the user A's default tab

jjcoffee · 2025-12-01T12:50:49Z

@paulnjs Thanks! And what about the behaviour without our PR?

paulnjs · 2025-12-01T14:43:28Z

@paulnjs Thanks! And what about the behaviour without our PR?

@jjcoffee The behavior without our PR is the same but our PR fixed the incorrect link issue

paulnjs · 2025-12-01T14:46:33Z

@jjcoffee #75704 is merged in main and I've already updated out PR as well. Please help to check it when have time. Thanks

joekaufmanexpensify

Good from a product perspective 👍

jjcoffee

LGTM!

desktop-chrome-2025-12-03_10.42.15.mp4

OSBotify · 2025-12-03T12:21:28Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-12-03T15:18:26Z

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.2.71-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-04T15:43:58Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.71-5 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

… improve user experience by making switching between tabs faster and smoother" This reverts commit e6b8cb9, reversing changes made to 3a61ba9.

Submit query lingers on other member when switching accounts via copilot

adde8f6

melvin-bot bot assigned paulnjs Oct 27, 2025

Merge branch 'main' into paulnjs-fix/72773

5de0595

fix error

a509922

paulnjs marked this pull request as ready for review October 27, 2025 05:12

paulnjs requested a review from a team as a code owner October 27, 2025 05:12

melvin-bot bot requested review from jjcoffee and removed request for a team October 27, 2025 05:12

Merge branch 'main' into paulnjs-fix/72773

d0dd395

Merge branch 'main' into paulnjs-fix/72773

cab8c9a

paulnjs requested a review from a team as a code owner December 1, 2025 14:44

melvin-bot bot requested review from joekaufmanexpensify and removed request for a team December 1, 2025 14:44

joekaufmanexpensify approved these changes Dec 1, 2025

View reviewed changes

jjcoffee approved these changes Dec 3, 2025

View reviewed changes

melvin-bot bot requested a review from JS00001 December 3, 2025 09:44

JS00001 approved these changes Dec 3, 2025

View reviewed changes

JS00001 merged commit f2c4211 into Expensify:main Dec 3, 2025
31 checks passed

OSBotify mentioned this pull request Dec 3, 2025

Deploy Checklist: New Expensify 2025-12-03 #76614

Closed

76 tasks

jjcoffee mentioned this pull request Dec 8, 2025

[hold for payment 2025-12-11] [$250] Submit query lingers on other member when switching accounts via copilot #72773

Closed

16 tasks

jjcoffee referenced this pull request Dec 11, 2025

Revert "Use route preloading functionality from react-navigation 7 to…

b17531e

… improve user experience by making switching between tabs faster and smoother" This reverts commit e6b8cb9, reversing changes made to 3a61ba9.

Conversation

paulnjs commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Oct 27, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Oct 27, 2025

Uh oh!

jjcoffee commented Oct 28, 2025

Uh oh!

jjcoffee commented Oct 30, 2025

Uh oh!

paulnjs commented Oct 30, 2025

Uh oh!

jjcoffee commented Oct 30, 2025

Uh oh!

paulnjs commented Nov 3, 2025

Uh oh!

JS00001 commented Nov 3, 2025

Uh oh!

trjExpensify commented Nov 4, 2025

Uh oh!

JS00001 commented Nov 4, 2025

Uh oh!

jjcoffee commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

jjcoffee commented Nov 4, 2025

Uh oh!

paulnjs commented Nov 5, 2025

Uh oh!

jjcoffee commented Nov 10, 2025

Uh oh!

jjcoffee commented Nov 19, 2025

Uh oh!

paulnjs commented Nov 21, 2025

Uh oh!

paulnjs commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

paulnjs commented Nov 26, 2025

Uh oh!

jjcoffee commented Nov 26, 2025

Uh oh!

paulnjs commented Nov 27, 2025

Uh oh!

paulnjs commented Dec 1, 2025

Uh oh!

jjcoffee commented Dec 1, 2025

Uh oh!

paulnjs commented Dec 1, 2025

Uh oh!

paulnjs commented Dec 1, 2025

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

jjcoffee left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Dec 3, 2025

Uh oh!

OSBotify commented Dec 3, 2025

Uh oh!

OSBotify commented Dec 4, 2025

Uh oh!

Reviewers

Assignees

paulnjs commented Oct 27, 2025 •

edited

Loading

codecov bot commented Oct 27, 2025 •

edited by github-actions bot

Loading

jjcoffee commented Nov 4, 2025 •

edited

Loading

paulnjs commented Nov 24, 2025 •

edited

Loading