fix: footer text flickers in expensify card list#73642
Merged
carlosmiceli merged 3 commits intoExpensify:mainfrom Nov 3, 2025
Merged
fix: footer text flickers in expensify card list#73642carlosmiceli merged 3 commits intoExpensify:mainfrom
carlosmiceli merged 3 commits intoExpensify:mainfrom
Conversation
Codecov Report❌ Patch coverage is
... and 274 files with indirect coverage changes 🚀 New features to boost your workflow:
|
rojiphil
reviewed
Oct 29, 2025
src/pages/workspace/expensifyCard/WorkspaceExpensifyCardListPage.tsx
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Waiting for the next review here @rojiphil |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp73642-android-hybrid-001.mp4Android: mWeb Chrome73642-mweb-chrome-002.mp4iOS: HybridApp73642-ios-hybrid-001.mp4iOS: mWeb Safari73642-mweb-safari-002.mp4MacOS: Chrome / Safari73642-web-chrome-001.mp4MacOS: Desktop73642-desktop-001.mp4 |
rojiphil
approved these changes
Nov 3, 2025
Contributor
rojiphil
left a comment
There was a problem hiding this comment.
Thanks @daledah for the PR.
@carlosmiceli Changes LGTM and works well too.
All yours. Thanks.
carlosmiceli
approved these changes
Nov 3, 2025
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
54 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.2.43-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.43-2 🚀
|
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #73135
PROPOSAL: #73135 (comment)
Tests
Precondition
Offline tests
QA Steps
Precondition
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-10-29.at.02.19.37.mov
Android: mWeb Chrome
Screen.Recording.2025-10-29.at.02.21.18.mov
iOS: Native
Screen.Recording.2025-10-29.at.02.21.57.mov
iOS: mWeb Safari
Screen.Recording.2025-10-29.at.02.22.25.mov
MacOS: Chrome / Safari
Screen.Recording.2025-10-29.at.02.22.47.mov
MacOS: Desktop
Screen.Recording.2025-10-29.at.02.23.17.mov