Skip to content

Fix for losing focus when clicking outside of the input with symbol #73671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amyevans merged 4 commits into from
Oct 31, 2025
Merged

Fix for losing focus when clicking outside of the input with symbol #73671

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fc23396
refactor: Simplify layout structure in NumberWithSymbolForm component
kubabutkiewicz Oct 28, 2025
757b402
Revert "refactor: Simplify layout structure in NumberWithSymbolForm c…
kubabutkiewicz Oct 30, 2025
23d3f14
fixed layout of the number with symbol form
kubabutkiewicz Oct 30, 2025
8f38cff
fix lint
kubabutkiewicz Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 20 additions & 22 deletions src/components/NumberWithSymbolForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,30 +459,28 @@ function NumberWithSymbolForm({
<View
id={NUMBER_VIEW_ID}
onMouseDown={(event) => focusTextInput(event, [NUMBER_VIEW_ID])}
style={[styles.moneyRequestAmountContainer, styles.flexRow, styles.w100, styles.alignItemsCenter, styles.justifyContentCenter]}
style={[styles.flex1, styles.w100, styles.alignItemsCenter, styles.justifyContentCenter]}
>
{textInputComponent}
<View style={[styles.flexRow, styles.moneyRequestAmountContainer, styles.alignItemsCenter, styles.justifyContentCenter]}>{textInputComponent}</View>
{isSymbolPressable && !!currency && !canUseTouchScreen && (
<Button
shouldShowRightIcon
small
iconRight={Expensicons.DownArrow}
onPress={onSymbolButtonPress}
style={styles.minWidth18}
isContentCentered
text={currency}
/>
)}
{!!errorText && (
<FormHelpMessage
style={[styles.pAbsolute, styles.b0, shouldShowBigNumberPad ? styles.mb0 : styles.mb3, styles.ph5, styles.w100]}
isError
message={errorText}
/>
)}
</View>

{isSymbolPressable && !!currency && !canUseTouchScreen && (
<Button
shouldShowRightIcon
small
iconRight={Expensicons.DownArrow}
onPress={onSymbolButtonPress}
style={styles.minWidth18}
isContentCentered
text={currency}
/>
)}

{!!errorText && (
<FormHelpMessage
style={[styles.pAbsolute, styles.b0, shouldShowBigNumberPad ? styles.mb0 : styles.mb3, styles.ph5, styles.w100]}
isError
message={errorText}
/>
)}
</View>
) : (
textInputComponent
Expand Down
Loading