Add Split to the select menu when 1 expense is selected, editable and not the child of an existing Split expense by ZhenjaHorbach · Pull Request #73855 · Expensify/App

ZhenjaHorbach · 2025-10-30T15:11:58Z

Explanation of Change

[Splits in NewDot] Add Split to the select menu when 1 expense is selected, editable and not the child of an existing Split expense

Fixed Issues

$ #73669
PROPOSAL:

Tests

Open App
Create an expense in any Workspace
Open Reports screen and select the checkbox next to the expense (this should work the same in the report view and the Reports page view)
Click 1 selected
Verify that:

Submitters and assigned approvers can split expenses that they can edit.
Admins can split expenses on Draft and Processing reports.
Non-editable expenses include pending Expensify Card expenses and Expensiworks expenses for all users.
Users should not see the Split option in the 1 selected menu for portions of expenses that have already been split.
Users should not see the Split option in the 2 or more selected menu
Verify that no errors appear in the JS console

Offline tests

QA Steps

Open App
Create an expense in any Workspace
Open Reports screen and select the checkbox next to the expense (this should work the same in the report view and the Reports page view)
Click 1 selected
Verify that:

Submitters and assigned approvers can split expenses that they can edit.
Admins can split expenses on Draft and Processing reports.
Non-editable expenses include pending Expensify Card expenses and Expensiworks expenses for all users.
Users should not see the Split option in the 1 selected menu for portions of expenses that have already been split.
Users should not see the Split option in the 2 or more selected menu
Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

2025-11-07.14.11.46.mov

Android: mWeb Chrome

2025-11-07.14.13.33.mov

iOS: Native

2025-11-07.14.09.08.mov

iOS: mWeb Safari

2025-11-07.14.09.08.mov

MacOS: Chrome / Safari

2025-11-07.13.44.45.mov

MacOS: Desktop

2025-11-07.13.44.45.mov

codecov · 2025-10-30T15:23:53Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`85.84% <ø> (ø)`
src/hooks/useAllTransactions.ts	`100.00% <100.00%> (ø)`
src/hooks/useSelectedTransactionsActions.ts	`85.29% <100.00%> (+81.08%)`	⬆️
src/libs/ReportSecondaryActionUtils.ts	`92.43% <100.00%> (+0.27%)`	⬆️
src/libs/actions/IOU.ts	`63.95% <100.00%> (-0.27%)`	⬇️
src/hooks/useDeleteTransactions.ts	`18.75% <0.00%> (ø)`
src/pages/Search/SearchPage.tsx	`25.71% <16.66%> (-0.27%)`	⬇️
src/pages/iou/SplitExpensePage.tsx	`0.00% <0.00%> (ø)`
src/components/Search/index.tsx	`32.76% <0.00%> (-1.24%)`	⬇️
src/pages/iou/SplitExpenseEditPage.tsx	`0.00% <0.00%> (ø)`
... and 8 files with indirect coverage changes

melvin-bot · 2025-11-11T12:49:53Z

@eh2077 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

trjExpensify

Core PR for a #whatsnext project, all good. 👍

eh2077 · 2025-11-12T14:18:40Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-12-09.at.6.03.54.PM.mov

Android: mWeb Chrome

Screen.Recording.2025-12-09.at.6.03.15.PM.mov

iOS: HybridApp

Screen.Recording.2025-12-09.at.6.04.25.PM.mov

iOS: mWeb Safari

Screen.Recording.2025-12-09.at.6.04.56.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-12-09.at.5.49.26.PM.mov

eh2077 · 2025-11-12T14:43:07Z

src/components/Search/index.tsx

-function prepareTransactionsList(item: TransactionListItemType, selectedTransactions: SelectedTransactions, outstandingReportsByPolicyID?: OutstandingReportsByPolicyIDDerivedValue) {
+function prepareTransactionsList(
+    item: TransactionListItemType,
+    transaction: OnyxEntry<Transaction>,


Hmm, maybe naming can be better, like itemTransaction

eh2077 · 2025-11-12T14:57:46Z

src/hooks/useSelectedTransactionsActions.ts

+        const {isExpenseSplit} = getOriginalTransactionWithSplitInfo(selectedTransactionsList.at(0));
+        const canSplitTransaction = selectedTransactionsList.length === 1 && report && !isExpenseSplit && isSplitAction(report, selectedTransactionsList, policy);


In the Search component, transaction item prop canSplit is equal to isSplitAction. Why not use isSplitAction too? Or what's the nuance here?

These screens don't work the same way
Including search context, which uses differently
Plus, all the buttons on useSelectedTransactionsActions (hold,unhold, merge) don't use context data as SearchPage

eh2077 · 2025-11-12T16:27:17Z

Bug: Mobile - Split option is missing until open transaction thread

clear cache and restart
open Reports => Reports
select a draft expense and click selected button - there's no Split option
cancel select, open the expense transaction and go back to Reports => Reports
select the draft expense again and click select button - the Split button is available

Screen.Recording.2025-11-13.at.12.20.55.AM.mov

ZhenjaHorbach · 2025-11-13T09:58:10Z

@eh2077
Could you provide more information about this issue, please?
Or onyx data, for example

2025-11-13.10.57.11.mov

eh2077 · 2025-11-14T12:35:46Z

The ws chat has 4 reports

two outstanding expenses
one draft expense
one approved expense
two draft expenses (split expense)

I reproduced the issue with the second report

eh2077 · 2025-11-14T13:03:17Z

@ZhenjaHorbach I can reproduce on browser too. I think it's possibly related to lazy loading of transaction data.

Screen.Recording.2025-11-14.at.8.57.04.PM.mov

lakchote · 2025-12-09T06:29:19Z

@eh2077 can you review latest changes please?

eh2077 · 2025-12-09T09:28:45Z

yeah, I'm working on this and will update shortly. @ZhenjaHorbach please help with conflicts, thank you!

eh2077 · 2025-12-09T09:59:56Z

I spotted another bug that isn't related to this PR

Bug: Delete split expense from Reports > Expenses doesn't auto reverse split to normal expense

Screen.Recording.2025-12-09.at.5.56.06.PM.mov

eh2077

Looks good! Checklist #73855 (comment) completed, so 👍 from me once conflicts are resolved.

ZhenjaHorbach · 2025-12-09T12:27:43Z

@eh2077
I fixed conflicts

eh2077

LGTM 🚀

melvin-bot · 2025-12-09T12:31:17Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #73669 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

github-actions · 2025-12-09T17:20:47Z

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-12-09T17:53:02Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #73855.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/73855/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/73855/index.html

Desktop 💻	Web 🕸️
⏩ SKIPPED ⏩	https://73855.pr-testing.expensify.com
The build for Desktop was skipped

👀 View the workflow run that generated this build 👀

OSBotify · 2025-12-09T19:31:36Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-12-10T22:04:59Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.2.75-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2025-12-10T23:58:13Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.2.75-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-12T19:00:06Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.2.77-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2025-12-12T22:05:20Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.77-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

shubham1206agra · 2025-12-26T13:42:42Z

src/pages/iou/SplitExpenseEditPage.tsx

-    const reportName = getReportName(report, policy);
-    const isDescriptionRequired = isCategoryDescriptionRequired(policyCategories, splitExpenseDraftTransactionDetails?.category, policy?.areRulesEnabled);
+    const isCategoryRequired = !!currentPolicy?.requiresCategory;
+    const reportName = computeReportName(currentReport);


@ZhenjaHorbach Can you please use derived value instead of using computeReportName to compute report name from scratch?

Add main changes

22d5ece

melvin-bot bot assigned ZhenjaHorbach Oct 30, 2025

ZhenjaHorbach added 8 commits October 30, 2025 16:31

Fix tests

581a010

Fix conflicts

677698e

Refactor code

52a4081

Fix small issues

990dbba

Update comment

d0ed8b2

Add tests for useSelectedTransactionsActions

580addf

Fix prettier issues

f11c473

Fix tests

a55d030

ZhenjaHorbach marked this pull request as ready for review November 11, 2025 12:49

ZhenjaHorbach requested review from a team as code owners November 11, 2025 12:49

melvin-bot bot requested review from eh2077 and removed request for a team November 11, 2025 12:49

melvin-bot bot requested review from trjExpensify and removed request for a team November 11, 2025 12:49

trjExpensify previously approved these changes Nov 11, 2025

View reviewed changes

eh2077 reviewed Nov 12, 2025

View reviewed changes

Fix conflicts

3f71d27

ZhenjaHorbach dismissed trjExpensify’s stale review via 3f71d27 November 13, 2025 09:30

Fix comments

5d84911

Fix conflicts

afefa95

ZhenjaHorbach added 2 commits December 5, 2025 14:50

Make clearSelectedTransactions call more consistent with other places

a8791d7

Fix conflicts

d76346c

Fix conflicts

961ce82

eh2077 reviewed Dec 9, 2025

View reviewed changes

ZhenjaHorbach and others added 4 commits December 9, 2025 11:16

Merge branch 'Expensify:main' into main

a707983

Merge branch 'main' into add-split-to-select-search-menu

1bc3d43

Update tests

0a87093

Update tests x2

962f3d3

eh2077 approved these changes Dec 9, 2025

View reviewed changes

melvin-bot bot requested a review from Julesssss December 9, 2025 12:31

Julesssss approved these changes Dec 9, 2025

View reviewed changes

Julesssss merged commit 583bda5 into Expensify:main Dec 9, 2025
31 checks passed

OSBotify mentioned this pull request Dec 10, 2025

Deploy Checklist: New Expensify 2025-12-10 #77285

Closed

94 tasks

jponikarchuk mentioned this pull request Dec 11, 2025

[$250] Android - Reports - Menu is not scrollable, Delete button is partially blocked by navigation bar #77376

Closed

8 tasks

melvin-bot bot mentioned this pull request Dec 12, 2025

[$250] [Due for payment 2025-12-19] [Splits in NewDot] Add Split to the select menu when 1 expense is selected, editable and not the child of an existing Split expense #73669

Closed

8 tasks

shubham1206agra reviewed Dec 26, 2025

View reviewed changes

		const {isExpenseSplit} = getOriginalTransactionWithSplitInfo(selectedTransactionsList.at(0));
		const canSplitTransaction = selectedTransactionsList.length === 1 && report && !isExpenseSplit && isSplitAction(report, selectedTransactionsList, policy);

Conversation

ZhenjaHorbach commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Oct 30, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Nov 11, 2025

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

eh2077 commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eh2077 Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

eh2077 Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

eh2077 commented Nov 12, 2025

Uh oh!

ZhenjaHorbach commented Nov 13, 2025

Uh oh!

eh2077 commented Nov 14, 2025

Uh oh!

eh2077 commented Nov 14, 2025

Uh oh!

lakchote commented Dec 9, 2025

Uh oh!

eh2077 commented Dec 9, 2025

Uh oh!

eh2077 commented Dec 9, 2025

Uh oh!

eh2077 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach commented Dec 9, 2025

Uh oh!

eh2077 left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Dec 9, 2025

Uh oh!

github-actions bot commented Dec 9, 2025

Uh oh!

github-actions bot commented Dec 9, 2025

Uh oh!

Uh oh!

OSBotify commented Dec 9, 2025

Uh oh!

OSBotify commented Dec 10, 2025

Uh oh!

OSBotify commented Dec 10, 2025

Uh oh!

OSBotify commented Dec 12, 2025

Uh oh!

OSBotify commented Dec 12, 2025

Uh oh!

shubham1206agra Dec 26, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

ZhenjaHorbach commented Oct 30, 2025 •

edited

Loading

codecov bot commented Oct 30, 2025 •

edited by github-actions bot

Loading

eh2077 commented Nov 12, 2025 •

edited

Loading

eh2077 left a comment •

edited

Loading