Skip to content

[CP Staging] Revert "Allow rejecting expenses in bulk in NewDot"#73871

Merged
puneetlath merged 1 commit intomainfrom
revert-72855-lucien/reject-bulk-action
Oct 30, 2025
Merged

[CP Staging] Revert "Allow rejecting expenses in bulk in NewDot"#73871
puneetlath merged 1 commit intomainfrom
revert-72855-lucien/reject-bulk-action

Conversation

@lakchote
Copy link
Copy Markdown
Contributor

Reverts #72855

@lakchote lakchote self-assigned this Oct 30, 2025
@lakchote lakchote requested a review from a team as a code owner October 30, 2025 17:17
@lakchote lakchote changed the title Revert "Allow rejecting expenses in bulk in NewDot" [CP Staging] Revert "Allow rejecting expenses in bulk in NewDot" Oct 30, 2025
@melvin-bot melvin-bot bot requested review from mollfpr and removed request for a team October 30, 2025 17:18
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Oct 30, 2025

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@OSBotify
Copy link
Copy Markdown
Contributor

🦜 Polyglot Parrot! 🦜

Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues:

View the translation diff
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 6126c2f1..731fa067 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -4420,7 +4420,6 @@ ${amount} dla ${merchant} - ${date}`,
             displayedAsTagDescription: 'Dział będzie można wybrać dla każdego indywidualnego wydatku w raporcie pracownika.',
             displayedAsReportFieldDescription: 'Wybór działu będzie dotyczył wszystkich wydatków w raporcie pracownika.',
             toggleImportTitle: ({mappingTitle}: ToggleImportTitleParams) => `Wybierz, jak obsługiwać Sage Intacct <strong>${mappingTitle}</strong> w Expensify.`,
-
             expenseTypes: 'Typy wydatków',
             expenseTypesDescription: 'Twoje typy wydatków Sage Intacct zostaną zaimportowane do Expensify jako kategorie.',
             accountTypesDescription: 'Twój plan kont Sage Intacct zostanie zaimportowany do Expensify jako kategorie.',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 22dc29f8..16eb03ff 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -4419,7 +4419,6 @@ ${amount} para ${merchant} - ${date}`,
             displayedAsTagDescription: 'O departamento será selecionável para cada despesa individual no relatório de um funcionário.',
             displayedAsReportFieldDescription: 'A seleção de departamento será aplicada a todas as despesas no relatório de um funcionário.',
             toggleImportTitle: ({mappingTitle}: ToggleImportTitleParams) => `Escolha como lidar com o Sage Intacct <strong>${mappingTitle}</strong> in Expensify.`,
-
             expenseTypes: 'Tipos de despesas',
             expenseTypesDescription: 'Seus tipos de despesas do Sage Intacct serão importados para o Expensify como categorias.',
             accountTypesDescription: 'Seu plano de contas do Sage Intacct será importado para o Expensify como categorias.',
@@ -7344,7 +7343,6 @@ ${amount} para ${merchant} - ${date}`,
         exportInProgress: 'Exportação em andamento',
         conciergeWillSend: 'Concierge enviará o arquivo em breve.',
     },
-
     avatarPage: {
         title: 'Editar foto de perfil',
         upload: 'Carregar',

Note

You can apply these changes to your branch by copying the patch to your clipboard, then running pbpaste | git apply 😉

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/libs/actions/IOU.ts 50.00% 1 Missing ⚠️
src/pages/Search/SearchHoldReasonPage.tsx 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/CONST/index.ts 85.71% <ø> (ø)
src/ROUTES.ts 11.00% <ø> (ø)
src/SCREENS.ts 100.00% <ø> (ø)
...gation/AppNavigator/ModalStackNavigators/index.tsx 8.33% <ø> (+0.02%) ⬆️
...avigation/linkingConfig/RELATIONS/SEARCH_TO_RHP.ts 100.00% <ø> (ø)
src/libs/Navigation/linkingConfig/config.ts 75.00% <ø> (ø)
src/libs/actions/Search.ts 11.68% <ø> (+0.47%) ⬆️
src/pages/Search/SearchPage.tsx 0.00% <ø> (ø)
src/pages/iou/RejectReasonFormView.tsx 0.00% <ø> (ø)
src/libs/actions/IOU.ts 63.49% <50.00%> (-0.29%) ⬇️
... and 1 more

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@puneetlath puneetlath merged commit 7a97646 into main Oct 30, 2025
27 of 31 checks passed
@puneetlath puneetlath deleted the revert-72855-lucien/reject-bulk-action branch October 30, 2025 17:47
@melvin-bot melvin-bot bot added the Emergency label Oct 30, 2025
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Oct 30, 2025

@puneetlath looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@puneetlath
Copy link
Copy Markdown
Contributor

Merged without checklists since it's a straight revert to fix deploy blocker.

OSBotify pushed a commit that referenced this pull request Oct 30, 2025
…ulk-action

[CP Staging] Revert "Allow rejecting expenses in bulk in NewDot"

(cherry picked from commit 7a97646)

(cherry-picked to staging by puneetlath)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Oct 30, 2025
@OSBotify
Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.2.41-3 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 9.2.41-6 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.2.42-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Nov 3, 2025

🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.42-11 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants