Skip to content

Add itemized receipt requirement settings for workspace and category rules#73939

Merged
dangrous merged 54 commits intoExpensify:mainfrom
abzokhattab:feature/itemized-receipt-requirements
Jan 26, 2026
Merged

Add itemized receipt requirement settings for workspace and category rules#73939
dangrous merged 54 commits intoExpensify:mainfrom
abzokhattab:feature/itemized-receipt-requirements

Conversation

@abzokhattab
Copy link
Contributor

@abzokhattab abzokhattab commented Oct 31, 2025

Explanation of Change

Adding a new rule: itemized receipt required

Fixed Issues

$ #73780
PROPOSAL:

Tests

Prerequisites

  • Control workspace with Rules enabled
  • Receipt required threshold set to $20

Test 1: Workspace Level - Set Itemized Receipt Threshold
Steps:

  1. Go to Workspace > Rules
  2. Tap "Itemized receipt required over"
  3. Change amount to $50.00, tap Save
  4. Try changing to $15.00 (below receipt required $20)

Validate:

  • Amount updates to $50.00 after save
  • Error appears when setting below receipt required amount

Test 2: Category Level - Override Options
Steps:

  1. Go to Workspace > Categories > Select any category
  2. Tap "Require itemized receipts over"
  3. Select "Never require itemized receipts", Save

Validate:

  • Selection persists after save
  • Category settings page shows updated value

Test 3: Violation Triggers Correctly
Steps:

  1. Create expense: $100, attach non-itemized receipt
  2. Create expense: $100, no receipt attached
  3. Create expense: $100, category with "Never require" override

Validate:

  • Expense 1 shows violation: "Itemized receipt required over $50.00"
  • Expense 2 shows violation: "Itemized receipt required over $50.00"
  • Expense 3 shows NO itemized receipt violation

Test 4: Category "Always Require" at Any Amount
Steps:

  1. Set category to "Always require itemized receipts"
  2. Create expense: $10, attach non-itemized receipt, assign that category

Validate:

  • Shows itemized receipt violation even for $10 expense

Offline tests

Same as tests

QA Steps

Same as tests

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2025-12-17.at.03.05.03.mov
Android: mWeb Chrome
Screen.Recording.2025-12-17.at.03.10.50.mov
iOS: Native
Screen.Recording.2025-12-17.at.03.04.11.mov
iOS: mWeb Safari
Screen.Recording.2025-12-17.at.02.41.35.mov
MacOS: Chrome / Safari
Screen.Recording.2025-12-17.at.01.50.50.mov
Screen.Recording.2025-12-17.at.02.10.40.mov

@melvin-bot
Copy link

melvin-bot bot commented Oct 31, 2025

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@github-actions
Copy link
Contributor

LGTM :feelsgood:. Thank you for your hard work!

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/CONST/index.ts 83.89% <ø> (+0.13%) ⬆️
src/ONYXKEYS.ts 100.00% <ø> (ø)
src/SCREENS.ts 100.00% <ø> (ø)
...m/TransactionPreview/TransactionPreviewContent.tsx 76.08% <ø> (ø)
src/libs/API/types.ts 100.00% <ø> (ø)
...gation/linkingConfig/RELATIONS/WORKSPACE_TO_RHP.ts 100.00% <ø> (ø)
src/libs/Navigation/linkingConfig/config.ts 75.00% <ø> (ø)
src/libs/TransactionPreviewUtils.ts 73.22% <100.00%> (+0.03%) ⬆️
src/libs/actions/Policy/Policy.ts 34.80% <100.00%> (+0.43%) ⬆️
src/hooks/useViolations.ts 50.76% <0.00%> (+47.64%) ⬆️
... and 16 more
... and 111 files with indirect coverage changes

@abzokhattab
Copy link
Contributor Author

@dangrous I opened a darft PR here ... there are way more changes than I expected 😂 ... I will be testing it over the next few days hopefully i get it done this week

@abzokhattab
Copy link
Contributor Author

still testing ...

@abzokhattab
Copy link
Contributor Author

@dangrous After spending some time and some trial and error

We are finally seeing the light; the first test passed 🎉

Screen.Recording.2025-11-16.at.21.25.16.mov

Now I am just waiting for the backend changes to hit prod to complete the checklist

@dangrous
Copy link
Contributor

Awesome!!

@abzokhattab
Copy link
Contributor Author

Great... waiting for the backend to be deployed to make the final integration

@dangrous
Copy link
Contributor

All the BE code is now merged, just waiting on deploy!

@abzokhattab
Copy link
Contributor Author

Great! Could you please let me know what the endpoints are and share any documentation available for them?

@dangrous
Copy link
Contributor

dangrous commented Nov 20, 2025

Sure:

  • SetPolicyExpenseMaxAmountNoItemizedReceipt takes
    • maxExpenseAmountNoItemizedReceipt (the amount chosen)
    • policyID
  • SetPolicyCategoryItemizedReceiptsRequired takes
    • maxExpenseAmountNoItemizedReceipt (the amount chosen)
    • policyID
    • categoryName
    • lastModified
  • RemoveWorkspaceCategoryItemizedReceiptsRequired takes
    • policyID
    • categoryName
    • lastModified

Basically it should be exactly the same as the existing [...]NoReceipt and [...]ReceiptsRequired commands/parameters.

Let me know how that works for you and if I need to make any updates!

@abzokhattab
Copy link
Contributor Author

Basically it should be exactly the same as the existing [...]NoReceipt and [...]ReceiptsRequired commands/parameters.

looking at those commands i see that they dont havve the lastModified what is the value of this param?

@abzokhattab
Copy link
Contributor Author

abzokhattab commented Nov 22, 2025

@dangrous There is a backend issue where, the backend is still responding with receiptRequired on creating or submitting an expense that has an itemized error:

here is the case with multiple expenses per report :

Screen.Recording.2025-11-22.at.19.30.03.mov

and for single expenses

Screen.Recording.2025-11-22.at.19.30.41.mov

@JmillsExpensify
Copy link
Contributor

@dangrous thoughts on that last comment?

@dangrous
Copy link
Contributor

Ah so sorry, missed this entirely! Will look momentarily

@dangrous
Copy link
Contributor

hey @abzokhattab so sorry for the delay! I believe that is correct behavior, since the workspace settings are configured so you need a receipt over 3 euro, which all of those expenses are - and they don't currently have receipts. The best way to test would be to add a receipt that is NOT itemized, otherwise it's always going to trigger the "receipt required" violation first (and we only display one at a time there)

@dangrous
Copy link
Contributor

dangrous commented Jan 20, 2026

I've been testing this and it looks great. I ran into a couple of issues with test 3 and 4 that I want to clarify if it's the receipt being incorrectly set as itemized or the violation not flagging the missing itemized receipt. Is there something I can search for in the JS console of the expense to see if the receipt was marked as itemised or not by AZ?

While @abzokhattab is investigating, @heyjennahay you can also do the following in Old Dot:

  • Open the report, then the expense in the reports view.

  • Open the console, and type g_megaEdit

  • In the object, look for the data here - expense > receiptObject > details > smartscan > lineItems

  • In theory, if it itemized the receipt you should see something like the following: image

  • If not, either lineItems won't be there at all, or be empty

@heyjennahay
Copy link
Contributor

heyjennahay commented Jan 21, 2026

Here are two examples. They're from the same supermarket and is a "short" receipt saying X items (stucks) + date + amount

PXL_20260120_184223664 MP
PXL_20260120_211637269 MP

@dangrous has said they are being flagged as itemised so I don't think it's an issue with the logic

@dangrous
Copy link
Contributor

Yeah @abzokhattab I think that's something we can play around with the prompt for, as long as it's the parsing and not the violation logic that's the issue we should be good for this, but please confirm.

(Might as well handle the conflicts now too, I guess?)

Any other feedback other than those issues @heyjennahay ?

@abzokhattab
Copy link
Contributor Author

i tested both cases, and they are working for me

Screen.Recording.2026-01-22.at.23.36.20.mov
Screen.Recording.2026-01-22.at.23.42.22.mov

@abzokhattab
Copy link
Contributor Author

@dangrous also resolved the conflicts

dangrous
dangrous previously approved these changes Jan 23, 2026
@heyjennahay
Copy link
Contributor

Nope everything looks good to me. Nice work guys!

heyjennahay
heyjennahay previously approved these changes Jan 23, 2026
Copy link
Contributor

@heyjennahay heyjennahay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Product change LGMT

@melvin-bot melvin-bot bot requested a review from dangrous January 24, 2026 06:31
@abzokhattab abzokhattab dismissed stale reviews from heyjennahay and dangrous via 8f29b90 January 24, 2026 22:11
@dangrous
Copy link
Contributor

Let's do it! Thanks for the great work. We'll watch this over the next couple of days to see if there's any weirdness...

@dangrous dangrous merged commit 60c8ce9 into Expensify:main Jan 26, 2026
30 checks passed
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/dangrous in version: 9.3.9-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.9-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants