[NoQA] Revert "[No QA] Send fullstory session id to Sentry"#73982
[NoQA] Revert "[No QA] Send fullstory session id to Sentry"#73982
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| getChatFSClass: jest.fn(), | ||
| init: jest.fn(), | ||
| onReady: jest.fn().mockResolvedValue(undefined), | ||
| onReady: jest.fn(), |
There was a problem hiding this comment.
❌ Incomplete Revert - Mock Return Type Mismatch
Issue: The revert changes onReady: jest.fn().mockResolvedValue(undefined) to onReady: jest.fn(), but this creates a type mismatch.
Problem:
- The actual
onReadyimplementation insrc/libs/Fullstory/index.native.tsreturnsPromise.resolve() - The type definition in
src/libs/Fullstory/types.tsdeclaresonReady: () => Promise<unknown> - After this revert, the mock will return
undefinedinstead of a Promise, breaking any tests that call.then()on it
Suggested fix: Change line 20 to maintain Promise compatibility:
onReady: jest.fn().mockResolvedValue(undefined),Or if reverting to a previous state that didn't need a resolved promise, verify that's the correct historical behavior.
|
LGTM 👍 Thank you for your hard work! |
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Straight revert to fix the crash on web https://expensify.slack.com/archives/C01GTK53T8Q/p1761955541563179
|
@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
mountiny
changed the title
|
LGTM |
. Thank you for your hard work!
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.43-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.43-2 🚀
|
3 participants
Reverts #73843