Skip to content

Revert "Updates to leave or remove from workspace workflows"#74075

Closed
lakchote wants to merge 1 commit intomainfrom
revert-58345-56750-leave-or-remove-workspace-restrictions
Closed

Revert "Updates to leave or remove from workspace workflows"#74075
lakchote wants to merge 1 commit intomainfrom
revert-58345-56750-leave-or-remove-workspace-restrictions

Conversation

@lakchote
Copy link
Contributor

@lakchote lakchote commented Nov 3, 2025

Reverts #58345

@OSBotify
Copy link
Contributor

OSBotify commented Nov 3, 2025

🦜 Polyglot Parrot! 🦜

Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues:

View the translation diff
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 363373df..8dadc865 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -4420,7 +4420,6 @@ ${amount} dla ${merchant} - ${date}`,
             displayedAsTagDescription: 'Dział będzie można wybrać dla każdego indywidualnego wydatku w raporcie pracownika.',
             displayedAsReportFieldDescription: 'Wybór działu będzie dotyczył wszystkich wydatków w raporcie pracownika.',
             toggleImportTitle: ({mappingTitle}: ToggleImportTitleParams) => `Wybierz, jak obsługiwać Sage Intacct <strong>${mappingTitle}</strong> w Expensify.`,
-
             expenseTypes: 'Typy wydatków',
             expenseTypesDescription: 'Twoje typy wydatków Sage Intacct zostaną zaimportowane do Expensify jako kategorie.',
             accountTypesDescription: 'Twój plan kont Sage Intacct zostanie zaimportowany do Expensify jako kategorie.',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 7fd466c6..1c4fa2f9 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -4419,7 +4419,6 @@ ${amount} para ${merchant} - ${date}`,
             displayedAsTagDescription: 'O departamento será selecionável para cada despesa individual no relatório de um funcionário.',
             displayedAsReportFieldDescription: 'A seleção de departamento será aplicada a todas as despesas no relatório de um funcionário.',
             toggleImportTitle: ({mappingTitle}: ToggleImportTitleParams) => `Escolha como lidar com o Sage Intacct <strong>${mappingTitle}</strong> in Expensify.`,
-
             expenseTypes: 'Tipos de despesas',
             expenseTypesDescription: 'Seus tipos de despesas do Sage Intacct serão importados para o Expensify como categorias.',
             accountTypesDescription: 'Seu plano de contas do Sage Intacct será importado para o Expensify como categorias.',
@@ -7351,7 +7350,6 @@ ${amount} para ${merchant} - ${date}`,
         exportInProgress: 'Exportação em andamento',
         conciergeWillSend: 'Concierge enviará o arquivo em breve.',
     },
-
     avatarPage: {
         title: 'Editar foto de perfil',
         upload: 'Carregar',

Note

You can apply these changes to your branch by copying the patch to your clipboard, then running pbpaste | git apply 😉

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

🚧 @lakchote has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

LGTM 👍 Thank you for your hard work!

@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

❌ Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pages/workspace/WorkspaceOverviewPage.tsx 0.00% 4 Missing ⚠️
src/pages/workspace/WorkspacesListPage.tsx 75.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
...s/workspace/members/WorkspaceMemberDetailsPage.tsx 0.00% <ø> (ø)
src/pages/workspace/WorkspacesListPage.tsx 54.28% <75.00%> (-20.57%) ⬇️
src/pages/workspace/WorkspaceOverviewPage.tsx 0.00% <0.00%> (ø)

... and 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #74075.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/74075/index.html https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/74075/index.html
Android iOS
Desktop 💻 Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/74075/NewExpensify.dmg https://74075.pr-testing.expensify.com
Desktop Web

👀 View the workflow run that generated this build 👀

@lakchote lakchote closed this Nov 3, 2025
@lakchote
Copy link
Contributor Author

lakchote commented Nov 3, 2025

Fixed by #74077

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants