Autocomplete test drive task by ShridharGoel · Pull Request #74106 · Expensify/App

ShridharGoel · 2025-11-03T17:57:49Z

Explanation of Change

After finishing the test drive flow and pressing Get Started, the onboarding checklist still shows “Take a test drive” as incomplete. This change fixes the issue.

Fixed Issues

$ #71688
PROPOSAL: #71688 (comment)

Tests

Navigate to the app.
Login with a new account.
Select "Manage my team's expenses" during onboarding.
Continue till the test drive modal shows.
Select Take a test drive > click Get started
In the test drive, click Get started
After completing the “Take us for a test drive” flow, the "Take a test drive" task should be automatically marked as completed.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

TestDrive.mov

Android: mWeb Chrome

Screen.Recording.2025-11-03.at.11.15.34.PM.mov

iOS: Native

Simulator.Screen.Recording.-.iPhone.16.Plus.-.2025-11-03.at.22.59.46.mov

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.16.Plus.-.2025-11-03.at.23.01.54.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-11-03.at.10.41.00.PM.mov

MacOS: Desktop

Screen.Recording.2025-11-03.at.11.27.25.PM.mov

melvin-bot · 2025-11-03T17:57:55Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2025-11-03T17:59:20Z

src/components/TestDrive/TestDriveDemo.tsx

+        InteractionManager.runAfterInteractions(() => {
+            completeTestDriveTask(viewTourTaskReport, viewTourTaskParentReport, isViewTourTaskParentReportArchived, currentUserPersonalDetails.accountID);
+        });
+    }, [viewTourTaskReport, viewTourTaskParentReport, isViewTourTaskParentReportArchived, currentUserPersonalDetails.accountID, completeTestDriveTask]);


❌ PERF-6 (docs)

The dependency array includes the entire viewTourTaskReport object, but the hook only uses viewTourTaskReport.stateNum in the conditional check. Passing entire objects as dependencies causes the effect to re-execute whenever any property changes, even unrelated ones.

Suggested fix:

}, [viewTourTaskReport?.stateNum, viewTourTaskParentReport, isViewTourTaskParentReportArchived, currentUserPersonalDetails.accountID]);

Additionally, completeTestDriveTask is a stable function imported from an action module and should not be included in the dependency array as it never changes.

codecov · 2025-11-03T18:19:27Z

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/components/TestDrive/TestDriveDemo.tsx	0.00%	1 Missing ⚠️

Files with missing lines	Coverage Δ
src/components/TestDrive/TestDriveDemo.tsx	`6.66% <0.00%> (+3.21%)`	⬆️

... and 18 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

situchan

Conflicts!

situchan · 2025-11-04T14:19:12Z

src/components/TestDrive/TestDriveDemo.tsx

+        InteractionManager.runAfterInteractions(() => {
+            completeTestDriveTask(viewTourTaskReport, viewTourTaskParentReport, isViewTourTaskParentReportArchived, currentUserPersonalDetails.accountID);
+        });
+    }, [viewTourTaskReport, viewTourTaskParentReport, isViewTourTaskParentReportArchived, currentUserPersonalDetails.accountID, completeTestDriveTask]);


Suggested change

}, [viewTourTaskReport, viewTourTaskParentReport, isViewTourTaskParentReportArchived, currentUserPersonalDetails.accountID, completeTestDriveTask]);

}, [viewTourTaskReport, viewTourTaskParentReport, isViewTourTaskParentReportArchived, currentUserPersonalDetails.accountID]);

ShridharGoel · 2025-11-04T14:23:38Z

Updated

situchan · 2025-11-04T14:27:51Z

src/components/TestDrive/TestDriveDemo.tsx

+
+        // eslint-disable-next-line @typescript-eslint/no-deprecated
+        InteractionManager.runAfterInteractions(() => {
+            completeTestDriveTask(viewTourTaskReport, viewTourTaskParentReport, isViewTourTaskParentReportArchived, currentUserPersonalDetails.accountID);


This call is now duplicated. Please check #73749 and refactor code accordingly.

joekaufmanexpensify

Change looks good to me from a product perspective 👍

situchan

Please

src/components/TestDrive/TestDriveDemo.tsx

Co-authored-by: Situ Chandra Shil <108292595+situchan@users.noreply.github.com>

situchan · 2025-11-05T07:15:13Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: HybridApp

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

situchan · 2025-11-05T07:33:19Z

@ShridharGoel please update test steps.

Complete the onboarding flow.

This doesn't make sense.

You missed important step:

Select Manage my team's expenses

ShridharGoel · 2025-11-05T07:38:40Z

@situchan But the test drive shows even if we select some other option

situchan · 2025-11-05T07:39:28Z

@situchan But the test drive shows even if we select some other option

But it doesn't lead to completing task

ShridharGoel · 2025-11-05T07:39:46Z

But I've updated the steps now

ShridharGoel · 2025-11-05T07:40:02Z

But it doesn't lead to completing task

Oh ok

situchan

OSBotify · 2025-11-05T13:53:58Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-11-05T20:38:46Z

🚀 Deployed to staging by https://github.com/flodnv in version: 9.2.45-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-11-06T23:21:19Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.45-6 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Autocomplete test drive task

097c69c

ShridharGoel requested a review from a team as a code owner November 3, 2025 17:57

melvin-bot bot assigned ShridharGoel Nov 3, 2025

melvin-bot bot requested review from situchan and removed request for a team November 3, 2025 17:57

github-actions bot reviewed Nov 3, 2025

View reviewed changes

Updates

6a05f2b

Fix typecheck

1ccc38c

situchan suggested changes Nov 4, 2025

View reviewed changes

Merge branch 'main' into taskAutocomplete

dfa029b

ShridharGoel requested a review from a team as a code owner November 4, 2025 14:23

melvin-bot bot requested review from joekaufmanexpensify and removed request for a team November 4, 2025 14:23

situchan reviewed Nov 4, 2025

View reviewed changes

Update based on new changes in main

1d126bf

joekaufmanexpensify previously approved these changes Nov 4, 2025

View reviewed changes

situchan suggested changes Nov 4, 2025

View reviewed changes

src/components/TestDrive/TestDriveDemo.tsx Outdated Show resolved Hide resolved

Update

44e0b97

Co-authored-by: Situ Chandra Shil <108292595+situchan@users.noreply.github.com>

ShridharGoel dismissed joekaufmanexpensify’s stale review via 44e0b97 November 4, 2025 16:32

situchan approved these changes Nov 5, 2025

View reviewed changes

melvin-bot bot requested a review from flodnv November 5, 2025 07:50

flodnv approved these changes Nov 5, 2025

View reviewed changes

flodnv merged commit 1a4004c into Expensify:main Nov 5, 2025
27 of 30 checks passed

OSBotify mentioned this pull request Nov 5, 2025

Deploy Checklist: New Expensify 2025-11-05 #74371

Closed

79 tasks

melvin-bot bot mentioned this pull request Nov 6, 2025

[Due for payment 2025-11-13] [$250] EX-43 - How would you like to get started - Task not autocompleted after test drive #71688

Closed

8 tasks

	}, [viewTourTaskReport, viewTourTaskParentReport, isViewTourTaskParentReportArchived, currentUserPersonalDetails.accountID, completeTestDriveTask]);
	}, [viewTourTaskReport, viewTourTaskParentReport, isViewTourTaskParentReportArchived, currentUserPersonalDetails.accountID]);

Conversation

ShridharGoel commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Nov 3, 2025

Uh oh!

github-actions bot Nov 3, 2025

Choose a reason for hiding this comment

❌ PERF-6 (docs)

Uh oh!

codecov bot commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

situchan left a comment

Choose a reason for hiding this comment

Uh oh!

situchan Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

ShridharGoel commented Nov 4, 2025

Uh oh!

situchan Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

ShridharGoel Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

situchan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

situchan commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

situchan commented Nov 5, 2025

Uh oh!

ShridharGoel commented Nov 5, 2025

Uh oh!

situchan commented Nov 5, 2025

Uh oh!

ShridharGoel commented Nov 5, 2025

Uh oh!

ShridharGoel commented Nov 5, 2025

Uh oh!

situchan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Nov 5, 2025

Uh oh!

OSBotify commented Nov 5, 2025

Uh oh!

OSBotify commented Nov 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ShridharGoel commented Nov 3, 2025 •

edited

Loading

codecov bot commented Nov 3, 2025 •

edited

Loading

situchan commented Nov 5, 2025 •

edited

Loading